Skip to content

feat(ffe)!: remove extra_logging#1941

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
oleksii/jj-qyxprulrqtro
May 1, 2026
Merged

feat(ffe)!: remove extra_logging#1941
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
oleksii/jj-qyxprulrqtro

Conversation

@dd-oleksii

@dd-oleksii dd-oleksii commented May 1, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Remove extra_logging handling.

Motivation

It was a leftover from migration and was never used. It is also never emitted by the backend.

Additional Notes

Stacked on top of #1940 to avoid merge conflicts.

How to test the change?

@dd-oleksii
dd-oleksii requested a review from a team as a code owner May 1, 2026 09:44
@dd-oleksii
dd-oleksii requested review from sameerank and typotter and removed request for a team May 1, 2026 09:44
@github-actions

github-actions Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/oleksii/jj-qyxprulrqtro

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 21 21 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 57 57 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-stats 1 1 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 199 199 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 1, 2026 •
edited by datadog-prod-us1-5 Bot
Loading

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.74% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d5565c9 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.74%. Comparing base (e2b0a84) to head (d5565c9).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
+ Coverage   71.69%   71.74%   +0.04%     
==========================================
  Files         434      434              
  Lines       70408    70379      -29     
==========================================
+ Hits        50477    50491      +14     
+ Misses      19931    19888      -43
Components Coverage Δ
libdd-crashtracker 66.02% <ø> (+0.01%) ⬆️
libdd-crashtracker-ffi 34.47% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 85.86% <ø> (ø)
libdd-data-pipeline-ffi 71.79% <ø> (ø)
libdd-common 79.37% <ø> (ø)
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 68.06% <ø> (-0.03%) ⬇️
libdd-telemetry-ffi 19.37% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 76.31% <ø> (+0.04%) ⬆️
libdd-profiling 81.61% <ø> (-0.02%) ⬇️
libdd-profiling-ffi 64.36% <ø> (ø)
datadog-sidecar 28.92% <ø> (ø)
datdog-sidecar-ffi 8.78% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.26% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.38% <ø> (+0.11%) ⬆️
libdd-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dd-octo-sts

dd-octo-sts Bot commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.63 MB 7.63 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 83.43 MB 83.32 MB --.12% (-110.03 KB) 💪
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.54 MB 99.45 MB --.09% (-101.49 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.17 MB 10.17 MB --.01% (-1.78 KB) 💪
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.25 MB 25.21 MB --.12% (-32.50 KB) 💪
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.57 KB --.40% (-330 B) 💪
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.80 MB 184.50 MB --.16% (-304.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 919.47 MB 918.30 MB --.12% (-1.16 MB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 7.90 MB 7.89 MB --.09% (-7.50 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.57 KB --.40% (-330 B) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.70 MB 23.68 MB --.09% (-24.00 KB) 💪
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 46.24 MB 46.20 MB --.08% (-39.93 KB) 💪
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.72 MB 21.69 MB --.13% (-29.50 KB) 💪
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.14 KB 80.81 KB --.40% (-334 B) 💪
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.95 MB 188.65 MB --.16% (-312.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 905.17 MB 904.01 MB --.12% (-1.16 MB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.14 MB 6.14 MB --.08% (-5.50 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.14 KB 80.81 KB --.40% (-334 B) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 25.40 MB 25.37 MB --.12% (-32.00 KB) 💪
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 43.73 MB 43.69 MB --.09% (-41.47 KB) 💪
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.37 MB 74.29 MB --.10% (-82.01 KB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.56 MB 8.55 MB --.13% (-12.00 KB) 💪
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.91 MB 91.83 MB --.08% (-76.05 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.21 MB 10.21 MB --.05% (-5.38 KB) 💪

Base automatically changed from oleksii/jj-orzxxoswrvtt to main May 1, 2026 16:39
@dd-oleksii
feat(ffe)!: remove extra_logging
d5565c9 
It was a leftover from migration and was never used.
@dd-oleksii
dd-oleksii force-pushed the oleksii/jj-qyxprulrqtro branch from 3be0d48 to d5565c9 Compare May 1, 2026 17:04
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 5db2a80 into main May 1, 2026
113 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the oleksii/jj-qyxprulrqtro branch May 1, 2026 18:13
@gyuheon0h gyuheon0h mentioned this pull request May 9, 2026
Merged
gh-worker-dd-mergequeue-cf854d Bot pushed a commit to DataDog/dd-trace-py that referenced this pull request May 12, 2026
@gyuheon0h
chore(libdatadog): bump libdatadog to v33.0.0 (#17992)
84cc87a 
## Description

Libdatadog v33 is out. Let's bump the version to stay up to date. 

Only non-trivial change is the removal of `extra_logging`. It was a leftover from migration and was never used. It is also never emitted by the backend. ([feat(ffe)!: remove extra_logging](DataDog/libdatadog#1941))

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks -->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->


Co-authored-by: gyuheon.oh <[email protected]>
P403n1x87 pushed a commit to DataDog/dd-trace-py that referenced this pull request May 14, 2026
@gyuheon0h @P403n1x87
chore(libdatadog): bump libdatadog to v33.0.0 (#17992)
8db90c3 
## Description

Libdatadog v33 is out. Let's bump the version to stay up to date. 

Only non-trivial change is the removal of `extra_logging`. It was a leftover from migration and was never used. It is also never emitted by the backend. ([feat(ffe)!: remove extra_logging](DataDog/libdatadog#1941))

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks -->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->


Co-authored-by: gyuheon.oh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sameerank sameerank sameerank approved these changes
@typotter typotter Awaiting requested review from typotter typotter is a code owner automatically assigned from DataDog/feature-flagging-and-experimentation-sdk

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dd-oleksii @codecov-commenter @sameerank