feat(ffe): add __dd_allocation_key metadata to ResolutionDetails#1940
Merged
Merged
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1940 +/- ##
==========================================
- Coverage 71.73% 71.64% -0.09%
==========================================
Files 434 434
Lines 70395 70408 +13
==========================================
- Hits 50497 50447 -50
- Misses 19898 19961 +63
🚀 New features to boost your workflow:
|
Contributor
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 53a1543 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
leoromanovsky
approved these changes
May 1, 2026
leoromanovsky
left a comment
leoromanovsky
left a comment
Contributor
There was a problem hiding this comment.
anything to add to the json test fixtures?
Member
Author
As Sameeran found, the tracers are currently unaligned an what metadata they attach. It's also an internal detail But... it's a good idea to add allocation assertions to system tests |
sameerank
approved these changes
May 1, 2026
| inner, | ||
| error_message, | ||
| extra_logging, | ||
| flag_metadata, |
Contributor
There was a problem hiding this comment.
Oh nice, it makes sense to do this here given that we were already passing flag metadata
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
May 1, 2026
# What does this PR do? Remove `extra_logging` handling. # Motivation It was a leftover from migration and was never used. It is also never emitted by the backend. # Additional Notes Stacked on top of #1940 to avoid merge conflicts. # How to test the change? Co-authored-by: oleksii.shmalko <[email protected]>
This was referenced May 4, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
__dd_allocation_keymetadata toResolutionDetails.Motivation
Follow-up from DataDog/dd-trace-rb#5599 (comment)
Additional Notes
How to test the change?