feat(shared_runtime)!: allow worker to be stopped after fork#1893
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom Apr 20, 2026
Merged
feat(shared_runtime)!: allow worker to be stopped after fork#1893gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
VianneyRuhlmann
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
+ Coverage 71.60% 71.62% +0.02%
==========================================
Files 431 431
Lines 69156 69178 +22
==========================================
+ Hits 49517 49552 +35
+ Misses 19639 19626 -13
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 95ced97 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Aaalibaba42
approved these changes
Apr 20, 2026
paullegranddc
approved these changes
Apr 20, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
vianney/cleanup_after_fork
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow a worker to not be restarted after a fork in the child, the worker is instead dropped without calling shutdown.
Motivation
Currently the trace exporter is recreated on forks in dd-trace-py, this is down without calling shutdown to avoid flushing data twice. To avoid restarting workers and keeping them around, the trace exporter workers are not restarted after the fork.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.