Skip to content

feat(crashtracking)!: collect all threads#1878

Merged
gyuheon0h merged 31 commits into
mainfrom
gyuheon0h/PROF-14275-collect-all-threads
May 7, 2026
Merged

feat(crashtracking)!: collect all threads#1878
gyuheon0h merged 31 commits into
mainfrom
gyuheon0h/PROF-14275-collect-all-threads

Conversation

@gyuheon0h

@gyuheon0h gyuheon0h commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

When a process crashes the crashtracker now captures a full stack trace for every live non-crashing thread and includes them in the crash report under error.threads.

Previously only the crashing thread's stack was reported. Customers had no visibility into what other threads were doing at the time of the crash, making it much harder to diagnose race conditions, deadlocks, and cross-thread interactions.

Thread collection runs entirely in the receiver process after it has finished reading the crash pipe. Because the crashed process stays alive in its signal handler until the receiver calls finish(), all threads remain valid ptrace targets for the entire collection window.

The receiver:

  1. Enumerates threads from /proc/<pid>/task/
  2. Attaches to each non-crashing thread with PTRACE_SEIZE + PTRACE_INTERRUPT
  3. Uses libunwind remote unwinding (_UPT_create / unw_init_remote / unw_step_remote) to walk each thread's stack
  4. Thread names and states are read from /proc//task//stat`
  5. Thread collection is opt-in using CrashtrackerConfiguration::set_collect_all_threads(true) and bounded by a max of 256. The user can also set a lower boundary using CrashtrackerConfiguration::set_max_threads() . The collection timeout is the remaining slice of the receiver's deadline after the crash pipe is fully read, so the total receiver lifetime is always bounded by config.timeout()

Breaking changes

Updated data schema to 1.7; there is now a Threads object.

Errors intake upload still sends an array of ThreadData, as that is the schema that the enrichment pipeline expects

CrashtrackerConfig now has

pub struct CrashtrackerConfiguration {
    additional_files: Vec<String>,
    collect_all_threads: bool, <-- NEW
    create_alt_stack: bool,
    demangle_names: bool,
    endpoint: Option<Endpoint>,
    max_threads: usize, <-- NEW 
    resolve_frames: StacktraceCollection,
    signals: Vec<i32>,
    timeout: Duration,
    unix_socket_path: Option<String>,
    use_alt_stack: bool,
}
config.set_collect_all_threads(true);
config.set_max_threads(128);          // how many threads to collect
CrashtrackerConfiguration::builder()
    .collect_all_threads(true)
    .max_threads(128)
    .build()?;

Additional notes

One enhancement we can do is to collect even the crashing thread in the receiver along with all threads, since enumerating all threads touches the crashing thread also. We can do this by checking for the crashing thread first in the receiver, then checking all threads.

However, this will be explored in a future PR/investigation, as this is changing the core crashing thread unwinding logic

How to test the change?

Run a crash with a program with multiple threads, with all thread collection turned on.

Bin tests also added to test e2e flow

{
      "is_crash": true,
      "kind": "UnixSignal",
      "message": "Process terminated with SEGV_MAPERR (SIGSEGV)",
      "thread_name": "crashtracker_bi",
      "source_type": "Crashtracking",
      "stack": {
        "format": "Datadog Crashtracker 1.0",
        "frames": [
          {
            "ip": "0x5d1e89d2adcb",
            "module_base_address": "0x5d1e89cfd000",
            "sp": "0x7ffc9f327330",
            "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
            "build_id_type": "GNU",
            "file_type": "ELF",
            "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
            "relative_address": "0x000000000002ddcb",
            "column": 13,
            "file": "/home/bits/go/src/github.com/DataDog/libdatadog/bin_tests/src/bin/crashtracker_bin_test.rs",
            "function": "cause_segfault",
            "line": 37
          },
         ...
          {
            "ip": "0x5d1e89d29405",
            "module_base_address": "0x5d1e89cfd000",
            "sp": "0x7ffc9f327d70",
            "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
            "build_id_type": "GNU",
            "file_type": "ELF",
            "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
            "relative_address": "0x000000000002c405",
            "function": "_start"
          }
        ],
        "incomplete": false
      },
      "threads": [
        {
          "crashed": false,
          "name": "ct_worker_0",
          "stack": {
            "format": "Datadog Crashtracker 1.0",
            "frames": [
              {
                "ip": "0x5d1e89d34b57",
                "sp": "0x778c6131ed48",
                "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000037b57",
                "column": 9,
                "file": "/home/bits/go/src/github.com/DataDog/libdatadog/bin_tests/src/modes/unix/test_017_multi_thread_collection.rs",
                "function": "worker_fn_0",
                "line": 21
              },
              {
                "ip": "0x5d1e89d34b2c",
                "sp": "0x778c6131ed50",
                "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000037b2c",
                "column": 18,
                "file": "/home/bits/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/backtrace.rs",
                "function": "__rust_begin_short_backtrace<bin_tests::modes::unix::test_017_multi_thread_collection::{impl#0}::post::{closure_env#0}, ()>",
                "line": 158
              },
              {
                "ip": "0x5d1e89d349e4",
                "sp": "0x778c6131ed70",
                "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x00000000000379e4",
                "column": 5,
                "file": "/home/bits/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs",
                "function": "call_once<std::thread::{impl#0}::spawn_unchecked_::{closure_env#1}<bin_tests::modes::unix::test_017_multi_thread_collection::{impl#0}::post::{closure_env#0}, ()>, ()>",
                "line": 250
              },
              {
                "ip": "0x5d1e89d8223f",
                "sp": "0x778c6131edf0",
                "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x000000000008523f",
                "column": 17,
                "file": "/rustc/ded5c06cf21d2b93bffd5d884aa6e96934ee4234/library/std/src/sys/thread/unix.rs",
                "function": "std::sys::thread::unix::Thread::new::thread_start",
                "line": 126
              },
              {
                "ip": "0x778c613c7ac3",
                "sp": "0x778c6131ee20",
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x0000000000094ac3",
                "column": 8,
                "file": "./nptl/pthread_create.c",
                "function": "start_thread",
                "line": 442
              },
              {
                "ip": "0x778c614598c0",
                "sp": "0x778c6131eec0",
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x00000000001268c0",
                "column": 0,
                "file": "./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S",
                "function": "__clone3",
                "line": 83
              }
            ],
            "incomplete": false
          },
          "state": "R"
        },
        {
          "crashed": false,
          "name": "ct_worker_1",
          "stack": {
            "format": "Datadog Crashtracker 1.0",
            "frames": [
              {
                "ip": "0x5d1e89d34894",
                "sp": "0x778c6111dd48",
                "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000037894",
                "column": 9,
                "file": "/home/bits/go/src/github.com/DataDog/libdatadog/bin_tests/src/modes/unix/test_017_multi_thread_collection.rs",
                "function": "worker_fn_1",
                "line": 29
              },
              {
                "ip": "0x5d1e89d34869",
                "sp": "0x778c6111dd50",
                "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000037869",
                "column": 18,
                "file": "/home/bits/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/backtrace.rs",
                "function": "__rust_begin_short_backtrace<bin_tests::modes::unix::test_017_multi_thread_collection::{impl#0}::post::{closure_env#1}, ()>",
                "line": 158
              },
              {
                "ip": "0x5d1e89d34719",
                "sp": "0x778c6111dd70",
                "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x0000000000037719",
                "column": 5,
                "file": "/home/bits/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs",
                "function": "call_once<std::thread::{impl#0}::spawn_unchecked_::{closure_env#1}<bin_tests::modes::unix::test_017_multi_thread_collection::{impl#0}::post::{closure_env#1}, ()>, ()>",
                "line": 250
              },
              {
                "ip": "0x5d1e89d8223f",
                "sp": "0x778c6111ddf0",
                "build_id": "8d4cd090dde4a270bed5fb7f8168dcc1291051e0",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/home/bits/go/src/github.com/DataDog/libdatadog/target/release/crashtracker_bin_test",
                "relative_address": "0x000000000008523f",
                "column": 17,
                "file": "/rustc/ded5c06cf21d2b93bffd5d884aa6e96934ee4234/library/std/src/sys/thread/unix.rs",
                "function": "std::sys::thread::unix::Thread::new::thread_start",
                "line": 126
              },
              {
                "ip": "0x778c613c7ac3",
                "sp": "0x778c6111de20",
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x0000000000094ac3",
                "column": 8,
                "file": "./nptl/pthread_create.c",
                "function": "start_thread",
                "line": 442
              },
              {
                "ip": "0x778c614598c0",
                "sp": "0x778c6111dec0",
                "build_id": "4f7b0c955c3d81d7cac1501a2498b69d1d82bfe7",
                "build_id_type": "GNU",
                "file_type": "ELF",
                "path": "/usr/lib/x86_64-linux-gnu/libc.so.6",
                "relative_address": "0x00000000001268c0",
                "column": 0,
                "file": "./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S",
                "function": "__clone3",
                "line": 83
              }
            ],
            "incomplete": false
          },
          "state": "R"
        }
      ]
    }
    ```

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title Collect all threads first pass feat(crashtracking)!: collect all threads Apr 14, 2026
@github-actions

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/gyuheon0h/PROF-14275-collect-all-threads

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 21 21 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 57 57 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 20 19 ✅ -1 (-5.0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-stats 1 1 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 200 199 ✅ -1 (-0.5%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 37.48%
Overall Coverage: 71.60% (-0.23%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6a86bed | Docs | Datadog PR Page | Give us feedback!

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 5 times, most recently from 6187d0a to 3f70266 Compare April 14, 2026 18:25
@codecov-commenter

codecov-commenter commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.47535% with 317 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.60%. Comparing base (43c0973) to head (6a86bed).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   71.73%   71.60%   -0.14%     
==========================================
  Files         434      437       +3     
  Lines       70395    71112     +717     
==========================================
+ Hits        50497    50918     +421     
- Misses      19898    20194     +296     
Components Coverage Δ
libdd-crashtracker 64.69% <43.29%> (-1.33%) ⬇️
libdd-crashtracker-ffi 34.09% <ø> (-0.39%) ⬇️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 86.28% <ø> (+0.41%) ⬆️
libdd-data-pipeline-ffi 73.93% <ø> (+2.13%) ⬆️
libdd-common 79.73% <ø> (+0.36%) ⬆️
libdd-common-ffi 74.41% <ø> (+0.54%) ⬆️
libdd-telemetry 69.26% <ø> (+1.17%) ⬆️
libdd-telemetry-ffi 19.37% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 76.22% <ø> (-0.09%) ⬇️
libdd-profiling 81.62% <ø> (+0.01%) ⬆️
libdd-profiling-ffi 64.51% <ø> (+0.15%) ⬆️
datadog-sidecar 28.61% <ø> (-0.32%) ⬇️
datdog-sidecar-ffi 7.31% <ø> (-1.48%) ⬇️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.26% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.27% <ø> (-0.12%) ⬇️
libdd-tracer-flare 86.88% <ø> (ø)
libdd-log 74.83% <ø> (+0.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dd-octo-sts

dd-octo-sts Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.63 MB 7.70 MB +.81% (+64.08 KB) 🔍
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 83.42 MB 83.94 MB +.61% (+524.77 KB) 🔍
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.54 MB 100.28 MB +.74% (+755.67 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.17 MB 10.18 MB +.08% (+8.51 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.25 MB 25.26 MB +.03% (+9.50 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.90 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.76 MB 184.81 MB +.02% (+48.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 919.45 MB 919.60 MB +.01% (+154.69 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 7.90 MB 7.90 MB +.02% (+2.00 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.90 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.70 MB 23.71 MB +.03% (+8.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 46.23 MB 46.24 MB +.02% (+10.78 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.72 MB 21.73 MB +.04% (+9.00 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.14 KB 81.14 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.94 MB 188.98 MB +.02% (+48.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 905.15 MB 905.30 MB +.01% (+152.12 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.14 MB 6.14 MB +.03% (+2.00 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.14 KB 81.14 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 25.39 MB 25.40 MB +.03% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 43.72 MB 43.73 MB +.02% (+11.19 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.36 MB 74.69 MB +.43% (+332.70 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.56 MB 8.58 MB +.27% (+24.10 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.90 MB 92.48 MB +.63% (+593.26 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.21 MB 10.24 MB +.26% (+28.14 KB) 🔍

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 3 times, most recently from e96cb1a to 42d4665 Compare April 15, 2026 14:29
@gyuheon0h gyuheon0h changed the title feat(crashtracking)!: collect all threads [WIP WIP WIP WIP WIP WIP] feat(crashtracking)!: collect all threads Apr 15, 2026
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 4 times, most recently from 25853ed to a4b82cb Compare April 20, 2026 16:55
@gyuheon0h gyuheon0h changed the title [WIP WIP WIP WIP WIP WIP] feat(crashtracking)!: collect all threads feat(crashtracking)!: collect all threads Apr 20, 2026
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 9 times, most recently from e58c6c4 to ddd4ab6 Compare April 27, 2026 14:17
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch from e91789b to cc21b35 Compare April 30, 2026 19:39
…:DataDog/libdatadog into gyuheon0h/PROF-14275-collect-all-threads
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch 2 times, most recently from 86a4b60 to a4ac74d Compare May 1, 2026 13:50
@gyuheon0h

Copy link
Copy Markdown
Contributor Author

@codex r

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch from a4ac74d to 3d3e060 Compare May 1, 2026 14:48
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch from 3d3e060 to dacc179 Compare May 1, 2026 15:49
Comment thread libdd-crashtracker/src/receiver/receive_report.rs Outdated

@yannham yannham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm less familiar with the libunwind part, but overall I was able to follow thanks to good comments and the syscall/ptrace business looks sound AFAICT 👍 just left minor/pedantic comments.

Comment thread bin_tests/src/modes/unix/test_018_thread_limit.rs Outdated
Comment thread bin_tests/tests/crashtracker_bin_test.rs Outdated
Comment thread bin_tests/tests/crashtracker_bin_test.rs
Comment thread libdd-crashtracker/src/collector/crash_handler.rs Outdated
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs Outdated
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs Outdated
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs Outdated
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs Outdated
Comment thread libdd-crashtracker/src/receiver/receive_report.rs Outdated
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch from 0e9d1d8 to 084db2f Compare May 6, 2026 13:37
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

📚 Documentation Check Results

⚠️ 2723 documentation warning(s) found

📦 bin_tests - 1656 warning(s)

📦 libdd-crashtracker - 1067 warning(s)


Updated: 2026-05-07 16:11:24 UTC | Commit: 34261cf | missing-docs job results

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🔒 Cargo Deny Results

⚠️ 10 issue(s) found, showing only errors (advisories, bans, sources)

📦 bin_tests - 6 error(s)

Show output
error[vulnerability]: NSEC3 closest-encloser proof validation enters unbounded loop on cross-zone responses
   ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:93:1
   │
93 │ hickory-proto 0.25.2 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
   │
   ├ ID: RUSTSEC-2026-0118
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0118
   ├ The NSEC3 closest-encloser proof validation in `hickory-proto`'s
     `DnssecDnsHandle` walks from the QNAME up to the SOA owner name, building a
     list of candidate encloser names. The iterator used assumes the
     QNAME is a descendant of the SOA owner, terminating only when the current
     candidate equals the SOA name. When the SOA in a response's authority section
     is not an ancestor of the QNAME, the loop stalls at the DNS root and never
     terminates, repeatedly calling `Name::base_name()` and pushing newly allocated
     `Name` and hashed-name entries into the candidate `Vec`.
     
     The bug is reachable by any caller of `DnssecDnsHandle` — including the
     resolver, recursor, and client — when built with the `dnssec-ring` or
     `dnssec-aws-lc-rs` feature and configured to perform DNSSEC validation. It is
     triggered while validating a NoData or NXDomain response whose authority
     section contains an SOA record from a zone other than an ancestor of the
     QNAME, on a code path that requires NSEC3 closest-encloser proof. In practice
     this can be reached through an insecure CNAME chain that crosses zone
     boundaries into a DNSSEC-signed zone returning NoData, but the minimum
     condition is just a mismatched SOA owner on a response requiring NSEC3
     validation.
     
     A `debug_assert_ne!(name, Name::root())` guards the loop body, so debug builds
     abort with a panic on the first iteration past the root. Release builds
     compile the assertion out and run the loop unbounded, allocating until the
     process exhausts available memory (OOM). A reachable upstream attacker who
     can return such a response can therefore crash a debug-built validator or
     exhaust memory on a release-built one.
     
     The affected code was migrated from `hickory-proto` to `hickory-net` as part of
     the 0.26.0 release. The `hickory-proto` 0.26.x release no longer offers
     `DnssecDnsHandle` and so we recommend all affected users update to `hickory-net`
     0.26.1 when the implementation of that type is required.
   ├ Announcement: https://github.com/hickory-dns/hickory-dns/security/advisories/GHSA-3v94-mw7p-v465
   ├ Solution: No safe upgrade is available!
   ├ hickory-proto v0.25.2
     └── hickory-resolver v0.25.2
         └── reqwest v0.13.2
             ├── libdd-common v4.0.0
             │   ├── bin_tests v0.1.0
             │   ├── (build) libdd-crashtracker v1.0.0
             │   │   └── bin_tests v0.1.0 (*)
             │   ├── libdd-profiling v1.0.0
             │   │   ├── bin_tests v0.1.0 (*)
             │   │   └── (dev) libdd-profiling v1.0.0 (*)
             │   ├── libdd-shared-runtime v0.1.0
             │   │   └── libdd-telemetry v4.0.0
             │   │       └── libdd-crashtracker v1.0.0 (*)
             │   └── libdd-telemetry v4.0.0 (*)
             └── libdd-profiling v1.0.0 (*)

error[vulnerability]: CPU exhaustion during message encoding due to O(n²) name compression
   ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:93:1
   │
93 │ hickory-proto 0.25.2 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
   │
   ├ ID: RUSTSEC-2026-0119
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0119
   ├ During message encoding, `hickory-proto`'s `BinEncoder` stores pointers to
     labels that are candidates for name compression in a `Vec<(usize, Vec<u8>)>`.
     The name compression logic then searches for matches with a linear scan.
     
     A malicious message with many records can both introduce many candidate labels,
     and invoke this linear scan many times. This can amplify CPU exhaustion in DoS
     attacks.
     
     This is similar to
     [CVE-2024-8508](https://www.nlnetlabs.nl/downloads/unbound/CVE-2024-8508.txt).
     
     We recommend all affected users update to `hickory-proto` 0.26.1 for the fix.
   ├ Announcement: https://github.com/hickory-dns/hickory-dns/security/advisories/GHSA-q2qq-hmj6-3wpp
   ├ Solution: Upgrade to >=0.26.1 (try `cargo update -p hickory-proto`)
   ├ hickory-proto v0.25.2
     └── hickory-resolver v0.25.2
         └── reqwest v0.13.2
             ├── libdd-common v4.0.0
             │   ├── bin_tests v0.1.0
             │   ├── (build) libdd-crashtracker v1.0.0
             │   │   └── bin_tests v0.1.0 (*)
             │   ├── libdd-profiling v1.0.0
             │   │   ├── bin_tests v0.1.0 (*)
             │   │   └── (dev) libdd-profiling v1.0.0 (*)
             │   ├── libdd-shared-runtime v0.1.0
             │   │   └── libdd-telemetry v4.0.0
             │   │       └── libdd-crashtracker v1.0.0 (*)
             │   └── libdd-telemetry v4.0.0 (*)
             └── libdd-profiling v1.0.0 (*)

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:201:1
    │
201 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── (dev) libdd-common v4.0.0
      │   ├── bin_tests v0.1.0
      │   ├── (build) libdd-crashtracker v1.0.0
      │   │   └── bin_tests v0.1.0 (*)
      │   ├── libdd-profiling v1.0.0
      │   │   ├── bin_tests v0.1.0 (*)
      │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   ├── libdd-shared-runtime v0.1.0
      │   │   └── libdd-telemetry v4.0.0
      │   │       └── libdd-crashtracker v1.0.0 (*)
      │   └── libdd-telemetry v4.0.0 (*)
      ├── libdd-crashtracker v1.0.0 (*)
      ├── libdd-profiling v1.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-profiling v1.0.0 (*)

error[vulnerability]: Name constraints for URI names were incorrectly accepted
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:226:1
    │
226 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0098
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0098
    ├ Name constraints for URI names were ignored and therefore accepted.
      
      Note this library does not provide an API for asserting URI names, and URI name constraints are otherwise not implemented.  URI name constraints are now rejected unconditionally.
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-965h-392x-2mh5](https://github.com/rustls/webpki/security/advisories/GHSA-965h-392x-2mh5). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v4.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── (build) libdd-crashtracker v1.0.0
      │   │   │   │   └── bin_tests v0.1.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v0.1.0
      │   │   │   │   └── libdd-telemetry v4.0.0
      │   │   │   │       └── libdd-crashtracker v1.0.0 (*)
      │   │   │   └── libdd-telemetry v4.0.0 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v4.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v4.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v4.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

error[vulnerability]: Name constraints were accepted for certificates asserting a wildcard name
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:226:1
    │
226 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0099
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0099
    ├ Permitted subtree name constraints for DNS names were accepted for certificates asserting a wildcard name.
      
      This was incorrect because, given a name constraint of `accept.example.com`, `*.example.com` could feasibly allow a name of `reject.example.com` which is outside the constraint.
      This is very similar to [CVE-2025-61727](https://go.dev/issue/76442).
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-xgp8-3hg3-c2mh](https://github.com/rustls/webpki/security/advisories/GHSA-xgp8-3hg3-c2mh). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v4.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── (build) libdd-crashtracker v1.0.0
      │   │   │   │   └── bin_tests v0.1.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v0.1.0
      │   │   │   │   └── libdd-telemetry v4.0.0
      │   │   │   │       └── libdd-crashtracker v1.0.0 (*)
      │   │   │   └── libdd-telemetry v4.0.0 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v4.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v4.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v4.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

error[vulnerability]: Reachable panic in certificate revocation list parsing
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:226:1
    │
226 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0104
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0104
    ├ A panic was reachable when parsing certificate revocation lists via [`BorrowedCertRevocationList::from_der`]
      or [`OwnedCertRevocationList::from_der`].  This was the result of mishandling a syntactically valid empty
      `BIT STRING` appearing in the `onlySomeReasons` element of a `IssuingDistributionPoint` CRL extension.
      
      This panic is reachable prior to a CRL's signature being verified.
      
      Applications that do not use CRLs are not affected.
      
      Thank you to @tynus3 for the report.
    ├ Solution: Upgrade to >=0.103.13, <0.104.0-alpha.1 OR >=0.104.0-alpha.7 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v4.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── (build) libdd-crashtracker v1.0.0
      │   │   │   │   └── bin_tests v0.1.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v0.1.0
      │   │   │   │   └── libdd-telemetry v4.0.0
      │   │   │   │       └── libdd-crashtracker v1.0.0 (*)
      │   │   │   └── libdd-telemetry v4.0.0 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v4.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v4.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v4.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

advisories FAILED, bans ok, sources ok

📦 libdd-crashtracker - 4 error(s)

Show output
error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:144:1
    │
144 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── libdd-common v4.0.0
      │   ├── (build) libdd-crashtracker v1.0.0
      │   ├── libdd-shared-runtime v0.1.0
      │   │   └── libdd-telemetry v4.0.0
      │   │       └── libdd-crashtracker v1.0.0 (*)
      │   └── libdd-telemetry v4.0.0 (*)
      └── libdd-crashtracker v1.0.0 (*)

error[vulnerability]: Name constraints for URI names were incorrectly accepted
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:158:1
    │
158 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0098
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0098
    ├ Name constraints for URI names were ignored and therefore accepted.
      
      Note this library does not provide an API for asserting URI names, and URI name constraints are otherwise not implemented.  URI name constraints are now rejected unconditionally.
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-965h-392x-2mh5](https://github.com/rustls/webpki/security/advisories/GHSA-965h-392x-2mh5). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      └── rustls v0.23.37
          ├── hyper-rustls v0.27.7
          │   └── libdd-common v4.0.0
          │       ├── (build) libdd-crashtracker v1.0.0
          │       ├── libdd-shared-runtime v0.1.0
          │       │   └── libdd-telemetry v4.0.0
          │       │       └── libdd-crashtracker v1.0.0 (*)
          │       └── libdd-telemetry v4.0.0 (*)
          ├── libdd-common v4.0.0 (*)
          └── tokio-rustls v0.26.0
              ├── hyper-rustls v0.27.7 (*)
              └── libdd-common v4.0.0 (*)

error[vulnerability]: Name constraints were accepted for certificates asserting a wildcard name
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:158:1
    │
158 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0099
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0099
    ├ Permitted subtree name constraints for DNS names were accepted for certificates asserting a wildcard name.
      
      This was incorrect because, given a name constraint of `accept.example.com`, `*.example.com` could feasibly allow a name of `reject.example.com` which is outside the constraint.
      This is very similar to [CVE-2025-61727](https://go.dev/issue/76442).
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-xgp8-3hg3-c2mh](https://github.com/rustls/webpki/security/advisories/GHSA-xgp8-3hg3-c2mh). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      └── rustls v0.23.37
          ├── hyper-rustls v0.27.7
          │   └── libdd-common v4.0.0
          │       ├── (build) libdd-crashtracker v1.0.0
          │       ├── libdd-shared-runtime v0.1.0
          │       │   └── libdd-telemetry v4.0.0
          │       │       └── libdd-crashtracker v1.0.0 (*)
          │       └── libdd-telemetry v4.0.0 (*)
          ├── libdd-common v4.0.0 (*)
          └── tokio-rustls v0.26.0
              ├── hyper-rustls v0.27.7 (*)
              └── libdd-common v4.0.0 (*)

error[vulnerability]: Reachable panic in certificate revocation list parsing
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:158:1
    │
158 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0104
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0104
    ├ A panic was reachable when parsing certificate revocation lists via [`BorrowedCertRevocationList::from_der`]
      or [`OwnedCertRevocationList::from_der`].  This was the result of mishandling a syntactically valid empty
      `BIT STRING` appearing in the `onlySomeReasons` element of a `IssuingDistributionPoint` CRL extension.
      
      This panic is reachable prior to a CRL's signature being verified.
      
      Applications that do not use CRLs are not affected.
      
      Thank you to @tynus3 for the report.
    ├ Solution: Upgrade to >=0.103.13, <0.104.0-alpha.1 OR >=0.104.0-alpha.7 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      └── rustls v0.23.37
          ├── hyper-rustls v0.27.7
          │   └── libdd-common v4.0.0
          │       ├── (build) libdd-crashtracker v1.0.0
          │       ├── libdd-shared-runtime v0.1.0
          │       │   └── libdd-telemetry v4.0.0
          │       │       └── libdd-crashtracker v1.0.0 (*)
          │       └── libdd-telemetry v4.0.0 (*)
          ├── libdd-common v4.0.0 (*)
          └── tokio-rustls v0.26.0
              ├── hyper-rustls v0.27.7 (*)
              └── libdd-common v4.0.0 (*)

advisories FAILED, bans ok, sources ok

Updated: 2026-05-07 16:11:21 UTC | Commit: 34261cf | dependency-check job results

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch from 58a0dd0 to 4abe584 Compare May 6, 2026 18:53
Comment thread libdd-crashtracker/src/receiver/receive_report.rs Outdated
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs Outdated
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs Outdated
Comment thread libdd-crashtracker/src/receiver/receive_report.rs
Comment thread libdd-crashtracker/src/shared/configuration/mod.rs Outdated
Comment thread libdd-crashtracker/src/receiver/receive_report.rs Outdated
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs Outdated
Comment thread libdd-crashtracker/src/receiver/ptrace_collector.rs
@gleocadie

Copy link
Copy Markdown
Contributor

Thread names and states are read from /proc//task//comm

Can you update the PR description, I did not see where you read the thread name from /proc/<pid>/task/<tid>/comm

@gyuheon0h

Copy link
Copy Markdown
Contributor Author

Can you update the PR description, I did not see where you read the thread name from /proc/<pid>/task/<tid>/comm

@gleocadie That was an earlier iteration. fixed

@gyuheon0h
gyuheon0h requested a review from gleocadie May 7, 2026 15:59
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-14275-collect-all-threads branch from 3008bf4 to 6a86bed Compare May 7, 2026 16:09

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
super nice :excited:

@gyuheon0h
gyuheon0h merged commit a8f0aaa into main May 7, 2026
72 of 73 checks passed
@gyuheon0h
gyuheon0h deleted the gyuheon0h/PROF-14275-collect-all-threads branch May 7, 2026 16:47
gyuheon0h added a commit that referenced this pull request May 7, 2026
…or collect all thread config (#1959)

# What does this PR do?

[feat(crashtracking)!: collect all
threads](#1878) added the
functionality to collect all threads. We should expose the config vals
for this



# Motivation

What inspired you to submit this pull request?

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?
```
pub struct Config<'a> {
    pub additional_files: Slice<'a, CharSlice<'a>>,
    /// If true, the receiver will collect stack traces for all threads in the crashing process
    /// (not just the crashing thread) using ptrace-based remote unwinding.
    pub collect_all_threads: bool, *******THIS IS NEW*******
    pub create_alt_stack: bool,
    pub demangle_names: bool,
    /// The endpoint to send the crash report to (can be a file://).
    /// If None, the crashtracker will infer the agent host from env variables.
    pub endpoint: EndpointConfig<'a>,
    /// Maximum number of non-crashing threads to collect when `collect_all_threads` is true.
    /// If 0, uses the default (`libdd_crashtracker::default_max_threads()`).
    pub max_threads: usize, *******THIS IS NEW*******
    /// Optional filename for a unix domain socket if the receiver is used asynchonously
    pub optional_unix_socket_filename: CharSlice<'a>,
    pub resolve_frames: StacktraceCollection,
    /// The set of signals we should be registered for.
    /// If empty, use the default set.
    pub signals: Slice<'a, i32>,
    /// Timeout in milliseconds before the signal handler starts tearing things down to return.
    /// If 0, uses the default timeout as specified in
    /// `libdd_crashtracker::shared::constants::DD_CRASHTRACK_DEFAULT_TIMEOUT`. Otherwise, uses
    /// the specified timeout value.
    /// This is given as a uint32_t, but the actual timeout needs to fit inside of an i32 (max
    /// 2^31-1). This is a limitation of the various interfaces used to guarantee the timeout.
    pub timeout_ms: u32,
    pub use_alt_stack: bool,
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants