perf(sidecar)!: Batch ack sending & consumption#1835
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomainfrom Apr 2, 2026
Merged
perf(sidecar)!: Batch ack sending & consumption#1835gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomainfrom
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
==========================================
+ Coverage 71.55% 71.60% +0.04%
==========================================
Files 426 426
Lines 67155 67287 +132
==========================================
+ Hits 48053 48181 +128
- Misses 19102 19106 +4
🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: bca1af9 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
bwoebi
changed the title
bwoebi
changed the title
Leiyks
approved these changes
Apr 2, 2026
Contributor
Leiyks
left a comment
Leiyks
left a comment
There was a problem hiding this comment.
few things worth nothing but overall looks good 👍
| #[cfg(target_os = "linux")] | ||
| { | ||
| __pending_acks += 1; | ||
| if #force_flush || __pending_acks >= 20 { |
Contributor
There was a problem hiding this comment.
Would be cleaner to add a constant like ACK_BUFFER_SIZE and reuse it in blocking.rs for consistency
| }; | ||
| let mut telemetry_guard = telemetry_mutex.lock_or_panic(); | ||
| let Some(telemetry) = telemetry_guard.as_mut() else { | ||
| return; // extremely rare: stopped again between the two get_or_create calls |
Contributor
There was a problem hiding this comment.
We should add a log here even if it is rare just in case
The newly introduced acks always require an additional syscall to consume them. Using recvmmsg() to batch it. Also only consume them when we actually need to check for limits. Also avoid resending Start each time we access the TelemetryCachedClient. (Pure overhead) Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: retrying
mergequeue-status: in_progress
and removed
mergequeue-status: retrying
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly introduced acks always require an additional syscall to consume them.
Using sendmmsg()/recvmmsg() to batch it. Also only consume them when we actually need to check for limits.
Also avoid resending Start each time we access the TelemetryCachedClient. (Pure overhead)