• chore(crashtracking): add integration test for errno preservation #1768
• chore(crashtracking): preserve errno for crashtracker #1767 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

• Base Branch: origin/main
• PR Branch: origin/gyuheon0h/PROF-14074-preserve-ct-errno

Summary by Rule

Annotation Counts by File

Annotation Stats by Crate

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

Benchmarks

Comparison

Benchmark execution time: 2026-03-19 21:46:01

Comparing candidate commit b5d393a in PR branch gyuheon0h/PROF-14074-preserve-ct-errno with baseline commit c6ef98e in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:credit_card/is_card_number/378282246310005

• 🟩 execution_time [-14.529µs; -14.462µs] or [-18.285%; -18.201%]
• 🟩 throughput [+2801367.872op/s; +2815471.015op/s] or [+22.259%; +22.371%]

Candidate

Baseline

Omitted due to size.

Artifact Size Benchmark Report

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.27%. Comparing base (c6ef98e) to head (b5d393a).

@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
- Coverage   71.28%   71.27%   -0.01%     
==========================================
  Files         431      431              
  Lines       64585    64587       +2     
==========================================
- Hits        46038    46036       -2     
- Misses      18547    18551       +4     

Do we have tests for chaining crash handlers? If so, we could make one of them set errno to a known value, then check that it still has that value after our crash-handler runs. If we don't have tests for chaining crash handlers, we should add some (but in a different PR)

Do we have tests for chaining crash handlers? If so, we could make one of them set errno to a known value, then check that it still has that value after our crash-handler runs. If we don't have tests for chaining crash handlers, we should add some (but in a different PR)

@danielsn

We have integration test (bin_test) that tests chaining handlers, but it is very minimal and designed to be run as a minimal bin test.

However, to test errno preservation, at the minimum, we will need to install a handler that will be chained after the ct signal handler, set an errno, then in the chained handler, check the errno and somehow emit that so that the post-test verifiers can verify that the errno seen by the chained handler is the same as the one set before the crash. This means that we will have to rip out the existing chained handler bin tests from their "simple tests" harness. I don't want to do that since it means breaking existing clean category of tests just to add another verification step, so I made a new PR on top of this one to do this in a separate bin test.

The PR is here: chore(crashtracking): add integration test for errno preservation