Skip to content

chore(examples): add compilation flags to prevent logic errors#1766

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
julio/compiler-flags
Mar 20, 2026
Merged

chore(examples): add compilation flags to prevent logic errors#1766
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
julio/compiler-flags

Conversation

@hoolioh
Copy link
Copy Markdown
Contributor

@hoolioh hoolioh commented Mar 19, 2026

What does this PR do?

It enables all warnings and set them as errors in order to prevent logic erros.

Motivation

While fiddling with the ffi interface I found a bug which was not detected by the compiler where an incompatible casting was compiled away.

@hoolioh hoolioh requested a review from a team as a code owner March 19, 2026 17:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.33%. Comparing base (d143fea) to head (6c38c13).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1766      +/-   ##
==========================================
- Coverage   71.50%   71.33%   -0.17%     
==========================================
  Files         430      431       +1     
  Lines       64268    64709     +441     
==========================================
+ Hits        45952    46160     +208     
- Misses      18316    18549     +233
Components Coverage Δ
libdd-crashtracker 64.93% <ø> (ø)
libdd-crashtracker-ffi 34.86% <ø> (-0.13%) ⬇️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 87.99% <ø> (+<0.01%) ⬆️
libdd-data-pipeline-ffi 75.20% <ø> (-0.70%) ⬇️
libdd-common 79.87% <ø> (ø)
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.29% <ø> (-0.07%) ⬇️
libdd-profiling 81.61% <ø> (+0.13%) ⬆️
libdd-profiling-ffi 64.94% <ø> (+1.29%) ⬆️
datadog-sidecar 31.60% <ø> (-0.97%) ⬇️
datdog-sidecar-ffi 8.71% <ø> (+0.29%) ⬆️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 92.22% <ø> (+0.42%) ⬆️
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.05% <ø> (-0.03%) ⬇️
datadog-tracer-flare 86.88% <ø> (-3.59%) ⬇️
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 19, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-03-20 13:49:54

Comparing candidate commit 6c38c13 in PR branch julio/compiler-flags with baseline commit 26caae8 in branch main.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:benching serializing traces from their internal representation to msgpack

  • 🟥 execution_time [+717.436µs; +729.477µs] or [+5.132%; +5.218%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-20.812µs; -20.667µs] or [-22.052%; -21.899%]
  • 🟩 throughput [+2974194.235op/s; +2994730.337op/s] or [+28.068%; +28.262%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.243µs 33.935µs ± 0.851µs 33.424µs ± 0.065µs 35.027µs 35.433µs 35.468µs 36.443µs 9.03% 0.978 -0.842 2.50% 0.060µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.817µs; 34.053µs] or [-0.348%; +0.348%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.390µs 2.417µs ± 0.022µs 2.412µs ± 0.010µs 2.423µs 2.477µs 2.486µs 2.493µs 3.32% 1.722 2.905 0.89% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.414µs; 2.420µs] or [-0.124%; +0.124%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 84.266µs 84.570µs ± 0.169µs 84.551µs ± 0.039µs 84.586µs 84.713µs 84.948µs 86.479µs 2.28% 7.925 82.705 0.20% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [84.547µs; 84.593µs] or [-0.028%; +0.028%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2598 execution_time 3.408ms 3.433ms ± 0.015ms 3.430ms ± 0.007ms 3.437ms 3.463ms 3.478ms 3.543ms 3.30% 2.637 13.216 0.45% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2598 execution_time [3.430ms; 3.435ms] or [-0.062%; +0.062%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.269µs 3.252µs ± 1.435µs 3.021µs ± 0.027µs 3.046µs 3.660µs 14.130µs 14.893µs 393.01% 7.302 54.695 44.02% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.053µs; 3.451µs] or [-6.117%; +6.117%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.264ms 4.268ms ± 0.003ms 4.268ms ± 0.001ms 4.270ms 4.274ms 4.277ms 4.301ms 0.78% 4.554 37.132 0.08% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.268ms; 4.269ms] or [-0.011%; +0.011%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.378µs 146.599µs ± 1.718µs 146.324µs ± 0.454µs 146.857µs 148.059µs 152.863µs 162.877µs 11.31% 5.706 44.483 1.17% 0.121µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.361µs; 146.837µs] or [-0.162%; +0.162%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.649ms 14.704ms ± 0.030ms 14.700ms ± 0.016ms 14.720ms 14.748ms 14.819ms 14.853ms 1.04% 1.598 5.041 0.20% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.700ms; 14.709ms] or [-0.028%; +0.028%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_timestamped_x1000 execution_time 4.203ms 4.210ms ± 0.008ms 4.209ms ± 0.002ms 4.211ms 4.214ms 4.220ms 4.310ms 2.40% 11.010 138.733 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_timestamped_x1000 execution_time [4.209ms; 4.211ms] or [-0.025%; +0.025%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 495.423µs 496.178µs ± 0.624µs 496.091µs ± 0.247µs 496.362µs 496.821µs 497.383µs 502.780µs 1.35% 6.489 62.993 0.13% 0.044µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1988941.485op/s 2015407.544op/s ± 2513.189op/s 2015758.416op/s ± 1003.566op/s 2016583.995op/s 2017764.296op/s 2018282.708op/s 2018475.782op/s 0.13% -6.403 61.758 0.12% 177.709op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 377.044µs 377.957µs ± 0.414µs 377.915µs ± 0.272µs 378.215µs 378.707µs 379.024µs 379.453µs 0.41% 0.510 0.432 0.11% 0.029µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2635371.289op/s 2645806.666op/s ± 2896.467op/s 2646097.516op/s ± 1908.157op/s 2647913.681op/s 2650197.097op/s 2651791.663op/s 2652207.600op/s 0.23% -0.503 0.420 0.11% 204.811op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 168.797µs 169.112µs ± 0.472µs 169.067µs ± 0.086µs 169.150µs 169.277µs 169.502µs 173.691µs 2.73% 8.829 81.982 0.28% 0.033µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5757366.115op/s 5913290.923op/s ± 16112.332op/s 5914801.006op/s ± 3021.705op/s 5917864.581op/s 5922243.709op/s 5924107.110op/s 5924279.986op/s 0.16% -8.778 81.342 0.27% 1139.314op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.844µs 37.039µs ± 0.115µs 37.067µs ± 0.088µs 37.133µs 37.190µs 37.268µs 37.288µs 0.60% -0.179 -1.174 0.31% 0.008µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26818335.327op/s 26998651.856op/s ± 84178.170op/s 26978453.585op/s ± 63763.470op/s 27078141.025op/s 27128275.997op/s 27135574.826op/s 27141505.408op/s 0.60% 0.187 -1.177 0.31% 5952.296op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.199µs 46.297µs ± 0.057µs 46.298µs ± 0.042µs 46.334µs 46.397µs 46.451µs 46.473µs 0.38% 0.522 -0.071 0.12% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21517714.519op/s 21599577.036op/s ± 26466.063op/s 21599155.352op/s ± 19685.468op/s 21621600.612op/s 21637768.272op/s 21643081.360op/s 21645679.680op/s 0.22% -0.516 -0.083 0.12% 1871.433op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [496.092µs; 496.265µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2015059.240op/s; 2015755.848op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [377.900µs; 378.014µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2645405.243op/s; 2646208.088op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [169.046µs; 169.177µs] or [-0.039%; +0.039%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5911057.908op/s; 5915523.937op/s] or [-0.038%; +0.038%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.023µs; 37.055µs] or [-0.043%; +0.043%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26986985.571op/s; 27010318.141op/s] or [-0.043%; +0.043%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.289µs; 46.305µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21595909.094op/s; 21603244.978op/s] or [-0.017%; +0.017%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 733.044µs 733.936µs ± 0.412µs 733.907µs ± 0.267µs 734.201µs 734.585µs 734.895µs 736.258µs 0.32% 1.091 4.183 0.06% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [733.879µs; 733.993µs] or [-0.008%; +0.008%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.977µs 5.061µs ± 0.040µs 5.069µs ± 0.035µs 5.097µs 5.109µs 5.110µs 5.114µs 0.88% -0.467 -1.181 0.80% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.055µs; 5.066µs] or [-0.110%; +0.110%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.660µs 161.416µs ± 0.385µs 161.361µs ± 0.132µs 161.505µs 161.849µs 162.645µs 164.864µs 2.17% 4.649 35.183 0.24% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.363µs; 161.469µs] or [-0.033%; +0.033%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 190.353ns 192.287ns ± 1.599ns 192.385ns ± 1.156ns 193.177ns 195.038ns 197.263ns 200.384ns 4.16% 1.256 3.029 0.83% 0.113ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [192.066ns; 192.509ns] or [-0.115%; +0.115%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.978µs 25.875µs ± 9.484µs 18.300µs ± 0.250µs 34.429µs 42.812µs 44.810µs 61.895µs 238.23% 0.784 -0.392 36.56% 0.671µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.561µs; 27.190µs] or [-5.080%; +5.080%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 12.993ms 13.019ms ± 0.013ms 13.018ms ± 0.008ms 13.027ms 13.040ms 13.055ms 13.067ms 0.37% 0.561 0.696 0.10% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [13.017ms; 13.021ms] or [-0.013%; +0.013%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.916µs 3.918µs 3.922µs 0.24% -1.787 13.755 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254965006.926op/s 255583506.928op/s ± 180688.150op/s 255572825.477op/s ± 94052.309op/s 255670679.356op/s 255847430.582op/s 255909582.007op/s 256917904.222op/s 0.53% 1.814 13.967 0.07% 12776.582op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 80.313µs 80.788µs ± 0.249µs 80.762µs ± 0.169µs 80.951µs 81.231µs 81.400µs 81.758µs 1.23% 0.596 0.417 0.31% 0.018µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12231231.028op/s 12378254.946op/s ± 38098.593op/s 12382104.764op/s ± 25927.752op/s 12404598.707op/s 12434985.210op/s 12442548.242op/s 12451295.602op/s 0.56% -0.577 0.369 0.31% 2693.977op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 73.084µs 73.634µs ± 0.312µs 73.575µs ± 0.183µs 73.801µs 74.240µs 74.596µs 74.717µs 1.55% 0.944 0.874 0.42% 0.022µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13383912.714op/s 13580864.921op/s ± 57397.519op/s 13591603.788op/s ± 33752.894op/s 13622314.714op/s 13657233.273op/s 13672091.033op/s 13682864.798op/s 0.67% -0.919 0.810 0.42% 4058.617op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.889µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.914µs 3.917µs 3.920µs 3.921µs 0.22% -2.127 18.493 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255007973.489op/s 255571373.912op/s ± 194397.849op/s 255576435.853op/s ± 99015.134op/s 255668768.508op/s 255816963.484op/s 255888399.281op/s 257115567.714op/s 0.60% 2.164 18.819 0.08% 13746.004op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 70.077µs 70.689µs ± 0.320µs 70.631µs ± 0.195µs 70.851µs 71.214µs 71.631µs 71.972µs 1.90% 0.906 1.235 0.45% 0.023µs 1 200
credit_card/is_card_number/378282246310005 throughput 13894366.999op/s 14146732.251op/s ± 63731.459op/s 14158004.055op/s ± 39105.414op/s 14191842.536op/s 14237089.398op/s 14257332.819op/s 14270076.063op/s 0.79% -0.874 1.140 0.45% 4506.495op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 53.054µs 53.124µs ± 0.033µs 53.121µs ± 0.021µs 53.142µs 53.175µs 53.220µs 53.237µs 0.22% 0.416 0.602 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18783876.199op/s 18824039.026op/s ± 11577.718op/s 18824944.007op/s ± 7349.078op/s 18832016.890op/s 18842766.417op/s 18847508.427op/s 18848592.349op/s 0.13% -0.411 0.595 0.06% 818.668op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.428µs 6.439µs ± 0.005µs 6.438µs ± 0.003µs 6.441µs 6.448µs 6.453µs 6.471µs 0.51% 1.666 6.915 0.08% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 154532606.529op/s 155307867.060op/s ± 124732.249op/s 155325954.969op/s ± 67459.783op/s 155389508.244op/s 155460726.183op/s 155501759.570op/s 155573841.075op/s 0.16% -1.651 6.811 0.08% 8819.902op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.889µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.917µs 3.921µs 3.921µs 0.23% -2.186 20.957 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255014817.498op/s 255579420.815op/s ± 193047.276op/s 255590057.547op/s ± 91050.273op/s 255671818.217op/s 255813715.735op/s 255896920.536op/s 257153050.131op/s 0.61% 2.227 21.322 0.08% 13650.504op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.896µs 65.131µs ± 0.135µs 65.096µs ± 0.074µs 65.206µs 65.392µs 65.561µs 65.760µs 1.02% 1.444 2.842 0.21% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15206925.273op/s 15353760.753op/s ± 31798.920op/s 15361826.629op/s ± 17452.103op/s 15374633.394op/s 15392222.310op/s 15398995.124op/s 15409219.336op/s 0.31% -1.426 2.765 0.21% 2248.523op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.162µs 58.389µs ± 0.139µs 58.351µs ± 0.082µs 58.459µs 58.652µs 58.767µs 59.128µs 1.33% 1.463 3.701 0.24% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16912374.627op/s 17126667.954op/s ± 40657.596op/s 17137749.701op/s ± 24030.158op/s 17154997.340op/s 17174823.083op/s 17181521.937op/s 17193457.889op/s 0.33% -1.438 3.556 0.24% 2874.926op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.900µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.920µs 3.922µs 0.23% -0.050 2.646 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254993879.548op/s 255561780.405op/s ± 174171.480op/s 255585687.203op/s ± 97717.974op/s 255665814.775op/s 255792280.367op/s 255902340.022op/s 256420108.433op/s 0.33% 0.059 2.674 0.07% 12315.783op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.944µs 55.316µs ± 0.156µs 55.300µs ± 0.114µs 55.419µs 55.581µs 55.669µs 55.833µs 0.96% 0.402 0.087 0.28% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17910698.248op/s 18078046.150op/s ± 50835.707op/s 18083056.231op/s ± 37424.516op/s 18115755.727op/s 18153514.753op/s 18182383.927op/s 18200256.111op/s 0.65% -0.386 0.066 0.28% 3594.627op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 53.037µs 53.125µs ± 0.032µs 53.122µs ± 0.020µs 53.145µs 53.176µs 53.209µs 53.286µs 0.31% 0.829 2.783 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 18766541.738op/s 18823594.122op/s ± 11440.167op/s 18824672.133op/s ± 7182.048op/s 18831278.545op/s 18839573.105op/s 18847914.787op/s 18854673.365op/s 0.16% -0.821 2.753 0.06% 808.942op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.430µs 6.439µs ± 0.005µs 6.438µs ± 0.003µs 6.441µs 6.449µs 6.453µs 6.457µs 0.30% 0.974 0.797 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 154871130.864op/s 155309744.554op/s ± 121234.784op/s 155329279.570op/s ± 73452.400op/s 155396283.537op/s 155459187.104op/s 155505105.954op/s 155519391.205op/s 0.12% -0.970 0.786 0.08% 8572.594op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255558465.288op/s; 255608548.568op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [80.753µs; 80.822µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12372974.847op/s; 12383535.044op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [73.591µs; 73.678µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13572910.177op/s; 13588819.665op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255544432.240op/s; 255598315.584op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [70.645µs; 70.733µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/378282246310005 throughput [14137899.683op/s; 14155564.818op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [53.119µs; 53.128µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [18822434.466op/s; 18825643.586op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.438µs; 6.440µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/x371413321323331 throughput [155290580.370op/s; 155325153.750op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255552666.319op/s; 255606175.311op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.112µs; 65.150µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15349353.728op/s; 15358167.777op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.370µs; 58.408µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17121033.203op/s; 17132302.706op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255537641.913op/s; 255585918.897op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.295µs; 55.338µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18071000.810op/s; 18085091.490op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [53.120µs; 53.129µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [18822008.625op/s; 18825179.619op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.438µs; 6.439µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155292942.579op/s; 155326546.529op/s] or [-0.011%; +0.011%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 49.264ms 49.595ms ± 1.015ms 49.436ms ± 0.076ms 49.538ms 49.729ms 56.947ms 58.163ms 17.65% 7.778 60.010 2.04% 0.072ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [49.454ms; 49.735ms] or [-0.284%; +0.284%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 238.410ns 249.954ns ± 14.855ns 242.601ns ± 2.705ns 251.742ns 283.994ns 286.032ns 290.026ns 19.55% 1.439 0.479 5.93% 1.050ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [247.895ns; 252.013ns] or [-0.824%; +0.824%] None None None

Group 20

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6c38c13 1774013499 julio/compiler-flags
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 186.048µs 186.395µs ± 0.165µs 186.387µs ± 0.120µs 186.507µs 186.686µs 186.771µs 186.875µs 0.26% 0.407 -0.333 0.09% 0.012µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5351179.875op/s 5364960.688op/s ± 4746.433op/s 5365171.333op/s ± 3466.881op/s 5368628.126op/s 5371639.137op/s 5373213.669op/s 5374971.445op/s 0.18% -0.403 -0.339 0.09% 335.623op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.891µs 17.982µs ± 0.032µs 17.983µs ± 0.019µs 18.000µs 18.029µs 18.069µs 18.072µs 0.50% 0.020 0.523 0.18% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55334398.792op/s 55611396.682op/s ± 97788.006op/s 55608632.997op/s ± 58676.271op/s 55667664.049op/s 55764692.683op/s 55854319.371op/s 55894865.047op/s 0.51% -0.007 0.519 0.18% 6914.656op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.570µs 10.724µs ± 0.053µs 10.724µs ± 0.037µs 10.763µs 10.811µs 10.844µs 10.848µs 1.15% 0.033 -0.400 0.49% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 92183085.459op/s 93246855.259op/s ± 458229.326op/s 93247028.925op/s ± 325796.193op/s 93565664.462op/s 93954157.576op/s 94199334.126op/s 94603416.700op/s 1.45% -0.009 -0.392 0.49% 32401.706op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [186.372µs; 186.418µs] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5364302.878op/s; 5365618.498op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.978µs; 17.986µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55597844.204op/s; 55624949.159op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.717µs; 10.732µs] or [-0.068%; +0.068%] None None None
normalization/normalize_name/normalize_name/good throughput [93183349.082op/s; 93310361.437op/s] or [-0.068%; +0.068%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Mar 19, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 100.37 MB 100.37 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.70 MB 8.70 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.28 MB 11.28 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 117.04 MB 117.04 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.18 MB 27.18 MB -0% (-1.50 KB) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 77.17 KB 77.17 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.10 MB 186.48 MB +.20% (+384.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.17 MB 917.69 MB +.05% (+533.76 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.94 MB 9.94 MB --.01% (-1.50 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 77.17 KB 77.17 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.78 MB 24.78 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.46 MB 51.46 MB -0% (-1.68 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.97 MB 22.97 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 78.37 KB 78.37 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.26 MB 190.23 MB --.01% (-24.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 900.83 MB 900.83 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.54 MB 7.54 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 78.37 KB 78.37 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.52 MB 26.52 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.09 MB 47.09 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 87.58 MB 87.58 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.22 MB 10.22 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 109.91 MB 109.91 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.97 MB 11.97 MB 0% (0 B) 👌

danielsn
danielsn approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@danielsn danielsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@hoolioh hoolioh force-pushed the julio/compiler-flags branch from 948c087 to ffcf195 Compare March 20, 2026 10:34
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 bot commented Mar 20, 2026 •
edited by datadog-prod-us1-6 bot
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.33% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6c38c13 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@hoolioh hoolioh force-pushed the julio/compiler-flags branch from ffcf195 to 6c38c13 Compare March 20, 2026 13:31
@hoolioh
Copy link
Copy Markdown
Contributor Author

hoolioh commented Mar 20, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 20, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-20 14:06:33 UTC ℹ️ Start processing command /merge

2026-03-20 14:06:40 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-03-20 14:11:24 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-03-20 14:52:30 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 3a4bda7 into main Mar 20, 2026
105 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the julio/compiler-flags branch March 20, 2026 14:52
bwoebi added a commit that referenced this pull request Mar 20, 2026
@bwoebi
Merge branch 'main' of github.com:DataDog/libdatadog into bob/prevent…
d75b301 
…-unprocessed

* 'main' of github.com:DataDog/libdatadog:
  chore(build): ekump/APMSP-2718 update aws-lc dependencies (#1751)
  chore(crashtracking): add integration test for errno preservation (#1768)
  chore(crashtracking): preserve errno for crashtracker (#1767)
  chore(examples): add compilation flags to prevent logic errors (#1766)
  feat(agents)!: retrieve container tags hash from /info endpoint (#1700)
  fix(ci): handle new crate addition in semver-check (#1769)
  fix(obfuscation/redis): fuzzer fixes [APMSP-2670] (#1694)
  fix(obfuscation/http)!: fuzzer fixes [APMSP-2670] (#1684)
  ci: add Datadog code coverage upload (#1718)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielsn danielsn danielsn approved these changes

@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoolioh @codecov-commenter @danielsn @gleocadie