refactor(libdd-crashtracker)!: avoid leaking Endpoint through the public API by hoolioh · Pull Request #1705 · DataDog/libdatadog

hoolioh · 2026-03-11T10:04:26Z

What does this PR do?

In order to avoid leaking libdd-common types to consumers this PR changes:

Introduce builder pattern for CrashtrackerConfiguration: Replace the positional new() constructor with CrashtrackerConfigurationBuilder.
The endpoint() getter is now pub(crate), and the builder accepts endpoint configuration as primitive types (&str, u64, bool) rather than libdd_common::Endpoint. The builder constructs the internal Endpoint type itself, so consumers of libdd-crashtracker no onger need to depend on libdd-common just to configure a crash report endpoint.
Update all callers: libdd-crashtracker-ffi, datadog-sidecar, and internal tests are updated to use the new builder API. The FFI layer's Config.endpoint field is changed from Option<&Endpoint> to a CharSlice (URL string), consistent with C FFI conventions. The sidecar passes all endpoint fields individually through the builder to avoid data loss from the JSON-deserialized crashtracker_endpoint config (which may include api_key, timeout_ms, test_token, and use_system_resolver).

Motivation

CrashtrackerConfiguration previously required consumers to import libdd-common directly in order to construct an Endpoint value for the crash report destination. This created an undesirable transitive dependency: any downstream project that wanted to use libdd-crashtracker had to explicitly add libdd-common to its Cargo.toml. This risks version conflicts if the consumer and libdd-crashtracker end up pulling in different versions of libdd-common.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

github-actions · 2026-03-11T10:06:59Z

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

Base Branch: origin/main
PR Branch: origin/julio/remove-common-as-external-dependency

Summary by Rule

Rule	Base Branch	PR Branch	Change
unwrap_used	4	4	No change (0%)
Total	4	4	No change (0%)

Annotation Counts by File

File	Base Branch	PR Branch	Change
`datadog-sidecar/src/unix.rs`	4	4	No change (0%)

Annotation Stats by Crate

Crate	Base Branch	PR Branch	Change
`clippy-annotation-reporter`	5	5	No change (0%)
`datadog-ffe-ffi`	1	1	No change (0%)
`datadog-ipc`	28	28	No change (0%)
`datadog-live-debugger`	6	6	No change (0%)
`datadog-live-debugger-ffi`	10	10	No change (0%)
`datadog-profiling-replayer`	4	4	No change (0%)
`datadog-remote-config`	3	3	No change (0%)
`datadog-sidecar`	59	59	No change (0%)
`libdd-common`	10	10	No change (0%)
`libdd-common-ffi`	12	12	No change (0%)
`libdd-data-pipeline`	5	5	No change (0%)
`libdd-ddsketch`	2	2	No change (0%)
`libdd-dogstatsd-client`	1	1	No change (0%)
`libdd-profiling`	13	13	No change (0%)
`libdd-telemetry`	19	19	No change (0%)
`libdd-tinybytes`	4	4	No change (0%)
`libdd-trace-normalization`	2	2	No change (0%)
`libdd-trace-obfuscation`	9	9	No change (0%)
`libdd-trace-utils`	15	15	No change (0%)
Total	208	208	No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

pr-commenter · 2026-03-11T10:22:07Z

Benchmarks

Comparison

Benchmark execution time: 2026-03-13 11:32:00

Comparing candidate commit f1e7d11 in PR branch julio/remove-common-as-external-dependency with baseline commit 0e8c2c6 in branch main.

Found 4 performance improvements and 16 performance regressions! Performance is the same for 38 metrics, 2 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:benching serializing traces from their internal representation to msgpack

🟩 execution_time [-662.701µs; -650.613µs] or [-4.505%; -4.423%]

scenario:concentrator/add_spans_to_concentrator

🟩 execution_time [-2.353ms; -2.347ms] or [-18.020%; -17.975%]

scenario:credit_card/is_card_number/ 378282246310005

🟥 execution_time [+4.957µs; +5.040µs] or [+7.300%; +7.422%]
🟥 throughput [-1017243.294op/s; -1001579.125op/s] or [-6.908%; -6.802%]

scenario:credit_card/is_card_number/378282246310005

🟥 execution_time [+4.925µs; +5.018µs] or [+7.612%; +7.755%]
🟥 throughput [-1111928.327op/s; -1092816.331op/s] or [-7.195%; -7.071%]

scenario:credit_card/is_card_number/37828224631000521389798

🟥 execution_time [+6.493µs; +6.524µs] or [+14.208%; +14.276%]
🟥 throughput [-2735383.072op/s; -2720652.050op/s] or [-12.501%; -12.433%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

🟥 execution_time [+4.954µs; +4.997µs] or [+9.271%; +9.352%]
🟥 throughput [-1600387.187op/s; -1587585.252op/s] or [-8.552%; -8.483%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

🟥 execution_time [+4.760µs; +4.846µs] or [+9.480%; +9.651%]
🟥 throughput [-1752282.993op/s; -1723892.796op/s] or [-8.799%; -8.656%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

🟥 execution_time [+6.480µs; +6.509µs] or [+14.172%; +14.234%]
🟥 throughput [-2726204.705op/s; -2713254.855op/s] or [-12.466%; -12.407%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

🟩 execution_time [-20.414µs; -20.262µs] or [-9.909%; -9.835%]
🟩 throughput [+529792.069op/s; +533518.333op/s] or [+10.914%; +10.991%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

🟥 execution_time [+40.707µs; +41.069µs] or [+8.239%; +8.313%]
🟥 throughput [-155363.474op/s; -154054.417op/s] or [-7.676%; -7.611%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

🟥 execution_time [+22.483µs; +22.539µs] or [+13.414%; +13.447%]
🟥 throughput [-707273.936op/s; -705555.427op/s] or [-11.855%; -11.826%]

Candidate

Candidate benchmark details

Group 1

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
profile_add_sample2_frames_x1000	execution_time	737.191µs	738.783µs ± 0.688µs	738.739µs ± 0.303µs	739.031µs	739.774µs	741.596µs	742.159µs	0.46%	1.640	6.141	0.09%	0.049µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
profile_add_sample2_frames_x1000	execution_time	[738.688µs; 738.879µs] or [-0.013%; +0.013%]	None	None	None

Group 2

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
two way interface	execution_time	17.644µs	25.041µs ± 8.926µs	17.892µs ± 0.167µs	32.445µs	40.426µs	41.234µs	63.098µs	252.67%	1.020	1.165	35.56%	0.631µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
two way interface	execution_time	[23.804µs; 26.278µs] or [-4.940%; +4.940%]	None	None	None

Group 3

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching deserializing traces from msgpack to their internal representation	execution_time	49.128ms	49.409ms ± 0.778ms	49.271ms ± 0.041ms	49.323ms	49.694ms	53.199ms	57.466ms	16.63%	7.887	68.814	1.57%	0.055ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching deserializing traces from msgpack to their internal representation	execution_time	[49.301ms; 49.517ms] or [-0.218%; +0.218%]	None	None	None

Group 4

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
tags/replace_trace_tags	execution_time	2.317µs	2.393µs ± 0.021µs	2.396µs ± 0.004µs	2.399µs	2.421µs	2.431µs	2.435µs	1.66%	-1.861	4.700	0.87%	0.001µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
tags/replace_trace_tags	execution_time	[2.390µs; 2.396µs] or [-0.121%; +0.121%]	None	None	None

Group 5

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
write only interface	execution_time	1.238µs	3.301µs ± 1.443µs	3.083µs ± 0.031µs	3.107µs	3.738µs	14.186µs	14.942µs	384.72%	7.272	54.369	43.60%	0.102µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
write only interface	execution_time	[3.101µs; 3.501µs] or [-6.058%; +6.058%]	None	None	None

Group 6

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	533.939µs	534.934µs ± 1.121µs	534.730µs ± 0.282µs	535.084µs	536.096µs	537.469µs	548.202µs	2.52%	8.587	96.614	0.21%	0.079µs	1	200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	1824146.485op/s	1869398.637op/s ± 3850.040op/s	1870103.800op/s ± 986.653op/s	1871001.543op/s	1872024.929op/s	1872324.765op/s	1872872.087op/s	0.15%	-8.432	94.036	0.21%	272.239op/s	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	380.284µs	380.945µs ± 0.292µs	380.914µs ± 0.175µs	381.103µs	381.459µs	381.838µs	381.978µs	0.28%	0.610	0.900	0.08%	0.021µs	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	2617953.309op/s	2625051.128op/s ± 2011.838op/s	2625262.548op/s ± 1202.253op/s	2626237.379op/s	2628056.450op/s	2629062.842op/s	2629614.258op/s	0.17%	-0.604	0.888	0.08%	142.258op/s	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	189.718µs	190.120µs ± 0.162µs	190.102µs ± 0.095µs	190.205µs	190.387µs	190.599µs	190.663µs	0.30%	0.590	0.754	0.09%	0.011µs	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	5244846.938op/s	5259830.134op/s ± 4491.403op/s	5260323.638op/s ± 2617.397op/s	5262548.725op/s	5266003.989op/s	5268723.779op/s	5270970.455op/s	0.20%	-0.584	0.744	0.09%	317.590op/s	1	200
normalization/normalize_service/normalize_service/[empty string]	execution_time	37.351µs	37.525µs ± 0.062µs	37.521µs ± 0.044µs	37.569µs	37.631µs	37.664µs	37.694µs	0.46%	0.074	-0.073	0.17%	0.004µs	1	200
normalization/normalize_service/normalize_service/[empty string]	throughput	26529680.870op/s	26648666.887op/s ± 44253.075op/s	26651642.333op/s ± 31458.965op/s	26680773.597op/s	26713375.428op/s	26757055.875op/s	26773390.501op/s	0.46%	-0.064	-0.071	0.17%	3129.165op/s	1	200
normalization/normalize_service/normalize_service/test_ASCII	execution_time	45.711µs	45.881µs ± 0.080µs	45.890µs ± 0.047µs	45.927µs	46.003µs	46.045µs	46.320µs	0.94%	0.650	3.485	0.17%	0.006µs	1	200
normalization/normalize_service/normalize_service/test_ASCII	throughput	21588863.601op/s	21795452.531op/s ± 37778.806op/s	21791390.294op/s ± 22268.043op/s	21819837.482op/s	21855733.414op/s	21872036.822op/s	21876396.899op/s	0.39%	-0.624	3.347	0.17%	2671.365op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	[534.778µs; 535.089µs] or [-0.029%; +0.029%]	None	None	None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	[1868865.059op/s; 1869932.216op/s] or [-0.029%; +0.029%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	[380.905µs; 380.986µs] or [-0.011%; +0.011%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	[2624772.307op/s; 2625329.949op/s] or [-0.011%; +0.011%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	[190.098µs; 190.143µs] or [-0.012%; +0.012%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	[5259207.669op/s; 5260452.600op/s] or [-0.012%; +0.012%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	execution_time	[37.517µs; 37.534µs] or [-0.023%; +0.023%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	throughput	[26642533.837op/s; 26654799.938op/s] or [-0.023%; +0.023%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	execution_time	[45.870µs; 45.892µs] or [-0.024%; +0.024%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	throughput	[21790216.752op/s; 21800688.310op/s] or [-0.024%; +0.024%]	None	None	None

Group 7

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
credit_card/is_card_number/	execution_time	3.896µs	3.913µs ± 0.003µs	3.913µs ± 0.002µs	3.914µs	3.919µs	3.922µs	3.924µs	0.27%	-0.195	5.706	0.08%	0.000µs	1	200
credit_card/is_card_number/	throughput	254863080.616op/s	255551821.931op/s ± 193262.237op/s	255557360.660op/s ± 111166.544op/s	255684038.928op/s	255790479.487op/s	255872531.542op/s	256669955.763op/s	0.44%	0.212	5.776	0.08%	13665.704op/s	1	200
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	78.995µs	79.702µs ± 0.400µs	79.665µs ± 0.291µs	79.966µs	80.415µs	80.619µs	81.350µs	2.12%	0.679	0.660	0.50%	0.028µs	1	200
credit_card/is_card_number/ 3782-8224-6310-005	throughput	12292551.007op/s	12547104.603op/s ± 62799.295op/s	12552567.077op/s ± 45622.495op/s	12596603.326op/s	12636621.055op/s	12654505.731op/s	12658983.267op/s	0.85%	-0.646	0.560	0.50%	4440.581op/s	1	200
credit_card/is_card_number/ 378282246310005	execution_time	72.359µs	72.909µs ± 0.292µs	72.861µs ± 0.197µs	73.078µs	73.486µs	73.717µs	73.825µs	1.32%	0.781	0.320	0.40%	0.021µs	1	200
credit_card/is_card_number/ 378282246310005	throughput	13545637.973op/s	13715950.688op/s ± 54808.406op/s	13724679.036op/s ± 37057.806op/s	13759762.785op/s	13788953.574op/s	13802148.653op/s	13819908.436op/s	0.69%	-0.761	0.276	0.40%	3875.540op/s	1	200
credit_card/is_card_number/37828224631	execution_time	3.894µs	3.912µs ± 0.003µs	3.911µs ± 0.001µs	3.913µs	3.917µs	3.920µs	3.928µs	0.41%	0.143	9.080	0.08%	0.000µs	1	200
credit_card/is_card_number/37828224631	throughput	254604775.393op/s	255632111.878op/s ± 197023.976op/s	255656436.158op/s ± 85961.209op/s	255737036.696op/s	255883045.053op/s	255924789.037op/s	256810914.826op/s	0.45%	-0.118	9.133	0.08%	13931.699op/s	1	200
credit_card/is_card_number/378282246310005	execution_time	69.153µs	69.678µs ± 0.327µs	69.628µs ± 0.231µs	69.896µs	70.272µs	70.490µs	70.624µs	1.43%	0.616	-0.271	0.47%	0.023µs	1	200
credit_card/is_card_number/378282246310005	throughput	14159410.379op/s	14352023.012op/s ± 67236.467op/s	14362074.071op/s ± 47573.863op/s	14408247.282op/s	14440795.684op/s	14449607.199op/s	14460758.322op/s	0.69%	-0.597	-0.307	0.47%	4754.336op/s	1	200
credit_card/is_card_number/37828224631000521389798	execution_time	52.147µs	52.208µs ± 0.034µs	52.200µs ± 0.019µs	52.230µs	52.263µs	52.311µs	52.384µs	0.35%	1.364	3.564	0.06%	0.002µs	1	200
credit_card/is_card_number/37828224631000521389798	throughput	19089648.469op/s	19154113.664op/s ± 12399.020op/s	19157032.693op/s ± 6981.459op/s	19162402.886op/s	19169506.398op/s	19173050.917op/s	19176667.748op/s	0.10%	-1.356	3.525	0.06%	876.743op/s	1	200
credit_card/is_card_number/x371413321323331	execution_time	6.797µs	6.805µs ± 0.004µs	6.805µs ± 0.003µs	6.808µs	6.814µs	6.816µs	6.817µs	0.18%	0.702	0.119	0.06%	0.000µs	1	200
credit_card/is_card_number/x371413321323331	throughput	146695918.341op/s	146941871.003op/s ± 88934.458op/s	146961243.104op/s ± 58032.070op/s	147004010.084op/s	147062459.165op/s	147100496.686op/s	147127447.773op/s	0.11%	-0.699	0.114	0.06%	6288.616op/s	1	200
credit_card/is_card_number_no_luhn/	execution_time	3.897µs	3.912µs ± 0.003µs	3.911µs ± 0.002µs	3.914µs	3.916µs	3.920µs	3.928µs	0.44%	0.840	7.962	0.07%	0.000µs	1	200
credit_card/is_card_number_no_luhn/	throughput	254567682.946op/s	255641339.366op/s ± 186659.930op/s	255681910.505op/s ± 100246.726op/s	255756579.750op/s	255836638.513op/s	255929123.619op/s	256594436.888op/s	0.36%	-0.820	7.935	0.07%	13198.850op/s	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	64.100µs	64.431µs ± 0.165µs	64.409µs ± 0.110µs	64.533µs	64.756µs	64.866µs	64.960µs	0.86%	0.692	0.219	0.26%	0.012µs	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	15393985.373op/s	15520551.768op/s ± 39652.912op/s	15525815.334op/s ± 26530.733op/s	15550867.038op/s	15573489.952op/s	15589579.598op/s	15600585.022op/s	0.48%	-0.679	0.193	0.25%	2803.884op/s	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	58.117µs	58.412µs ± 0.152µs	58.382µs ± 0.069µs	58.458µs	58.723µs	58.916µs	58.999µs	1.06%	1.442	2.590	0.26%	0.011µs	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	16949297.851op/s	17119859.487op/s ± 44454.286op/s	17128610.526op/s ± 20213.957op/s	17146448.644op/s	17174209.576op/s	17185469.113op/s	17206689.961op/s	0.46%	-1.422	2.524	0.26%	3143.393op/s	1	200
credit_card/is_card_number_no_luhn/37828224631	execution_time	3.893µs	3.912µs ± 0.003µs	3.912µs ± 0.001µs	3.913µs	3.915µs	3.918µs	3.926µs	0.38%	-0.856	16.623	0.07%	0.000µs	1	200
credit_card/is_card_number_no_luhn/37828224631	throughput	254696470.437op/s	255643337.227op/s ± 170173.969op/s	255653586.092op/s ± 94046.905op/s	255736199.459op/s	255837837.757op/s	255942462.492op/s	256874584.726op/s	0.48%	0.892	16.764	0.07%	12033.117op/s	1	200
credit_card/is_card_number_no_luhn/378282246310005	execution_time	54.578µs	55.017µs ± 0.309µs	54.976µs ± 0.234µs	55.213µs	55.528µs	55.970µs	56.097µs	2.04%	0.834	0.552	0.56%	0.022µs	1	200
credit_card/is_card_number_no_luhn/378282246310005	throughput	17826256.489op/s	18176774.698op/s ± 101704.606op/s	18189767.478op/s ± 77383.224op/s	18265407.632op/s	18305585.519op/s	18313115.444op/s	18322277.383op/s	0.73%	-0.803	0.461	0.56%	7191.602op/s	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	52.150µs	52.222µs ± 0.046µs	52.211µs ± 0.023µs	52.240µs	52.301µs	52.401µs	52.446µs	0.45%	1.672	4.511	0.09%	0.003µs	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	19067219.695op/s	19148898.970op/s ± 16728.206op/s	19153100.761op/s ± 8358.231op/s	19159329.055op/s	19168878.655op/s	19174547.418op/s	19175629.692op/s	0.12%	-1.662	4.461	0.09%	1182.863op/s	1	200
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	6.796µs	6.805µs ± 0.005µs	6.805µs ± 0.002µs	6.808µs	6.815µs	6.821µs	6.825µs	0.30%	1.166	1.966	0.07%	0.000µs	1	200
credit_card/is_card_number_no_luhn/x371413321323331	throughput	146513981.500op/s	146940175.296op/s ± 102479.048op/s	146957280.169op/s ± 53644.937op/s	147006541.526op/s	147072674.036op/s	147107548.954op/s	147142237.971op/s	0.13%	-1.161	1.948	0.07%	7246.363op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
credit_card/is_card_number/	execution_time	[3.913µs; 3.914µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number/	throughput	[255525037.644op/s; 255578606.219op/s] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	[79.646µs; 79.757µs] or [-0.070%; +0.070%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	throughput	[12538401.224op/s; 12555807.981op/s] or [-0.069%; +0.069%]	None	None	None
credit_card/is_card_number/ 378282246310005	execution_time	[72.868µs; 72.949µs] or [-0.056%; +0.056%]	None	None	None
credit_card/is_card_number/ 378282246310005	throughput	[13708354.771op/s; 13723546.606op/s] or [-0.055%; +0.055%]	None	None	None
credit_card/is_card_number/37828224631	execution_time	[3.911µs; 3.912µs] or [-0.011%; +0.011%]	None	None	None
credit_card/is_card_number/37828224631	throughput	[255604806.249op/s; 255659417.506op/s] or [-0.011%; +0.011%]	None	None	None
credit_card/is_card_number/378282246310005	execution_time	[69.633µs; 69.723µs] or [-0.065%; +0.065%]	None	None	None
credit_card/is_card_number/378282246310005	throughput	[14342704.684op/s; 14361341.339op/s] or [-0.065%; +0.065%]	None	None	None
credit_card/is_card_number/37828224631000521389798	execution_time	[52.203µs; 52.213µs] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number/37828224631000521389798	throughput	[19152395.279op/s; 19155832.049op/s] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number/x371413321323331	execution_time	[6.805µs; 6.806µs] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number/x371413321323331	throughput	[146929545.542op/s; 146954196.463op/s] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number_no_luhn/	execution_time	[3.911µs; 3.912µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/	throughput	[255615470.095op/s; 255667208.637op/s] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	[64.408µs; 64.454µs] or [-0.035%; +0.035%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	[15515056.256op/s; 15526047.280op/s] or [-0.035%; +0.035%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	[58.391µs; 58.433µs] or [-0.036%; +0.036%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	[17113698.551op/s; 17126020.424op/s] or [-0.036%; +0.036%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	execution_time	[3.911µs; 3.912µs] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	throughput	[255619752.752op/s; 255666921.703op/s] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	execution_time	[54.974µs; 55.060µs] or [-0.078%; +0.078%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	throughput	[18162679.418op/s; 18190869.979op/s] or [-0.078%; +0.078%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	[52.216µs; 52.229µs] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	[19146580.602op/s; 19151217.338op/s] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	[6.805µs; 6.806µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	throughput	[146925972.685op/s; 146954377.906op/s] or [-0.010%; +0.010%]	None	None	None

Group 8

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
redis/obfuscate_redis_string	execution_time	32.649µs	33.412µs ± 1.008µs	32.801µs ± 0.081µs	34.671µs	35.333µs	35.693µs	36.110µs	10.09%	1.025	-0.669	3.01%	0.071µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
redis/obfuscate_redis_string	execution_time	[33.273µs; 33.552µs] or [-0.418%; +0.418%]	None	None	None

Group 9

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching serializing traces from their internal representation to msgpack	execution_time	13.999ms	14.055ms ± 0.031ms	14.051ms ± 0.012ms	14.063ms	14.107ms	14.169ms	14.222ms	1.22%	2.252	8.634	0.22%	0.002ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching serializing traces from their internal representation to msgpack	execution_time	[14.050ms; 14.059ms] or [-0.031%; +0.031%]	None	None	None

Group 10

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_trace/test_trace	execution_time	240.843ns	248.802ns ± 11.705ns	244.210ns ± 1.440ns	247.021ns	284.347ns	287.572ns	290.885ns	19.11%	2.429	4.693	4.69%	0.828ns	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_trace/test_trace	execution_time	[247.180ns; 250.425ns] or [-0.652%; +0.652%]	None	None	None

Group 11

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	185.263µs	185.678µs ± 0.216µs	185.650µs ± 0.152µs	185.829µs	186.050µs	186.236µs	186.473µs	0.44%	0.595	0.065	0.12%	0.015µs	1	200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	5362693.724op/s	5385683.508op/s ± 6265.446op/s	5386479.935op/s ± 4405.775op/s	5390677.746op/s	5394085.298op/s	5395299.624op/s	5397729.688op/s	0.21%	-0.589	0.049	0.12%	443.034op/s	1	200
normalization/normalize_name/normalize_name/bad-name	execution_time	17.876µs	17.998µs ± 0.112µs	17.994µs ± 0.036µs	18.024µs	18.075µs	18.099µs	19.409µs	7.86%	10.069	124.852	0.62%	0.008µs	1	200
normalization/normalize_name/normalize_name/bad-name	throughput	51521820.357op/s	55564130.824op/s ± 325652.784op/s	55573820.718op/s ± 110820.780op/s	55700990.538op/s	55817656.330op/s	55922868.054op/s	55939979.692op/s	0.66%	-9.594	117.037	0.58%	23027.129op/s	1	200
normalization/normalize_name/normalize_name/good	execution_time	10.271µs	10.401µs ± 0.048µs	10.396µs ± 0.033µs	10.435µs	10.483µs	10.514µs	10.559µs	1.56%	0.308	0.118	0.46%	0.003µs	1	200
normalization/normalize_name/normalize_name/good	throughput	94709607.429op/s	96146077.880op/s ± 439114.149op/s	96190948.149op/s ± 301831.706op/s	96474796.332op/s	96758601.515op/s	97038815.730op/s	97362724.091op/s	1.22%	-0.280	0.089	0.46%	31050.059op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	[185.648µs; 185.708µs] or [-0.016%; +0.016%]	None	None	None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	[5384815.177op/s; 5386551.839op/s] or [-0.016%; +0.016%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	execution_time	[17.982µs; 18.013µs] or [-0.086%; +0.086%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	throughput	[55518998.480op/s; 55609263.168op/s] or [-0.081%; +0.081%]	None	None	None
normalization/normalize_name/normalize_name/good	execution_time	[10.394µs; 10.408µs] or [-0.063%; +0.063%]	None	None	None
normalization/normalize_name/normalize_name/good	throughput	[96085220.882op/s; 96206934.878op/s] or [-0.063%; +0.063%]	None	None	None

Group 12

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
profile_add_sample_frames_x1000	execution_time	4.185ms	4.193ms ± 0.011ms	4.191ms ± 0.002ms	4.193ms	4.204ms	4.227ms	4.305ms	2.74%	6.819	63.392	0.25%	0.001ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
profile_add_sample_frames_x1000	execution_time	[4.192ms; 4.195ms] or [-0.035%; +0.035%]	None	None	None

Group 13

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
single_flag_killswitch/rules-based	execution_time	187.840ns	190.287ns ± 2.112ns	190.101ns ± 1.368ns	191.050ns	194.078ns	197.536ns	202.836ns	6.70%	1.826	6.457	1.11%	0.149ns	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
single_flag_killswitch/rules-based	execution_time	[189.995ns; 190.580ns] or [-0.154%; +0.154%]	None	None	None

Group 14

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching string interning on wordpress profile	execution_time	161.169µs	161.957µs ± 0.323µs	161.909µs ± 0.121µs	162.034µs	162.434µs	163.399µs	164.190µs	1.41%	2.976	15.187	0.20%	0.023µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching string interning on wordpress profile	execution_time	[161.912µs; 162.002µs] or [-0.028%; +0.028%]	None	None	None

Group 15

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
concentrator/add_spans_to_concentrator	execution_time	10.678ms	10.708ms ± 0.015ms	10.705ms ± 0.008ms	10.714ms	10.737ms	10.746ms	10.774ms	0.64%	1.249	2.706	0.14%	0.001ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
concentrator/add_spans_to_concentrator	execution_time	[10.706ms; 10.710ms] or [-0.019%; +0.019%]	None	None	None

Group 16

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
sql/obfuscate_sql_string	execution_time	85.189µs	85.459µs ± 0.144µs	85.428µs ± 0.056µs	85.511µs	85.602µs	85.845µs	86.694µs	1.48%	4.966	36.487	0.17%	0.010µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
sql/obfuscate_sql_string	execution_time	[85.439µs; 85.479µs] or [-0.023%; +0.023%]	None	None	None

Group 17

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
ip_address/quantize_peer_ip_address_benchmark	execution_time	4.927µs	5.025µs ± 0.055µs	5.042µs ± 0.046µs	5.060µs	5.109µs	5.111µs	5.116µs	1.48%	-0.093	-1.180	1.08%	0.004µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark	execution_time	[5.018µs; 5.033µs] or [-0.151%; +0.151%]	None	None	None

Group 18

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
sdk_test_data/rules-based	execution_time	144.643µs	146.970µs ± 1.664µs	146.688µs ± 0.535µs	147.370µs	148.679µs	153.727µs	162.292µs	10.64%	5.107	38.930	1.13%	0.118µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
sdk_test_data/rules-based	execution_time	[146.740µs; 147.201µs] or [-0.157%; +0.157%]	None	None	None

Group 19

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`f1e7d11`	1773400476	julio/remove-common-as-external-dependency

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
receiver_entry_point/report/2598	execution_time	3.389ms	3.423ms ± 0.028ms	3.412ms ± 0.010ms	3.429ms	3.486ms	3.518ms	3.535ms	3.59%	1.696	2.440	0.83%	0.002ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
receiver_entry_point/report/2598	execution_time	[3.419ms; 3.427ms] or [-0.115%; +0.115%]	None	None	None

Baseline

Omitted due to size.

codecov-commenter · 2026-03-12T08:55:59Z

Codecov Report

❌ Patch coverage is 83.29238% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.46%. Comparing base (3f3efef) to head (f1e7d11).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   71.03%   71.46%   +0.43%     
==========================================
  Files         427      430       +3     
  Lines       62962    63954     +992     
==========================================
+ Hits        44722    45704     +982     
- Misses      18240    18250      +10

Components	Coverage Δ
libdd-crashtracker	`63.86% <91.86%> (+1.44%)`	⬆️
libdd-crashtracker-ffi	`17.72% <0.00%> (+0.23%)`	⬆️
libdd-alloc	`98.77% <ø> (ø)`
libdd-data-pipeline	`88.32% <ø> (+0.30%)`	⬆️
libdd-data-pipeline-ffi	`76.94% <ø> (+1.22%)`	⬆️
libdd-common	`79.73% <ø> (ø)`
libdd-common-ffi	`73.40% <ø> (ø)`
libdd-telemetry	`62.48% <ø> (ø)`
libdd-telemetry-ffi	`16.75% <ø> (ø)`
libdd-dogstatsd-client	`82.64% <ø> (ø)`
datadog-ipc	`80.47% <ø> (+0.11%)`	⬆️
libdd-profiling	`81.59% <ø> (-0.02%)`	⬇️
libdd-profiling-ffi	`63.65% <ø> (ø)`
datadog-sidecar	`32.59% <0.00%> (+0.11%)`	⬆️
datdog-sidecar-ffi	`8.50% <ø> (+0.76%)`	⬆️
spawn-worker	`54.69% <ø> (ø)`
libdd-tinybytes	`93.16% <ø> (ø)`
libdd-trace-normalization	`81.71% <ø> (ø)`
libdd-trace-obfuscation	`91.80% <ø> (-2.90%)`	⬇️
libdd-trace-protobuf	`68.25% <ø> (ø)`
libdd-trace-utils	`89.08% <ø> (ø)`
datadog-tracer-flare	`88.95% <ø> (ø)`
libdd-log	`74.69% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dd-octo-sts · 2026-03-12T09:22:18Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	8.63 MB	8.63 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	100.28 MB	100.30 MB	+.01% (+17.15 KB) 🔍

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	11.21 MB	11.22 MB	+0% (+736 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	116.94 MB	116.98 MB	+.03% (+40.21 KB) 🔍

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	27.16 MB	27.16 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	76.26 KB	76.26 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	186.03 MB	186.02 MB	-0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	917.14 MB	917.14 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	9.93 MB	9.93 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	76.26 KB	76.26 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	24.77 MB	24.77 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	51.43 MB	51.43 MB	0% (0 B) 👌

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	22.97 MB	22.97 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	77.44 KB	77.44 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	190.23 MB	190.21 MB	--.01% (-24.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	900.80 MB	900.80 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	7.53 MB	7.53 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	77.44 KB	77.44 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	26.51 MB	26.51 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	47.05 MB	47.05 MB	0% (0 B) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	87.50 MB	87.51 MB	+.01% (+16.27 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	10.21 MB	10.21 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	109.81 MB	109.86 MB	+.03% (+44.17 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	11.95 MB	11.95 MB	+0% (+624 B) 👌

danielsn · 2026-03-12T15:26:40Z

bin_tests/src/bin/crashing_test_app.rs

+            .resolve_frames(crashtracker::StacktraceCollection::EnabledWithSymbolsInReceiver)
+            .signals(crashtracker::default_signals())
+            .timeout(TEST_COLLECTOR_TIMEOUT)
+            .unix_socket_path("".to_string())


This is surprising

danielsn · 2026-03-12T15:27:33Z

bin_tests/src/bin/crashtracker_bin_test.rs

-            true,
-        )?;
+        let mut config = CrashtrackerConfiguration::builder()
+            .create_alt_stack(true)


I ❤️ how there are in alphabetical order

danielsn · 2026-03-12T17:03:59Z

libdd-crashtracker-ffi/src/collector/datatypes.rs

-            unix_socket_path,
-            demangle_names,
-        )
+        let mut builder = Self::builder()


in other places we sort these

danielsn · 2026-03-12T17:06:07Z

libdd-crashtracker/src/collector/api.rs

@@ -151,18 +152,16 @@ mod tests {
            stdout_filename,
        )
        .unwrap();
-        let config = CrashtrackerConfiguration::new(
-            vec![],
-            create_alt_stack,
-            use_alt_stack,
-            endpoint,
-            resolve_frames,
-            default_signals(),
-            Some(timeout),
-            None,
-            true,
-        )
-        .unwrap();
+        let config = CrashtrackerConfigurationBuilder::default()
+            .create_alt_stack(create_alt_stack)
+            .use_alt_stack(use_alt_stack)
+            .endpoint_url(endpoint_url)
+            .resolve_frames(resolve_frames)
+            .signals(default_signals())
+            .timeout(timeout)
+            .demangle_names(true)
+            .build()
+            .unwrap();


Not sure we need the temp variables anymore in this format

danielsn

LGTM, in fact looks cleaner than the positional constructor we had before. A few small comments

hoolioh · 2026-03-13T11:27:49Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-03-13T11:27:53Z

View all feedbacks in Devflow UI.

2026-03-13 11:27:53 UTC ℹ️ Start processing command /merge

2026-03-13 11:27:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-03-13 12:16:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-03-13 12:55:07 UTC ℹ️ MergeQueue: This merge request was merged

datadog-datadog-prod-us1 · 2026-03-13T11:28:22Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: f1e7d11 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

# Release proposal for libdd-crashtracker and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-crashtracker **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-crashtracker-v2.0.0` ### Commits - chore(crashtracking): add tag for target triple (#1741) - refactor(libdd-crashtracker)!: avoid leaking Endpoint through the public API (#1705) - chore(cargo): bump to 29.0.0 (#1702) - fix(crashtracking): use libunwind to unwind frames (#1663) - chore(deps): bump blazesym to 0.2.3 and blazesym-c to 0.1.7 (#1654) - chore(ci): fix crashtracker receiver binary rpath setting (#1652) - chore(crashtracking): emit a best effort stacktrace for Mac (#1645) - chore(crashtracker): use default-features=false for aws-lc-sys (#1625) - feat(crashtracking): report unhandled exceptions (#1596) - refactor(ddcommon)!: remove direct dependency on hyper client everywhere in common (#1604) - feat(crashtracking): include `Kind` in crash ping and clarify requirements (#1595) - fix(crashtracking): add process_tags to application field (#1576) - ci: update nightly in CI to 2026-02-08 (#1539) - fix(telemetry)!: fix logs payload format [APMSP-2590] (#1498) - chore(crashtracking): bump os_info crate to 3.14 (#1507) - Don't bail (#1494) - feat(crashtracking)!: emit crashing thread name in crash report for linux crashes (#1485) - test(crashtracking): add minimal LD preload test for crashtracker collector (#1428) - chore: release libddcommon-v1.1.0 (#1456) - chore: prepare libdd-telemetry-v2.0.0 (#1457) - [crashtracker] Retrieve panic message when crashing (#1361) - fix(sidecar): AWS lambda also can return EACCESS for shm_open (#1446) - chore(crashtracking): add `is_crash_debug` tag to crashtracker receiver debug logs (#1445) - [crashtracker] Log errors in crashtracker receiver (#1395) - chore: add changelog for every published crate (#1396) - Fix CI (#1389) - [crashtracker] Set OS info in the crash info builder when receiving report (#1388) - crashtracker: support cxx bindings for crashinfo (#1379) [APMSP-2590]: https://datadoghq.atlassian.net/browse/APMSP-2590?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>

# Release proposal for libdd-crashtracker and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-crashtracker **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-crashtracker-v2.0.0` ### Commits - chore(ci): give libdd-libunwind-sys its own version (#1743) - chore(crashtracking): add tag for target triple (#1741) - refactor(libdd-crashtracker)!: avoid leaking Endpoint through the public API (#1705) - chore(cargo): bump to 29.0.0 (#1702) - fix(crashtracking): use libunwind to unwind frames (#1663) - chore(deps): bump blazesym to 0.2.3 and blazesym-c to 0.1.7 (#1654) - chore(ci): fix crashtracker receiver binary rpath setting (#1652) - chore(crashtracking): emit a best effort stacktrace for Mac (#1645) - chore(crashtracker): use default-features=false for aws-lc-sys (#1625) - feat(crashtracking): report unhandled exceptions (#1596) - refactor(ddcommon)!: remove direct dependency on hyper client everywhere in common (#1604) - feat(crashtracking): include `Kind` in crash ping and clarify requirements (#1595) - fix(crashtracking): add process_tags to application field (#1576) - ci: update nightly in CI to 2026-02-08 (#1539) - fix(telemetry)!: fix logs payload format [APMSP-2590] (#1498) - chore(crashtracking): bump os_info crate to 3.14 (#1507) - Don't bail (#1494) - feat(crashtracking)!: emit crashing thread name in crash report for linux crashes (#1485) - test(crashtracking): add minimal LD preload test for crashtracker collector (#1428) - chore: release libddcommon-v1.1.0 (#1456) - chore: prepare libdd-telemetry-v2.0.0 (#1457) - [crashtracker] Retrieve panic message when crashing (#1361) - fix(sidecar): AWS lambda also can return EACCESS for shm_open (#1446) - chore(crashtracking): add `is_crash_debug` tag to crashtracker receiver debug logs (#1445) - [crashtracker] Log errors in crashtracker receiver (#1395) - chore: add changelog for every published crate (#1396) - Fix CI (#1389) - [crashtracker] Set OS info in the crash info builder when receiving report (#1388) - crashtracker: support cxx bindings for crashinfo (#1379) [APMSP-2590]: https://datadoghq.atlassian.net/browse/APMSP-2590?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>

# Release proposal for libdd-crashtracker and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-crashtracker **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-crashtracker-v2.0.0` ### Commits - chore(crashtracking): rename target triple to runtime platform (#1747) - chore(ci): give libdd-libunwind-sys its own version (#1743) - chore(crashtracking): add tag for target triple (#1741) - refactor(libdd-crashtracker)!: avoid leaking Endpoint through the public API (#1705) - chore(cargo): bump to 29.0.0 (#1702) - fix(crashtracking): use libunwind to unwind frames (#1663) - chore(deps): bump blazesym to 0.2.3 and blazesym-c to 0.1.7 (#1654) - chore(ci): fix crashtracker receiver binary rpath setting (#1652) - chore(crashtracking): emit a best effort stacktrace for Mac (#1645) - chore(crashtracker): use default-features=false for aws-lc-sys (#1625) - feat(crashtracking): report unhandled exceptions (#1596) - refactor(ddcommon)!: remove direct dependency on hyper client everywhere in common (#1604) - feat(crashtracking): include `Kind` in crash ping and clarify requirements (#1595) - fix(crashtracking): add process_tags to application field (#1576) - ci: update nightly in CI to 2026-02-08 (#1539) - fix(telemetry)!: fix logs payload format [APMSP-2590] (#1498) - chore(crashtracking): bump os_info crate to 3.14 (#1507) - Don't bail (#1494) - feat(crashtracking)!: emit crashing thread name in crash report for linux crashes (#1485) - test(crashtracking): add minimal LD preload test for crashtracker collector (#1428) - chore: release libddcommon-v1.1.0 (#1456) - chore: prepare libdd-telemetry-v2.0.0 (#1457) - [crashtracker] Retrieve panic message when crashing (#1361) - fix(sidecar): AWS lambda also can return EACCESS for shm_open (#1446) - chore(crashtracking): add `is_crash_debug` tag to crashtracker receiver debug logs (#1445) - [crashtracker] Log errors in crashtracker receiver (#1395) - chore: add changelog for every published crate (#1396) - Fix CI (#1389) - [crashtracker] Set OS info in the crash info builder when receiving report (#1388) - crashtracker: support cxx bindings for crashinfo (#1379) Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>

# Release proposal for libdd-crashtracker and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-common **Next version:** `3.0.0` **Semver bump:** `major` **Tag:** `libdd-common-v3.0.0` ### Commits - refactor(trace-utils)!: change header name type to accept dynamic values (#1722) ## libdd-crashtracker **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-crashtracker-v2.0.0` ### Commits - chore(crashtracking): rename target triple to runtime platform (#1747) - chore(ci): give libdd-libunwind-sys its own version (#1743) - chore(crashtracking): add tag for target triple (#1741) - refactor(libdd-crashtracker)!: avoid leaking Endpoint through the public API (#1705) - chore(cargo): bump to 29.0.0 (#1702) - fix(crashtracking): use libunwind to unwind frames (#1663) - chore(deps): bump blazesym to 0.2.3 and blazesym-c to 0.1.7 (#1654) - chore(ci): fix crashtracker receiver binary rpath setting (#1652) - chore(crashtracking): emit a best effort stacktrace for Mac (#1645) - chore(crashtracker): use default-features=false for aws-lc-sys (#1625) - feat(crashtracking): report unhandled exceptions (#1596) - refactor(ddcommon)!: remove direct dependency on hyper client everywhere in common (#1604) - feat(crashtracking): include `Kind` in crash ping and clarify requirements (#1595) - fix(crashtracking): add process_tags to application field (#1576) - ci: update nightly in CI to 2026-02-08 (#1539) - fix(telemetry)!: fix logs payload format [APMSP-2590] (#1498) - chore(crashtracking): bump os_info crate to 3.14 (#1507) - Don't bail (#1494) - feat(crashtracking)!: emit crashing thread name in crash report for linux crashes (#1485) - test(crashtracking): add minimal LD preload test for crashtracker collector (#1428) - chore: release libddcommon-v1.1.0 (#1456) - chore: prepare libdd-telemetry-v2.0.0 (#1457) - [crashtracker] Retrieve panic message when crashing (#1361) - fix(sidecar): AWS lambda also can return EACCESS for shm_open (#1446) - chore(crashtracking): add `is_crash_debug` tag to crashtracker receiver debug logs (#1445) - [crashtracker] Log errors in crashtracker receiver (#1395) - chore: add changelog for every published crate (#1396) - Fix CI (#1389) - [crashtracker] Set OS info in the crash info builder when receiving report (#1388) - crashtracker: support cxx bindings for crashinfo (#1379) [APMSP-2590]: https://datadoghq.atlassian.net/browse/APMSP-2590?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>

…ration (#1758) # What does this PR do? Previous PR (#1705) missed some fields for Endpoint configuration on the FFI layer. This PR solves that issue. Co-authored-by: bob.weinand <[email protected]>

The way to specify the `endpoint` was changed in DataDog/libdatadog#1705 so this updates it to match.

github-actions bot added the crashtracker label Mar 11, 2026

hoolioh added 2 commits March 11, 2026 18:43

fix(libdd-crashtracker): avoid leaking Endpoint through the public API

f73e8c9

chore(datadog-sidecar): use crastracker configuration builder

913c7d9

hoolioh force-pushed the julio/remove-common-as-external-dependency branch from e6f8387 to 913c7d9 Compare March 11, 2026 17:44

github-actions bot added the sidecar label Mar 11, 2026

hoolioh added 2 commits March 11, 2026 19:19

fix: don't build option if url is empty so Endpoint is not instantiated.

ff68810

chore(bin-tests): use builder

b74e52a

hoolioh force-pushed the julio/remove-common-as-external-dependency branch from 112b573 to b74e52a Compare March 12, 2026 08:40

hoolioh changed the title ~~fix(libdd-crashtracker): avoid leaking Endpoint through the public API~~ refactor(libdd-crashtracker)!: avoid leaking Endpoint through the public API Mar 12, 2026

hoolioh added 2 commits March 12, 2026 13:19

fix(libdd-crashtracker): use builder on benches

312a29c

fix: pass charslice to crashtracker configuration on ffi layer

f510db7

hoolioh force-pushed the julio/remove-common-as-external-dependency branch from 0f3144a to 853eaf8 Compare March 12, 2026 12:19

chore(libdd-crashtracker): add builder unit tests

a15aa94

hoolioh force-pushed the julio/remove-common-as-external-dependency branch from 853eaf8 to a15aa94 Compare March 12, 2026 12:22

hoolioh marked this pull request as ready for review March 12, 2026 13:54

hoolioh requested review from a team as code owners March 12, 2026 13:54

danielsn reviewed Mar 12, 2026

View reviewed changes

danielsn approved these changes Mar 12, 2026

View reviewed changes

chore: solve PR comments

f1e7d11

gh-worker-dd-devflow-36fce6 bot added the mergequeue-status: waiting label Mar 13, 2026

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Mar 13, 2026

gh-worker-dd-mergequeue-cf854d bot merged commit 892b7bf into main Mar 13, 2026
125 of 128 checks passed

gh-worker-dd-devflow-36fce6 bot removed the mergequeue-status: in_progress label Mar 13, 2026

gh-worker-dd-mergequeue-cf854d bot deleted the julio/remove-common-as-external-dependency branch March 13, 2026 12:55

gh-worker-dd-devflow-36fce6 bot added the mergequeue-status: done label Mar 13, 2026

dd-octo-sts bot mentioned this pull request Mar 17, 2026

chore(release): proposal for libdd-crashtracker #1745

Merged

dd-octo-sts bot mentioned this pull request Mar 17, 2026

chore(release): proposal for libdd-crashtracker #1746

Merged

dd-octo-sts bot mentioned this pull request Mar 17, 2026

chore(release): proposal for libdd-crashtracker #1748

Merged

dd-octo-sts bot mentioned this pull request Mar 17, 2026

chore(release): proposal for libdd-crashtracker #1752

Merged

dd-octo-sts bot mentioned this pull request Mar 17, 2026

chore(release): proposal for libdd-crashtracker #1755

Merged

dd-octo-sts bot mentioned this pull request Mar 18, 2026

chore(release): proposal for libdd-crashtracker #1756

Merged

hoolioh mentioned this pull request Mar 18, 2026

fix(libdd-crashtracker-ffi)!: add missing fields for endpoint configuration #1758

Merged

ivoanjo added a commit to DataDog/dd-trace-rb that referenced this pull request Mar 30, 2026

Update crashtracker API to match v30 API change

12ddeb0

The way to specify the `endpoint` was changed in DataDog/libdatadog#1705 so this updates it to match.

Conversation

hoolioh commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

How to test the change?

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Clippy Allow Annotation Report

Summary by Rule

Annotation Counts by File

Annotation Stats by Crate

About This Report

Uh oh!

pr-commenter bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Comparison

Explanation

More details about the CI and significant changes

scenario:benching serializing traces from their internal representation to msgpack

scenario:concentrator/add_spans_to_concentrator

scenario:credit_card/is_card_number/ 378282246310005

scenario:credit_card/is_card_number/378282246310005

scenario:credit_card/is_card_number/37828224631000521389798

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

scenario:credit_card/is_card_number_no_luhn/378282246310005

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

Candidate

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Group 12

Group 13

Group 14

Group 15

Group 16

Group 17

Group 18

Group 19

Baseline

Uh oh!

codecov-commenter commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dd-octo-sts bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

danielsn Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

danielsn Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

danielsn Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

danielsn Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

danielsn left a comment

Choose a reason for hiding this comment

Uh oh!

hoolioh commented Mar 13, 2026

Uh oh!

hoolioh commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading

pr-commenter bot commented Mar 11, 2026 •

edited

Loading

codecov-commenter commented Mar 12, 2026 •

edited

Loading

dd-octo-sts bot commented Mar 12, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Mar 13, 2026 •

edited

Loading

datadog-datadog-prod-us1 bot commented Mar 13, 2026 •

edited by datadog-datadog-prod-us1-2 bot

Loading