Skip to content

refactor(data-pipeline-ffi): move macro definitions for better reuse#1699

Merged
paullegranddc merged 2 commits intomainfrom
paullgdc/data_pipeline_ffi/move_macros
Mar 10, 2026
Merged

refactor(data-pipeline-ffi): move macro definitions for better reuse#1699
paullegranddc merged 2 commits intomainfrom
paullgdc/data_pipeline_ffi/move_macros

Conversation

@paullegranddc
Copy link
Copy Markdown
Contributor

@paullegranddc paullegranddc commented Mar 10, 2026

Motivation

So these macros can be used in other modules.

@paullegranddc
refactor(data-pipeline-ffi): move macro definitions for better reuse
d49c469 
# Motivation

So these macros can be used in other modules.
@paullegranddc paullegranddc requested a review from a team as a code owner March 10, 2026 12:39
@paullegranddc paullegranddc mentioned this pull request Mar 10, 2026
Draft
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026 •
edited
Loading

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/paullgdc/data_pipeline_ffi/move_macros

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 28 28 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-crashtracker 0 12 ⚠️ +12 (N/A)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 208 220 ⚠️ +12 (+5.8%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 10, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.01%. Comparing base (04394ec) to head (cde7cfe).
⚠️ Report is 78 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   71.33%   71.01%   -0.33%     
==========================================
  Files         427      427              
  Lines       62960    62962       +2     
==========================================
- Hits        44914    44710     -204     
- Misses      18046    18252     +206
Components Coverage Δ
libdd-crashtracker 62.45% <ø> (-0.50%) ⬇️
libdd-crashtracker-ffi 17.49% <ø> (+0.92%) ⬆️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 87.64% <ø> (-0.39%) ⬇️
libdd-data-pipeline-ffi 73.55% <ø> (-2.17%) ⬇️
libdd-common 79.73% <ø> (-0.01%) ⬇️
libdd-common-ffi 73.40% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.35% <ø> (ø)
libdd-profiling 81.59% <ø> (ø)
libdd-profiling-ffi 63.65% <ø> (ø)
datadog-sidecar 32.47% <ø> (-2.02%) ⬇️
datdog-sidecar-ffi 7.73% <ø> (-8.82%) ⬇️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 94.69% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.08% <ø> (ø)
datadog-tracer-flare 88.95% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yannham
yannham reviewed Mar 10, 2026
View reviewed changes
libdd-data-pipeline-ffi/src/trace_exporter.rs Outdated
out_handle: NonNull<Box<TraceExporterConfig>>,
) {
catch_panic!(
crate::catch_panic!(
Copy link
Copy Markdown
Contributor

@yannham yannham Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not import the macros once and for all? It seems there are a lot of occurrences.

Copy link
Copy Markdown
Contributor Author

@paullegranddc paullegranddc Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm no, I changed to use an import

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 10, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-03-10 15:24:34

Comparing candidate commit cde7cfe in PR branch paullgdc/data_pipeline_ffi/move_macros with baseline commit 3f3efef in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 239.526ns 251.084ns ± 12.808ns 244.663ns ± 3.742ns 256.819ns 281.654ns 284.266ns 284.652ns 16.34% 1.259 0.371 5.09% 0.906ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [249.309ns; 252.859ns] or [-0.707%; +0.707%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.128µs 185.663µs ± 0.228µs 185.661µs ± 0.160µs 185.823µs 186.052µs 186.168µs 186.401µs 0.40% 0.146 -0.283 0.12% 0.016µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5364769.452op/s 5386099.816op/s ± 6626.580op/s 5386157.897op/s ± 4630.848op/s 5390702.447op/s 5396380.761op/s 5399639.861op/s 5401672.412op/s 0.29% -0.140 -0.289 0.12% 468.570op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.913µs 18.009µs ± 0.047µs 18.005µs ± 0.038µs 18.046µs 18.083µs 18.106µs 18.121µs 0.65% 0.103 -0.965 0.26% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55185129.880op/s 55527147.460op/s ± 145086.841op/s 55541618.293op/s ± 116796.196op/s 55638136.109op/s 55744399.468op/s 55774719.050op/s 55825168.707op/s 0.51% -0.095 -0.968 0.26% 10259.189op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.324µs 10.390µs ± 0.042µs 10.382µs ± 0.026µs 10.410µs 10.471µs 10.511µs 10.524µs 1.37% 0.887 0.382 0.40% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 95019399.794op/s 96243916.661op/s ± 383989.322op/s 96320484.525op/s ± 237643.606op/s 96545164.213op/s 96732809.070op/s 96803576.035op/s 96866017.420op/s 0.57% -0.868 0.336 0.40% 27152.145op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.632µs; 185.695µs] or [-0.017%; +0.017%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5385181.436op/s; 5387018.197op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.003µs; 18.016µs] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55507039.819op/s; 55547255.100op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.385µs; 10.396µs] or [-0.055%; +0.055%] None None None
normalization/normalize_name/normalize_name/good throughput [96190699.434op/s; 96297133.888op/s] or [-0.055%; +0.055%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.318µs 2.394µs ± 0.021µs 2.397µs ± 0.004µs 2.403µs 2.416µs 2.421µs 2.422µs 1.07% -2.143 4.770 0.86% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.391µs; 2.397µs] or [-0.120%; +0.120%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.149ms 4.155ms ± 0.007ms 4.154ms ± 0.002ms 4.156ms 4.158ms 4.168ms 4.242ms 2.13% 10.580 130.747 0.16% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.154ms; 4.155ms] or [-0.023%; +0.023%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.878µs 34.770µs ± 1.196µs 34.045µs ± 0.082µs 35.657µs 37.033µs 37.146µs 38.532µs 13.18% 1.127 -0.355 3.43% 0.085µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.604µs; 34.935µs] or [-0.477%; +0.477%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 86.529µs 86.792µs ± 0.133µs 86.780µs ± 0.055µs 86.836µs 86.955µs 87.235µs 87.958µs 1.36% 4.006 30.581 0.15% 0.009µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.774µs; 86.811µs] or [-0.021%; +0.021%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 715.987µs 717.223µs ± 0.519µs 717.202µs ± 0.395µs 717.597µs 718.068µs 718.498µs 718.744µs 0.21% 0.303 -0.349 0.07% 0.037µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [717.151µs; 717.295µs] or [-0.010%; +0.010%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 187.965ns 190.374ns ± 2.606ns 189.989ns ± 1.394ns 191.170ns 194.213ns 200.405ns 207.106ns 9.01% 2.696 11.046 1.37% 0.184ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.013ns; 190.735ns] or [-0.190%; +0.190%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 3.281ms 3.313ms ± 0.018ms 3.311ms ± 0.011ms 3.320ms 3.350ms 3.360ms 3.397ms 2.59% 1.157 2.166 0.54% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [3.310ms; 3.315ms] or [-0.075%; +0.075%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.603µs 25.191µs ± 9.338µs 17.874µs ± 0.155µs 33.697µs 42.194µs 42.772µs 64.619µs 261.52% 0.892 0.195 36.97% 0.660µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.897µs; 26.486µs] or [-5.137%; +5.137%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.685µs 146.844µs ± 1.787µs 146.555µs ± 0.500µs 147.067µs 149.151µs 154.332µs 163.432µs 11.52% 5.427 41.189 1.21% 0.126µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.596µs; 147.092µs] or [-0.169%; +0.169%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 48.457ms 48.690ms ± 1.021ms 48.552ms ± 0.042ms 48.614ms 48.730ms 51.878ms 61.793ms 27.27% 11.193 136.043 2.09% 0.072ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [48.549ms; 48.832ms] or [-0.291%; +0.291%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.930ms 13.981ms ± 0.031ms 13.976ms ± 0.012ms 13.989ms 14.028ms 14.119ms 14.139ms 1.16% 2.260 7.437 0.22% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [13.977ms; 13.986ms] or [-0.031%; +0.031%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.095µs 161.717µs ± 0.251µs 161.673µs ± 0.120µs 161.805µs 162.184µs 162.573µs 162.885µs 0.75% 1.321 3.513 0.15% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.682µs; 161.752µs] or [-0.021%; +0.021%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.896µs 3.912µs ± 0.002µs 3.912µs ± 0.001µs 3.914µs 3.916µs 3.920µs 3.920µs 0.21% -0.903 9.963 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 255087987.392op/s 255596943.403op/s ± 161259.931op/s 255616180.505op/s ± 93243.362op/s 255694108.220op/s 255783675.710op/s 255827515.084op/s 256690524.022op/s 0.42% 0.924 10.099 0.06% 11402.799op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 78.996µs 79.756µs ± 0.376µs 79.709µs ± 0.279µs 80.003µs 80.516µs 80.739µs 80.857µs 1.44% 0.563 -0.064 0.47% 0.027µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12367545.793op/s 12538565.973op/s ± 58982.966op/s 12545665.377op/s ± 44141.915op/s 12588595.707op/s 12621672.241op/s 12637359.614op/s 12658894.240op/s 0.90% -0.540 -0.101 0.47% 4170.725op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 72.351µs 72.852µs ± 0.326µs 72.795µs ± 0.207µs 73.022µs 73.471µs 73.739µs 74.181µs 1.90% 1.030 1.216 0.45% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13480456.562op/s 13726656.481op/s ± 61109.302op/s 13737212.162op/s ± 39184.057op/s 13775381.329op/s 13803155.975op/s 13816304.504op/s 13821470.272op/s 0.61% -1.002 1.118 0.44% 4321.080op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.918µs 3.919µs 0.19% -1.834 16.914 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255147801.551op/s 255631338.701op/s ± 163970.756op/s 255644162.529op/s ± 85131.457op/s 255724486.684op/s 255827330.725op/s 255896736.146op/s 256902650.580op/s 0.49% 1.864 17.166 0.06% 11594.483op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 69.228µs 69.658µs ± 0.317µs 69.604µs ± 0.212µs 69.827µs 70.304µs 70.663µs 70.861µs 1.81% 1.132 1.306 0.45% 0.022µs 1 200
credit_card/is_card_number/378282246310005 throughput 14112200.026op/s 14356167.837op/s ± 64950.682op/s 14366933.930op/s ± 43694.319op/s 14407918.594op/s 14430675.722op/s 14441854.054op/s 14445087.451op/s 0.54% -1.105 1.209 0.45% 4592.707op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.152µs 52.211µs ± 0.028µs 52.208µs ± 0.017µs 52.228µs 52.261µs 52.283µs 52.305µs 0.19% 0.520 0.374 0.05% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19118657.759op/s 19152886.688op/s ± 10238.784op/s 19154082.875op/s ± 6193.855op/s 19159529.327op/s 19168465.287op/s 19172268.082op/s 19174781.328op/s 0.11% -0.517 0.368 0.05% 723.991op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.029µs 6.037µs ± 0.009µs 6.035µs ± 0.002µs 6.037µs 6.065µs 6.073µs 6.076µs 0.68% 3.218 9.913 0.15% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 164591923.844op/s 165642816.895op/s ± 243471.007op/s 165707759.768op/s ± 53509.371op/s 165754329.718op/s 165797645.717op/s 165837997.788op/s 165860467.278op/s 0.09% -3.211 9.877 0.15% 17216.000op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.913µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.918µs 3.920µs 0.18% -1.943 11.634 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255130814.432op/s 255590569.271op/s ± 194810.482op/s 255597507.925op/s ± 113944.201op/s 255704071.558op/s 255823913.722op/s 255904937.519op/s 256806863.857op/s 0.47% 1.965 11.788 0.08% 13775.181op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.212µs 65.016µs ± 1.234µs 64.513µs ± 0.138µs 64.749µs 68.426µs 69.235µs 69.950µs 8.43% 2.390 4.754 1.89% 0.087µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14295910.773op/s 15386165.192op/s ± 279640.119op/s 15500711.218op/s ± 33208.528op/s 15518707.141op/s 15550337.142op/s 15560613.388op/s 15573482.135op/s 0.47% -2.334 4.433 1.81% 19773.542op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.808µs 58.059µs ± 0.138µs 58.030µs ± 0.074µs 58.124µs 58.317µs 58.443µs 58.743µs 1.23% 1.257 2.813 0.24% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17023313.280op/s 17223881.006op/s ± 40891.328op/s 17232561.233op/s ± 22047.206op/s 17249544.275op/s 17276630.163op/s 17284620.512op/s 17298598.813op/s 0.38% -1.234 2.706 0.24% 2891.454op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.891µs 3.912µs ± 0.002µs 3.912µs ± 0.001µs 3.913µs 3.915µs 3.917µs 3.919µs 0.17% -2.953 26.354 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255190817.761op/s 255627059.099op/s ± 155561.565op/s 255621511.416op/s ± 76369.337op/s 255710158.098op/s 255802972.209op/s 255875777.006op/s 256974103.302op/s 0.53% 2.989 26.723 0.06% 10999.864op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.604µs 55.077µs ± 0.346µs 55.035µs ± 0.214µs 55.245µs 55.657µs 56.320µs 56.450µs 2.57% 1.287 2.527 0.63% 0.024µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17714778.057op/s 18157264.148op/s ± 113165.017op/s 18170196.389op/s ± 70643.355op/s 18242484.009op/s 18296643.709op/s 18309001.673op/s 18313610.313op/s 0.79% -1.234 2.319 0.62% 8001.975op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.166µs 52.229µs ± 0.033µs 52.225µs ± 0.021µs 52.249µs 52.284µs 52.317µs 52.375µs 0.29% 0.834 1.279 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19093088.252op/s 19146320.627op/s ± 12118.161op/s 19147867.060op/s ± 7585.721op/s 19154961.419op/s 19163100.779op/s 19165552.049op/s 19169392.231op/s 0.11% -0.829 1.262 0.06% 856.883op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.038µs ± 0.010µs 6.035µs ± 0.002µs 6.038µs 6.061µs 6.078µs 6.110µs 1.24% 3.808 16.910 0.17% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163670634.197op/s 165629413.730op/s ± 279400.617op/s 165693343.345op/s ± 57946.146op/s 165748079.334op/s 165821397.268op/s 165851506.403op/s 165894844.908op/s 0.12% -3.786 16.677 0.17% 19756.607op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255574594.327op/s; 255619292.479op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.704µs; 79.808µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12530391.501op/s; 12546740.445op/s] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [72.807µs; 72.898µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13718187.319op/s; 13735125.642op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255608613.931op/s; 255654063.471op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [69.614µs; 69.702µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/378282246310005 throughput [14347166.297op/s; 14365169.377op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.208µs; 52.215µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19151467.691op/s; 19154305.685op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.036µs; 6.038µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number/x371413321323331 throughput [165609074.155op/s; 165676559.635op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255563570.412op/s; 255617568.130op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.845µs; 65.187µs] or [-0.263%; +0.263%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15347409.761op/s; 15424920.623op/s] or [-0.252%; +0.252%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.040µs; 58.078µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17218213.862op/s; 17229548.151op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.912µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255605499.762op/s; 255648618.436op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.029µs; 55.124µs] or [-0.087%; +0.087%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18141580.565op/s; 18172947.731op/s] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.225µs; 52.234µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19144641.167op/s; 19148000.088op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.036µs; 6.039µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165590691.492op/s; 165668135.969op/s] or [-0.023%; +0.023%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.509µs 535.673µs ± 0.968µs 535.409µs ± 0.333µs 535.824µs 537.675µs 539.359µs 540.943µs 1.03% 2.330 6.856 0.18% 0.068µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1848623.004op/s 1866816.324op/s ± 3360.190op/s 1867730.204op/s ± 1160.530op/s 1868770.998op/s 1869956.062op/s 1870176.331op/s 1870876.094op/s 0.17% -2.312 6.733 0.18% 237.601op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.103µs 380.992µs ± 0.412µs 380.918µs ± 0.259µs 381.249µs 381.776µs 382.072µs 382.190µs 0.33% 0.624 -0.106 0.11% 0.029µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2616499.647op/s 2624732.734op/s ± 2835.715op/s 2625240.074op/s ± 1782.450op/s 2626932.148op/s 2628539.376op/s 2629476.200op/s 2630863.437op/s 0.21% -0.619 -0.113 0.11% 200.515op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.586µs 190.090µs ± 0.189µs 190.088µs ± 0.119µs 190.204µs 190.409µs 190.545µs 190.725µs 0.34% 0.334 0.130 0.10% 0.013µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5243137.741op/s 5260679.947op/s ± 5233.778op/s 5260718.512op/s ± 3278.881op/s 5264094.918op/s 5268736.570op/s 5270191.012op/s 5274651.795op/s 0.26% -0.328 0.123 0.10% 370.084op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.407µs 37.580µs ± 0.064µs 37.580µs ± 0.050µs 37.628µs 37.682µs 37.718µs 37.737µs 0.42% 0.110 -0.554 0.17% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26498957.708op/s 26609663.870op/s ± 45438.444op/s 26609641.782op/s ± 35589.558op/s 26646067.776op/s 26676243.015op/s 26702018.635op/s 26732760.234op/s 0.46% -0.102 -0.554 0.17% 3212.983op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.786µs 45.892µs ± 0.041µs 45.893µs ± 0.026µs 45.918µs 45.952µs 46.010µs 46.020µs 0.28% 0.105 0.358 0.09% 0.003µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21729682.747op/s 21790517.292op/s ± 19407.900op/s 21789984.258op/s ± 12542.025op/s 21802807.535op/s 21823578.467op/s 21834556.361op/s 21840520.037op/s 0.23% -0.099 0.352 0.09% 1372.346op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [535.539µs; 535.807µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1866350.634op/s; 1867282.014op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.935µs; 381.049µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2624339.731op/s; 2625125.737op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.063µs; 190.116µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5259954.595op/s; 5261405.298op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.572µs; 37.589µs] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26603366.538op/s; 26615961.201op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.886µs; 45.897µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21787827.544op/s; 21793207.041op/s] or [-0.012%; +0.012%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.209µs 3.203µs ± 1.414µs 2.978µs ± 0.025µs 3.006µs 3.657µs 13.886µs 14.522µs 387.61% 7.290 54.505 44.03% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.007µs; 3.399µs] or [-6.117%; +6.117%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.936µs 5.010µs ± 0.047µs 4.990µs ± 0.031µs 5.059µs 5.081µs 5.087µs 5.100µs 2.20% 0.310 -1.521 0.94% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.003µs; 5.017µs] or [-0.130%; +0.130%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cde7cfe 1773155215 paullgdc/data_pipeline_ffi/move_macros
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.714ms 10.737ms ± 0.014ms 10.735ms ± 0.008ms 10.744ms 10.762ms 10.772ms 10.801ms 0.62% 1.016 1.957 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.735ms; 10.739ms] or [-0.018%; +0.018%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Mar 10, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.70 MB 8.70 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 98.65 MB 98.65 MB +0% (+16 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.29 MB 11.29 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 114.30 MB 114.30 MB +0% (+24 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.17 MB 27.17 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.03 MB 186.04 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.20 MB 917.20 MB +0% (+1.14 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.93 MB 9.93 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.76 MB 24.77 MB +.03% (+8.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.43 MB 51.43 MB +0% (+1.12 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.97 MB 22.97 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.24 MB 190.25 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 900.85 MB 900.85 MB +0% (+1.14 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.53 MB 7.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.52 MB 26.52 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.07 MB 47.07 MB +0% (+1.12 KB) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 86.54 MB 86.54 MB +0% (+8 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.23 MB 10.23 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 107.16 MB 107.16 MB +0% (+16 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.98 MB 11.98 MB 0% (0 B) 👌

@paullegranddc paullegranddc merged commit b6e1ba4 into main Mar 10, 2026
64 of 66 checks passed
@paullegranddc paullegranddc deleted the paullgdc/data_pipeline_ffi/move_macros branch March 10, 2026 17:50
@gyuheon0h gyuheon0h mentioned this pull request Mar 11, 2026
Merged
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Mar 11, 2026
@gyuheon0h
chore(cargo): bump to 29.0.0 (#1702)
001bd56 
# What does this PR do?

Bump to 29.0.0

[feat(profiling)!: add Tracepoint sample type](#1676)
[feat(obfuscation/redis): Reach feature parity on redis obfuscation [APMSP-2668]](#1632)
[fix(sidecar): Handle backpressure more gracefully](#1682)
[feat(trace-protobuf)!: Add two fields to ClientGroupedStats [SVLS-8627]](#1630)
[chore: exclude libdatadog from ADMS auto generated PRs for dependency updates](#1688)
[chore(ci): run crashtracking ffi example tests in CI](#1687)
[fix(crashtracking): use libunwind to unwind frames](#1663)
[feat: publish tracer metadata as OTel process ctx](#1658)
[ci: run thread count test in own process](#1693)
[feat(obfuscation/json): Init json obfuscation [APMSP-2665]](#1635)
[chore(ci): add final_status property on junit XML [APMSP-2610]](#1681)
[refactor(data-pipeline-ffi): move macro definitions for better reuse](#1699)
[fix(obfuscation/memcached): fuzzing fix](#1695)
[ci: replace use of cargo cross for centos7 tests](#1675)
#1702 (comment)
[feat(stats_exporter)!: add process tags to CSS payloads](#1709)

# Motivation

I mainly am creating this to use the new unwinding from ucontext for crashtracking

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?

Describe here in detail how the change can be validated.


[APMSP-2668]: https://datadoghq.atlassian.net/browse/APMSP-2668?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[SVLS-8627]: https://datadoghq.atlassian.net/browse/SVLS-8627?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-2665]: https://datadoghq.atlassian.net/browse/APMSP-2665?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: gyuheon.oh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yannham yannham yannham left review comments

@bantonsson bantonsson bantonsson approved these changes

@ekump ekump ekump approved these changes

Assignees

No one assigned

Labels

data-pipeline

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paullegranddc @codecov-commenter @bantonsson @ekump @yannham