fix(obfuscation/memcached): fuzzing fix#1695
fix(obfuscation/memcached): fuzzing fix#1695gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
Conversation
…mSpace Go's ObfuscateMemcachedString calls strings.TrimSpace() on the result after splitting on \r\n. Rust was not trimming, causing a tab-only input to return "\t" instead of "". Fixes fuzzing testcase: memcached_fuzzing_2126976840
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
BenchmarksComparisonBenchmark execution time: 2026-03-10 17:25:59 Comparing candidate commit 5755181 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 2 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | 13.915ms | 13.973ms ± 0.031ms | 13.970ms ± 0.016ms | 13.987ms | 14.025ms | 14.080ms | 14.156ms | 1.33% | 1.984 | 8.000 | 0.22% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | [13.969ms; 13.977ms] or [-0.031%; +0.031%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | 2.309µs | 2.383µs ± 0.019µs | 2.385µs ± 0.008µs | 2.393µs | 2.408µs | 2.419µs | 2.429µs | 1.85% | -1.641 | 4.248 | 0.78% | 0.001µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | [2.380µs; 2.385µs] or [-0.108%; +0.108%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | 5.001µs | 5.061µs ± 0.053µs | 5.029µs ± 0.019µs | 5.091µs | 5.163µs | 5.167µs | 5.167µs | 2.75% | 0.817 | -0.795 | 1.04% | 0.004µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | [5.054µs; 5.069µs] or [-0.145%; +0.145%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 190.701ns | 193.469ns ± 2.465ns | 193.163ns ± 1.407ns | 194.435ns | 198.199ns | 201.353ns | 205.931ns | 6.61% | 1.626 | 3.842 | 1.27% | 0.174ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [193.127ns; 193.810ns] or [-0.177%; +0.177%] | None | None | None |
Group 5
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 144.242µs | 146.099µs ± 1.973µs | 145.791µs ± 0.472µs | 146.270µs | 148.125µs | 153.631µs | 166.673µs | 14.32% | 6.800 | 61.643 | 1.35% | 0.140µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [145.826µs; 146.373µs] or [-0.187%; +0.187%] | None | None | None |
Group 6
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | 3.902µs | 3.915µs ± 0.003µs | 3.915µs ± 0.002µs | 3.917µs | 3.921µs | 3.922µs | 3.924µs | 0.22% | 0.074 | 1.389 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/ | throughput | 254872478.471op/s | 255402592.312op/s ± 189102.616op/s | 255428314.052op/s ± 117512.117op/s | 255528548.928op/s | 255648166.123op/s | 255735331.498op/s | 256255338.235op/s | 0.32% | -0.067 | 1.408 | 0.07% | 13371.574op/s | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | 79.808µs | 79.991µs ± 0.091µs | 79.974µs ± 0.057µs | 80.052µs | 80.137µs | 80.258µs | 80.401µs | 0.53% | 0.842 | 1.508 | 0.11% | 0.006µs | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | 12437700.800op/s | 12501429.545op/s ± 14170.920op/s | 12504126.363op/s ± 8959.197op/s | 12510263.107op/s | 12520343.933op/s | 12526650.584op/s | 12530085.989op/s | 0.21% | -0.832 | 1.473 | 0.11% | 1002.035op/s | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | execution_time | 67.833µs | 67.944µs ± 0.068µs | 67.942µs ± 0.031µs | 67.971µs | 68.026µs | 68.064µs | 68.586µs | 0.95% | 4.226 | 37.724 | 0.10% | 0.005µs | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | throughput | 14580133.052op/s | 14718105.196op/s ± 14709.720op/s | 14718491.935op/s ± 6634.478op/s | 14725552.394op/s | 14736115.404op/s | 14740898.403op/s | 14742056.348op/s | 0.16% | -4.161 | 36.928 | 0.10% | 1040.134op/s | 1 | 200 |
| credit_card/is_card_number/37828224631 | execution_time | 3.896µs | 3.915µs ± 0.003µs | 3.915µs ± 0.001µs | 3.916µs | 3.919µs | 3.921µs | 3.923µs | 0.19% | -1.662 | 13.681 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/37828224631 | throughput | 254921263.479op/s | 255422289.385op/s ± 168405.726op/s | 255418105.332op/s ± 85208.637op/s | 255503502.152op/s | 255652238.940op/s | 255735610.409op/s | 256661228.491op/s | 0.49% | 1.688 | 13.881 | 0.07% | 11908.083op/s | 1 | 200 |
| credit_card/is_card_number/378282246310005 | execution_time | 64.607µs | 64.696µs ± 0.049µs | 64.688µs ± 0.032µs | 64.726µs | 64.790µs | 64.842µs | 64.870µs | 0.28% | 0.723 | 0.516 | 0.08% | 0.003µs | 1 | 200 |
| credit_card/is_card_number/378282246310005 | throughput | 15415507.603op/s | 15456876.354op/s ± 11798.756op/s | 15458806.149op/s ± 7742.878op/s | 15465434.753op/s | 15473572.917op/s | 15476331.968op/s | 15478168.044op/s | 0.13% | -0.718 | 0.505 | 0.08% | 834.298op/s | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | execution_time | 45.476µs | 45.712µs ± 0.095µs | 45.715µs ± 0.066µs | 45.771µs | 45.883µs | 45.935µs | 46.008µs | 0.64% | 0.289 | 0.008 | 0.21% | 0.007µs | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | throughput | 21735475.492op/s | 21876168.315op/s ± 45669.518op/s | 21874819.895op/s ± 31433.089op/s | 21908275.303op/s | 21942989.058op/s | 21977005.328op/s | 21989757.793op/s | 0.53% | -0.277 | -0.001 | 0.21% | 3229.323op/s | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | execution_time | 6.586µs | 6.631µs ± 0.011µs | 6.636µs ± 0.004µs | 6.639µs | 6.642µs | 6.645µs | 6.646µs | 0.16% | -1.349 | 1.389 | 0.17% | 0.001µs | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | throughput | 150457945.161op/s | 150808723.940op/s ± 256615.087op/s | 150702250.042op/s ± 99517.456op/s | 150947723.314op/s | 151340124.361op/s | 151546938.663op/s | 151831749.507op/s | 0.75% | 1.357 | 1.421 | 0.17% | 18145.427op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | execution_time | 3.897µs | 3.915µs ± 0.003µs | 3.916µs ± 0.002µs | 3.917µs | 3.920µs | 3.923µs | 3.925µs | 0.23% | -0.921 | 7.718 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | throughput | 254808945.171op/s | 255396291.159op/s ± 190135.154op/s | 255392299.937op/s ± 102565.310op/s | 255499280.642op/s | 255669479.511op/s | 255730775.779op/s | 256612932.347op/s | 0.48% | 0.941 | 7.835 | 0.07% | 13444.586op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | 65.038µs | 65.728µs ± 0.093µs | 65.739µs ± 0.035µs | 65.773µs | 65.819µs | 65.853µs | 65.860µs | 0.18% | -4.553 | 28.615 | 0.14% | 0.007µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | 15183787.843op/s | 15214234.459op/s ± 21651.065op/s | 15211732.407op/s ± 8132.980op/s | 15220183.834op/s | 15231953.457op/s | 15343479.423op/s | 15375513.761op/s | 1.08% | 4.595 | 28.995 | 0.14% | 1530.962op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | 53.365µs | 53.434µs ± 0.066µs | 53.426µs ± 0.021µs | 53.449µs | 53.487µs | 53.596µs | 54.006µs | 1.09% | 6.509 | 53.375 | 0.12% | 0.005µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | 18516557.792op/s | 18714783.137op/s ± 22908.885op/s | 18717541.742op/s ± 7446.890op/s | 18724292.536op/s | 18733474.342op/s | 18736697.618op/s | 18738843.909op/s | 0.11% | -6.461 | 52.824 | 0.12% | 1619.903op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | 3.892µs | 3.915µs ± 0.003µs | 3.915µs ± 0.002µs | 3.917µs | 3.919µs | 3.921µs | 3.923µs | 0.20% | -2.388 | 19.284 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | 254912248.828op/s | 255410039.335op/s ± 190624.305op/s | 255415648.996op/s ± 109229.833op/s | 255513995.801op/s | 255652934.143op/s | 255751137.402op/s | 256945730.849op/s | 0.60% | 2.423 | 19.618 | 0.07% | 13479.174op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | 50.149µs | 50.259µs ± 0.105µs | 50.249µs ± 0.027µs | 50.279µs | 50.321µs | 50.384µs | 51.223µs | 1.94% | 7.599 | 66.919 | 0.21% | 0.007µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | 19522361.987op/s | 19896841.732op/s ± 41005.797op/s | 19900909.393op/s ± 10689.484op/s | 19911002.300op/s | 19927285.634op/s | 19936782.597op/s | 19940610.879op/s | 0.20% | -7.529 | 66.087 | 0.21% | 2899.548op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | 45.431µs | 45.716µs ± 0.110µs | 45.711µs ± 0.078µs | 45.792µs | 45.904µs | 45.956µs | 45.988µs | 0.61% | 0.211 | -0.509 | 0.24% | 0.008µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | 21744733.902op/s | 21874355.167op/s ± 52598.746op/s | 21876542.890op/s ± 37118.456op/s | 21912613.448op/s | 21954502.493op/s | 21978680.515op/s | 22011545.709op/s | 0.62% | -0.201 | -0.511 | 0.24% | 3719.293op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | 6.588µs | 6.631µs ± 0.011µs | 6.635µs ± 0.004µs | 6.638µs | 6.642µs | 6.644µs | 6.645µs | 0.16% | -1.568 | 2.210 | 0.16% | 0.001µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | 150480286.235op/s | 150802223.243op/s ± 243185.993op/s | 150713726.812op/s ± 82449.684op/s | 150885557.101op/s | 151330881.949op/s | 151621698.868op/s | 151800336.916op/s | 0.72% | 1.577 | 2.247 | 0.16% | 17195.846op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | [3.915µs; 3.916µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/ | throughput | [255376384.508op/s; 255428800.116op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | [79.978µs; 80.004µs] or [-0.016%; +0.016%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | [12499465.592op/s; 12503393.499op/s] or [-0.016%; +0.016%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | execution_time | [67.934µs; 67.953µs] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | throughput | [14716066.571op/s; 14720143.822op/s] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/37828224631 | execution_time | [3.915µs; 3.915µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number/37828224631 | throughput | [255398949.971op/s; 255445628.799op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number/378282246310005 | execution_time | [64.689µs; 64.703µs] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number/378282246310005 | throughput | [15455241.160op/s; 15458511.548op/s] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | execution_time | [45.699µs; 45.725µs] or [-0.029%; +0.029%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | throughput | [21869838.959op/s; 21882497.671op/s] or [-0.029%; +0.029%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | execution_time | [6.629µs; 6.632µs] or [-0.024%; +0.024%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | throughput | [150773159.557op/s; 150844288.323op/s] or [-0.024%; +0.024%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | execution_time | [3.915µs; 3.916µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | throughput | [255369940.255op/s; 255422642.062op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | [65.715µs; 65.741µs] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | [15211233.830op/s; 15217235.088op/s] or [-0.020%; +0.020%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | [53.425µs; 53.443µs] or [-0.017%; +0.017%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | [18711608.185op/s; 18717958.088op/s] or [-0.017%; +0.017%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | [3.915µs; 3.916µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | [255383620.640op/s; 255436458.031op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | [50.245µs; 50.274µs] or [-0.029%; +0.029%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | [19891158.723op/s; 19902524.741op/s] or [-0.029%; +0.029%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | [45.701µs; 45.731µs] or [-0.033%; +0.033%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | [21867065.487op/s; 21881644.847op/s] or [-0.033%; +0.033%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | [6.630µs; 6.633µs] or [-0.022%; +0.022%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | [150768520.004op/s; 150835926.483op/s] or [-0.022%; +0.022%] | None | None | None |
Group 7
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | 245.362ns | 254.171ns ± 10.450ns | 249.918ns ± 2.710ns | 256.358ns | 278.870ns | 286.558ns | 287.275ns | 14.95% | 1.715 | 1.927 | 4.10% | 0.739ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | [252.723ns; 255.619ns] or [-0.570%; +0.570%] | None | None | None |
Group 8
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | 4.101ms | 4.106ms ± 0.007ms | 4.105ms ± 0.001ms | 4.107ms | 4.110ms | 4.114ms | 4.194ms | 2.17% | 11.511 | 148.303 | 0.16% | 0.000ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | [4.105ms; 4.107ms] or [-0.023%; +0.023%] | None | None | None |
Group 9
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 1.231µs | 3.143µs ± 1.420µs | 2.969µs ± 0.024µs | 2.991µs | 3.355µs | 13.607µs | 14.999µs | 405.19% | 7.514 | 56.997 | 45.06% | 0.100µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [2.946µs; 3.340µs] or [-6.260%; +6.260%] | None | None | None |
Group 10
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | 205.746µs | 206.435µs ± 0.390µs | 206.409µs ± 0.265µs | 206.667µs | 207.066µs | 207.446µs | 207.896µs | 0.72% | 0.568 | 0.262 | 0.19% | 0.028µs | 1 | 200 |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | 4810104.235op/s | 4844161.714op/s ± 9147.815op/s | 4844747.132op/s ± 6206.614op/s | 4851089.106op/s | 4857227.956op/s | 4860003.233op/s | 4860357.975op/s | 0.32% | -0.557 | 0.236 | 0.19% | 646.848op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | execution_time | 18.573µs | 18.853µs ± 0.203µs | 18.816µs ± 0.162µs | 18.991µs | 19.207µs | 19.366µs | 19.490µs | 3.58% | 0.679 | -0.191 | 1.08% | 0.014µs | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | throughput | 51309010.254op/s | 53046697.208op/s ± 568406.149op/s | 53146832.990op/s ± 456320.025op/s | 53567170.679op/s | 53748049.713op/s | 53783171.650op/s | 53840517.088op/s | 1.31% | -0.636 | -0.291 | 1.07% | 40192.384op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/good | execution_time | 10.635µs | 10.716µs ± 0.044µs | 10.709µs ± 0.025µs | 10.738µs | 10.792µs | 10.852µs | 10.896µs | 1.75% | 1.022 | 1.583 | 0.41% | 0.003µs | 1 | 200 |
| normalization/normalize_name/normalize_name/good | throughput | 91776927.421op/s | 93317928.491op/s ± 378526.359op/s | 93379101.055op/s ± 215960.270op/s | 93590848.681op/s | 93834910.343op/s | 93955105.777op/s | 94026044.497op/s | 0.69% | -0.991 | 1.481 | 0.40% | 26765.856op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | [206.381µs; 206.489µs] or [-0.026%; +0.026%] | None | None | None |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | [4842893.915op/s; 4845429.514op/s] or [-0.026%; +0.026%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | execution_time | [18.825µs; 18.882µs] or [-0.150%; +0.150%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | throughput | [52967921.583op/s; 53125472.834op/s] or [-0.149%; +0.149%] | None | None | None |
| normalization/normalize_name/normalize_name/good | execution_time | [10.710µs; 10.722µs] or [-0.056%; +0.056%] | None | None | None |
| normalization/normalize_name/normalize_name/good | throughput | [93265468.378op/s; 93370388.604op/s] or [-0.056%; +0.056%] | None | None | None |
Group 11
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | 493.211µs | 494.164µs ± 0.550µs | 494.075µs ± 0.290µs | 494.415µs | 495.085µs | 495.474µs | 498.321µs | 0.86% | 2.561 | 15.254 | 0.11% | 0.039µs | 1 | 200 |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | 2006738.628op/s | 2023621.377op/s ± 2247.824op/s | 2023984.441op/s ± 1189.712op/s | 2024992.115op/s | 2026234.252op/s | 2026939.764op/s | 2027528.658op/s | 0.18% | -2.526 | 14.911 | 0.11% | 158.945op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | 370.034µs | 370.667µs ± 0.277µs | 370.640µs ± 0.172µs | 370.846µs | 371.160µs | 371.366µs | 371.403µs | 0.21% | 0.257 | -0.047 | 0.07% | 0.020µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | 2692490.539op/s | 2697842.925op/s ± 2012.822op/s | 2698038.362op/s ± 1252.069op/s | 2699081.778op/s | 2701111.555op/s | 2702028.796op/s | 2702455.957op/s | 0.16% | -0.253 | -0.050 | 0.07% | 142.328op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | 167.324µs | 167.590µs ± 0.153µs | 167.566µs ± 0.094µs | 167.664µs | 167.899µs | 168.016µs | 168.136µs | 0.34% | 1.019 | 0.921 | 0.09% | 0.011µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | 5947553.916op/s | 5966934.826op/s ± 5433.198op/s | 5967811.429op/s ± 3349.254op/s | 5971088.959op/s | 5973113.419op/s | 5975901.460op/s | 5976423.980op/s | 0.14% | -1.014 | 0.908 | 0.09% | 384.185op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | 37.040µs | 37.162µs ± 0.066µs | 37.151µs ± 0.035µs | 37.192µs | 37.272µs | 37.335µs | 37.518µs | 0.99% | 1.381 | 4.270 | 0.18% | 0.005µs | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | throughput | 26653626.249op/s | 26909340.262op/s ± 47488.088op/s | 26917122.575op/s ± 25226.663op/s | 26938849.432op/s | 26975105.524op/s | 26988663.839op/s | 26997960.225op/s | 0.30% | -1.358 | 4.144 | 0.18% | 3357.915op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | 45.403µs | 45.623µs ± 0.092µs | 45.630µs ± 0.068µs | 45.693µs | 45.760µs | 45.798µs | 45.898µs | 0.59% | -0.163 | -0.445 | 0.20% | 0.006µs | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | 21787510.286op/s | 21918629.998op/s ± 44045.697op/s | 21915337.158op/s ± 32680.674op/s | 21950436.530op/s | 21993940.075op/s | 22016675.603op/s | 22025046.393op/s | 0.50% | 0.172 | -0.447 | 0.20% | 3114.501op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | [494.088µs; 494.240µs] or [-0.015%; +0.015%] | None | None | None |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | [2023309.851op/s; 2023932.904op/s] or [-0.015%; +0.015%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | [370.628µs; 370.705µs] or [-0.010%; +0.010%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | [2697563.967op/s; 2698121.882op/s] or [-0.010%; +0.010%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | [167.569µs; 167.612µs] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | [5966181.837op/s; 5967687.815op/s] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | [37.153µs; 37.171µs] or [-0.025%; +0.025%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | throughput | [26902758.870op/s; 26915921.654op/s] or [-0.024%; +0.024%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | [45.611µs; 45.636µs] or [-0.028%; +0.028%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | [21912525.688op/s; 21924734.308op/s] or [-0.028%; +0.028%] | None | None | None |
Group 12
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | 724.774µs | 726.191µs ± 0.725µs | 726.143µs ± 0.510µs | 726.685µs | 727.434µs | 728.002µs | 728.670µs | 0.35% | 0.349 | 0.057 | 0.10% | 0.051µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | [726.090µs; 726.291µs] or [-0.014%; +0.014%] | None | None | None |
Group 13
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | 48.432ms | 48.796ms ± 1.328ms | 48.638ms ± 0.060ms | 48.699ms | 48.830ms | 52.383ms | 62.489ms | 28.48% | 9.178 | 85.985 | 2.72% | 0.094ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | [48.612ms; 48.981ms] or [-0.377%; +0.377%] | None | None | None |
Group 14
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | 33.071µs | 34.013µs ± 1.317µs | 33.204µs ± 0.078µs | 35.307µs | 36.350µs | 36.984µs | 38.285µs | 15.30% | 1.075 | -0.488 | 3.86% | 0.093µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | [33.830µs; 34.195µs] or [-0.537%; +0.537%] | None | None | None |
Group 15
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | 3.397ms | 3.448ms ± 0.039ms | 3.435ms ± 0.016ms | 3.457ms | 3.536ms | 3.572ms | 3.602ms | 4.85% | 1.621 | 2.179 | 1.14% | 0.003ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | [3.443ms; 3.454ms] or [-0.158%; +0.158%] | None | None | None |
Group 16
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 10.651ms | 10.682ms ± 0.015ms | 10.681ms ± 0.009ms | 10.690ms | 10.707ms | 10.732ms | 10.747ms | 0.62% | 0.965 | 2.087 | 0.14% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [10.680ms; 10.684ms] or [-0.020%; +0.020%] | None | None | None |
Group 17
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | 88.264µs | 88.497µs ± 0.219µs | 88.459µs ± 0.085µs | 88.575µs | 88.685µs | 88.812µs | 90.871µs | 2.73% | 7.071 | 70.116 | 0.25% | 0.015µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | [88.466µs; 88.527µs] or [-0.034%; +0.034%] | None | None | None |
Group 18
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 18.358µs | 26.667µs ± 10.037µs | 18.551µs ± 0.154µs | 35.368µs | 44.043µs | 45.124µs | 73.064µs | 293.85% | 0.886 | 0.585 | 37.54% | 0.710µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [25.276µs; 28.058µs] or [-5.216%; +5.216%] | None | None | None |
Group 19
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 5755181 | 1773162517 | oscarld/memcached-fuzzing-fixes |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | 163.957µs | 164.795µs ± 0.310µs | 164.770µs ± 0.133µs | 164.905µs | 165.111µs | 165.651µs | 167.884µs | 1.89% | 5.105 | 48.139 | 0.19% | 0.022µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | [164.752µs; 164.838µs] or [-0.026%; +0.026%] | None | None | None |
Baseline
Omitted due to size.
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
=======================================
Coverage 71.19% 71.19%
=======================================
Files 429 429
Lines 63504 63503 -1
=======================================
Hits 45212 45212
+ Misses 18292 18291 -1
🚀 New features to boost your workflow:
|
# What does this PR do? Bump to 29.0.0 [feat(profiling)!: add Tracepoint sample type](#1676) [feat(obfuscation/redis): Reach feature parity on redis obfuscation [APMSP-2668]](#1632) [fix(sidecar): Handle backpressure more gracefully](#1682) [feat(trace-protobuf)!: Add two fields to ClientGroupedStats [SVLS-8627]](#1630) [chore: exclude libdatadog from ADMS auto generated PRs for dependency updates](#1688) [chore(ci): run crashtracking ffi example tests in CI](#1687) [fix(crashtracking): use libunwind to unwind frames](#1663) [feat: publish tracer metadata as OTel process ctx](#1658) [ci: run thread count test in own process](#1693) [feat(obfuscation/json): Init json obfuscation [APMSP-2665]](#1635) [chore(ci): add final_status property on junit XML [APMSP-2610]](#1681) [refactor(data-pipeline-ffi): move macro definitions for better reuse](#1699) [fix(obfuscation/memcached): fuzzing fix](#1695) [ci: replace use of cargo cross for centos7 tests](#1675) #1702 (comment) [feat(stats_exporter)!: add process tags to CSS payloads](#1709) # Motivation I mainly am creating this to use the new unwinding from ucontext for crashtracking # Additional Notes Anything else we should know when reviewing? # How to test the change? Describe here in detail how the change can be validated. [APMSP-2668]: https://datadoghq.atlassian.net/browse/APMSP-2668?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [SVLS-8627]: https://datadoghq.atlassian.net/browse/SVLS-8627?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [APMSP-2665]: https://datadoghq.atlassian.net/browse/APMSP-2665?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: gyuheon.oh <[email protected]>
What does this PR do?
Ran a fuzzer to find output difference between this obfuscator and the agent's obfuscator, fixed issues one by one, even the nonsensical edge cases.
This one fixes 1 fuzzing testcase: memcached_fuzzing_2126976840
Motivation
Reach 100% parity between obfuscation libs.
Additional Notes
How to test the change?