Skip to content

feat(profiling)!: add Tracepoint sample type#1676

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
r1viollet/add-tracepoint-sample-type
Mar 6, 2026
Merged

feat(profiling)!: add Tracepoint sample type#1676
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
r1viollet/add-tracepoint-sample-type

Conversation

@r1viollet
Copy link
Copy Markdown
Contributor

@r1viollet r1viollet commented Mar 6, 2026

What does this PR do?

ddprof uses "tracepoint"/"events" as the sample type for hardware counters and perf tracepoint events. The v28 enum-based SampleType API had no equivalent, causing those profiles to fall back to "sample"/"count" and breaking the Datadog backend rendering.

Add SampleType::Tracepoint mapping to ValueType::new("tracepoint", "events").

Motivation

Enable usage of libdatadog sample types in ddprof

Additional Notes

NA

How to test the change?

sample_type_round_trip_conversion already passes and automatically covers Tracepoint via EnumIter.

ddprof uses "tracepoint"/"events" as the sample type for hardware
counters and perf tracepoint events. The v28 enum-based SampleType API
had no equivalent, causing those profiles to fall back to "sample"/"count"
and breaking the Datadog backend rendering.

Add `SampleType::Tracepoint` mapping to `ValueType::new("tracepoint", "events")`.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/r1viollet/add-tracepoint-sample-type

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 27 27 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-crashtracker 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 219 219 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

Copy link
Copy Markdown
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@r1viollet r1viollet marked this pull request as ready for review March 6, 2026 08:54
@r1viollet r1viollet requested a review from a team as a code owner March 6, 2026 08:54
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.16%. Comparing base (29b010a) to head (e97cfc5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
- Coverage   71.17%   71.16%   -0.01%     
==========================================
  Files         427      427              
  Lines       62807    62810       +3     
==========================================
- Hits        44703    44699       -4     
- Misses      18104    18111       +7     
Components Coverage Δ
libdd-crashtracker 62.98% <ø> (-0.02%) ⬇️
libdd-crashtracker-ffi 16.56% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 88.02% <ø> (ø)
libdd-data-pipeline-ffi 75.72% <ø> (ø)
libdd-common 79.73% <ø> (ø)
libdd-common-ffi 73.40% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.74% <ø> (ø)
libdd-profiling 81.60% <66.66%> (-0.01%) ⬇️
libdd-profiling-ffi 63.65% <ø> (ø)
datadog-sidecar 32.00% <ø> (ø)
datdog-sidecar-ffi 6.43% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 94.67% <ø> (ø)
libdd-trace-protobuf 68.00% <ø> (ø)
libdd-trace-utils 89.07% <ø> (ø)
datadog-tracer-flare 88.95% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 6, 2026

Benchmarks

Comparison

Benchmark execution time: 2026-03-06 09:01:45

Comparing candidate commit e97cfc5 in PR branch r1viollet/add-tracepoint-sample-type with baseline commit 29b010a in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟩 execution_time [-2.668ms; -2.139ms] or [-5.242%; -4.202%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.923ms 14.013ms ± 0.110ms 13.977ms ± 0.015ms 13.994ms 14.346ms 14.391ms 14.446ms 3.35% 2.640 5.711 0.79% 0.008ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [13.997ms; 14.028ms] or [-0.109%; +0.109%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.921µs 5.008µs ± 0.046µs 5.014µs ± 0.037µs 5.027µs 5.085µs 5.091µs 5.092µs 1.57% 0.058 -0.874 0.91% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.002µs; 5.014µs] or [-0.126%; +0.126%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.142ms 4.147ms ± 0.007ms 4.146ms ± 0.002ms 4.148ms 4.152ms 4.171ms 4.224ms 1.90% 6.688 59.045 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.146ms; 4.148ms] or [-0.025%; +0.025%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.774µs 161.807µs ± 0.302µs 161.787µs ± 0.155µs 161.947µs 162.295µs 162.662µs 163.017µs 0.76% 0.454 3.002 0.19% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.765µs; 161.848µs] or [-0.026%; +0.026%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.788µs 534.649µs ± 0.825µs 534.563µs ± 0.255µs 534.822µs 535.232µs 535.879µs 545.002µs 1.95% 9.975 122.201 0.15% 0.058µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1834855.652op/s 1870389.853op/s ± 2843.834op/s 1870688.544op/s ± 894.028op/s 1871561.093op/s 1872379.670op/s 1873109.160op/s 1873402.098op/s 0.15% -9.861 120.274 0.15% 201.089op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.154µs 381.178µs ± 0.506µs 381.100µs ± 0.352µs 381.491µs 381.988µs 382.585µs 383.083µs 0.52% 0.700 0.690 0.13% 0.036µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2610402.135op/s 2623449.961op/s ± 3476.766op/s 2623983.656op/s ± 2425.868op/s 2626095.396op/s 2628152.276op/s 2629772.923op/s 2630511.393op/s 0.25% -0.691 0.667 0.13% 245.844op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.842µs 190.292µs ± 0.194µs 190.283µs ± 0.125µs 190.422µs 190.635µs 190.772µs 190.904µs 0.33% 0.310 0.086 0.10% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5238229.296op/s 5255075.694op/s ± 5349.516op/s 5255329.157op/s ± 3462.775op/s 5258499.404op/s 5262993.186op/s 5267044.078op/s 5267529.731op/s 0.23% -0.304 0.079 0.10% 378.268op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.442µs 37.613µs ± 0.068µs 37.607µs ± 0.047µs 37.657µs 37.725µs 37.765µs 37.842µs 0.63% 0.285 0.254 0.18% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26425390.270op/s 26586807.888op/s ± 47841.882op/s 26590857.400op/s ± 33218.337op/s 26620753.262op/s 26661222.283op/s 26693354.627op/s 26707732.986op/s 0.44% -0.273 0.240 0.18% 3382.932op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.693µs 45.900µs ± 0.146µs 45.904µs ± 0.059µs 45.957µs 46.008µs 46.062µs 47.621µs 3.74% 8.175 94.907 0.32% 0.010µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20999148.835op/s 21786712.312op/s ± 67544.628op/s 21784786.410op/s ± 28192.024op/s 21819319.072op/s 21854057.997op/s 21866134.862op/s 21885424.453op/s 0.46% -7.891 90.577 0.31% 4776.126op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.535µs; 534.764µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1869995.725op/s; 1870783.981op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.108µs; 381.248µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2622968.115op/s; 2623931.807op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.266µs; 190.319µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5254334.303op/s; 5255817.086op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.603µs; 37.622µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26580177.464op/s; 26593438.313op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.880µs; 45.920µs] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21777351.276op/s; 21796073.348op/s] or [-0.043%; +0.043%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.497µs 34.177µs ± 1.266µs 33.592µs ± 0.042µs 33.667µs 36.906µs 36.951µs 37.421µs 11.40% 1.705 0.930 3.69% 0.089µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.001µs; 34.352µs] or [-0.513%; +0.513%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 238.801ns 250.337ns ± 13.465ns 244.647ns ± 3.715ns 253.096ns 278.897ns 295.205ns 298.501ns 22.01% 1.869 2.851 5.37% 0.952ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [248.471ns; 252.203ns] or [-0.745%; +0.745%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 3.311ms 3.339ms ± 0.014ms 3.337ms ± 0.010ms 3.348ms 3.365ms 3.381ms 3.383ms 1.36% 0.629 0.079 0.43% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [3.337ms; 3.341ms] or [-0.059%; +0.059%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.832µs 25.930µs ± 9.561µs 18.290µs ± 0.216µs 34.114µs 43.480µs 44.324µs 64.107µs 250.51% 0.849 0.038 36.78% 0.676µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.604µs; 27.255µs] or [-5.110%; +5.110%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 711.602µs 712.677µs ± 0.519µs 712.638µs ± 0.290µs 712.922µs 713.649µs 714.192µs 714.728µs 0.29% 0.859 1.339 0.07% 0.037µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [712.605µs; 712.749µs] or [-0.010%; +0.010%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.588ms 10.626ms ± 0.017ms 10.625ms ± 0.009ms 10.634ms 10.649ms 10.670ms 10.726ms 0.96% 1.574 7.931 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.623ms; 10.628ms] or [-0.022%; +0.022%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 90.698µs 91.042µs ± 0.178µs 91.030µs ± 0.059µs 91.094µs 91.187µs 91.352µs 92.929µs 2.09% 6.484 63.686 0.20% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [91.018µs; 91.067µs] or [-0.027%; +0.027%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 189.052ns 191.653ns ± 2.060ns 191.366ns ± 1.433ns 192.625ns 195.734ns 197.813ns 200.255ns 4.65% 1.228 1.757 1.07% 0.146ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [191.368ns; 191.939ns] or [-0.149%; +0.149%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.918µs 3.919µs 3.919µs 0.16% -1.341 8.566 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255152131.464op/s 255559948.446op/s ± 199156.372op/s 255562061.822op/s ± 136066.461op/s 255695425.534op/s 255837723.135op/s 255876281.670op/s 256902547.295op/s 0.52% 1.362 8.728 0.08% 14082.482op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.037µs 79.614µs ± 0.359µs 79.569µs ± 0.264µs 79.852µs 80.254µs 80.593µs 80.810µs 1.56% 0.767 0.193 0.45% 0.025µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12374661.133op/s 12560904.014op/s ± 56516.920op/s 12567683.459op/s ± 41811.498op/s 12607539.314op/s 12633267.817op/s 12649673.942op/s 12652350.365op/s 0.67% -0.746 0.138 0.45% 3996.350op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 72.273µs 72.851µs ± 0.324µs 72.794µs ± 0.218µs 73.052µs 73.383µs 73.745µs 73.941µs 1.58% 0.682 0.124 0.44% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13524322.907op/s 13727008.374op/s ± 60862.642op/s 13737411.787op/s ± 41065.958op/s 13773740.736op/s 13807930.171op/s 13820828.570op/s 13836464.619op/s 0.72% -0.660 0.071 0.44% 4303.639op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.918µs 3.919µs 0.20% -1.135 9.323 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255137371.069op/s 255635581.857op/s ± 164320.364op/s 255648972.467op/s ± 91305.307op/s 255727209.375op/s 255856477.987op/s 255924045.652op/s 256744049.678op/s 0.43% 1.154 9.457 0.06% 11619.204op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 69.186µs 69.703µs ± 0.357µs 69.638µs ± 0.233µs 69.882µs 70.329µs 70.941µs 71.124µs 2.13% 1.123 1.458 0.51% 0.025µs 1 200
credit_card/is_card_number/378282246310005 throughput 14060029.883op/s 14346898.476op/s ± 72995.952op/s 14359947.047op/s ± 48285.098op/s 14404441.717op/s 14429987.470op/s 14447109.467op/s 14453760.763op/s 0.65% -1.090 1.330 0.51% 5161.593op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.153µs 52.231µs ± 0.040µs 52.224µs ± 0.030µs 52.259µs 52.305µs 52.325µs 52.338µs 0.22% 0.419 -0.404 0.08% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19106528.950op/s 19145759.382op/s ± 14517.444op/s 19148355.927op/s ± 11024.945op/s 19156486.520op/s 19165418.303op/s 19172356.778op/s 19174505.577op/s 0.14% -0.416 -0.408 0.08% 1026.538op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.028µs 6.037µs ± 0.010µs 6.034µs ± 0.002µs 6.037µs 6.055µs 6.072µs 6.107µs 1.20% 3.756 16.999 0.16% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163754482.124op/s 165651169.175op/s ± 267386.793op/s 165717814.666op/s ± 58181.041op/s 165772703.767op/s 165838755.634op/s 165873060.872op/s 165900042.271op/s 0.11% -3.733 16.752 0.16% 18907.101op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.896µs 3.912µs ± 0.002µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.919µs 3.920µs 0.21% -0.591 9.560 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255123760.476op/s 255640121.352op/s ± 157223.885op/s 255656142.089op/s ± 79897.901op/s 255728912.947op/s 255822307.027op/s 255860755.116op/s 256681604.947op/s 0.40% 0.612 9.680 0.06% 11117.408op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.112µs 64.408µs ± 0.126µs 64.389µs ± 0.084µs 64.492µs 64.614µs 64.747µs 64.791µs 0.62% 0.514 0.239 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15434276.005op/s 15525960.135op/s ± 30323.975op/s 15530702.008op/s ± 20278.005op/s 15548119.037op/s 15570632.154op/s 15582498.262op/s 15597811.627op/s 0.43% -0.503 0.222 0.19% 2144.229op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.133µs 58.402µs ± 0.144µs 58.384µs ± 0.086µs 58.473µs 58.670µs 58.827µs 58.863µs 0.82% 0.894 0.740 0.25% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16988703.006op/s 17122711.435op/s ± 42044.288op/s 17128082.616op/s ± 25216.631op/s 17152517.971op/s 17180134.982op/s 17186644.815op/s 17201811.351op/s 0.43% -0.880 0.706 0.24% 2972.980op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.894µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.918µs 3.920µs 3.920µs 0.17% -1.057 5.715 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255093973.248op/s 255535651.746op/s ± 203846.045op/s 255529153.246op/s ± 131475.023op/s 255660001.997op/s 255816692.075op/s 255922821.765op/s 256790357.537op/s 0.49% 1.073 5.821 0.08% 14414.092op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.611µs 55.051µs ± 0.330µs 55.024µs ± 0.212µs 55.225µs 55.561µs 56.053µs 56.401µs 2.50% 1.132 1.721 0.60% 0.023µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17730057.728op/s 18165612.388op/s ± 108177.055op/s 18173964.917op/s ± 70316.727op/s 18254952.429op/s 18295297.368op/s 18308187.161op/s 18311336.589op/s 0.76% -1.089 1.565 0.59% 7649.273op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.155µs 52.226µs ± 0.039µs 52.219µs ± 0.023µs 52.246µs 52.300µs 52.322µs 52.452µs 0.45% 1.352 4.679 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19065186.255op/s 19147694.948op/s ± 14336.808op/s 19150141.649op/s ± 8541.634op/s 19157929.666op/s 19165849.723op/s 19170489.507op/s 19173712.840op/s 0.12% -1.341 4.610 0.07% 1013.765op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.039µs ± 0.011µs 6.037µs ± 0.002µs 6.039µs 6.061µs 6.076µs 6.113µs 1.27% 4.263 21.802 0.18% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163575384.758op/s 165585678.267op/s ± 296766.284op/s 165648475.043op/s ± 59014.283op/s 165708691.423op/s 165783471.984op/s 165823862.500op/s 165896653.894op/s 0.15% -4.233 21.486 0.18% 20984.545op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255532347.288op/s; 255587549.604op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.564µs; 79.664µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12553071.312op/s; 12568736.715op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [72.806µs; 72.895µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13718573.397op/s; 13735443.350op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255612808.635op/s; 255658355.079op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [69.654µs; 69.753µs] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/378282246310005 throughput [14336781.939op/s; 14357015.013op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.225µs; 52.236µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19143747.404op/s; 19147771.360op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.035µs; 6.038µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/x371413321323331 throughput [165614111.937op/s; 165688226.413op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255618331.634op/s; 255661911.070op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.391µs; 64.426µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15521757.523op/s; 15530162.746op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.382µs; 58.422µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17116884.501op/s; 17128538.369op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255507400.645op/s; 255563902.848op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.005µs; 55.097µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18150620.089op/s; 18180604.688op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.220µs; 52.231µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19145708.005op/s; 19149681.892op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.038µs; 6.041µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165544549.314op/s; 165626807.219op/s] or [-0.025%; +0.025%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.220µs 185.672µs ± 0.213µs 185.672µs ± 0.152µs 185.808µs 186.055µs 186.198µs 186.249µs 0.31% 0.385 -0.283 0.11% 0.015µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5369146.975op/s 5385848.198op/s ± 6163.333op/s 5385833.722op/s ± 4408.350op/s 5390811.604op/s 5395187.576op/s 5396661.585op/s 5398986.448op/s 0.24% -0.379 -0.289 0.11% 435.813op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.870µs 17.968µs ± 0.048µs 17.965µs ± 0.029µs 17.991µs 18.044µs 18.081µs 18.229µs 1.47% 1.278 4.579 0.27% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54857442.104op/s 55655394.324op/s ± 148189.425op/s 55662879.408op/s ± 89915.142op/s 55757396.297op/s 55863531.319op/s 55902377.880op/s 55958814.313op/s 0.53% -1.239 4.366 0.27% 10478.575op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.258µs 10.327µs ± 0.036µs 10.323µs ± 0.023µs 10.347µs 10.391µs 10.422µs 10.450µs 1.23% 0.577 0.370 0.34% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 95691682.859op/s 96835122.819op/s ± 333209.700op/s 96873321.124op/s ± 213122.125op/s 97068620.356op/s 97356051.204op/s 97449485.927op/s 97482423.398op/s 0.63% -0.556 0.330 0.34% 23561.484op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.643µs; 185.701µs] or [-0.016%; +0.016%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5384994.019op/s; 5386702.377op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.961µs; 17.974µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55634856.695op/s; 55675931.953op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.322µs; 10.332µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/good throughput [96788943.159op/s; 96881302.479op/s] or [-0.048%; +0.048%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.214µs 3.204µs ± 1.411µs 2.985µs ± 0.029µs 3.011µs 3.670µs 13.931µs 14.590µs 388.85% 7.306 54.673 43.92% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.008µs; 3.399µs] or [-6.103%; +6.103%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.272µs 146.422µs ± 1.771µs 146.176µs ± 0.565µs 146.746µs 148.056µs 153.755µs 163.945µs 12.16% 5.952 50.194 1.21% 0.125µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.176µs; 146.667µs] or [-0.168%; +0.168%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 48.128ms 48.502ms ± 1.441ms 48.306ms ± 0.051ms 48.370ms 48.590ms 56.948ms 62.230ms 28.83% 8.308 69.252 2.96% 0.102ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [48.302ms; 48.702ms] or [-0.412%; +0.412%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz e97cfc5 1772786654 r1viollet/add-tracepoint-sample-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.401µs 2.434µs ± 0.021µs 2.428µs ± 0.008µs 2.438µs 2.493µs 2.500µs 2.502µs 3.01% 1.771 3.100 0.86% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.431µs; 2.437µs] or [-0.120%; +0.120%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Mar 6, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 98.65 MB 98.65 MB +0% (+336 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.70 MB 8.70 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 114.29 MB 114.29 MB +0% (+336 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.29 MB 11.29 MB +0% (+48 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.16 MB 27.16 MB +0% (+512 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.01 MB 186.01 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.19 MB 917.19 MB +0% (+1.58 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.93 MB 9.93 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.76 MB 24.76 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.43 MB 51.43 MB +0% (+400 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.97 MB 22.97 MB +0% (+512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.23 MB 190.23 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 900.84 MB 900.84 MB +0% (+1.53 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.53 MB 7.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.52 MB 26.52 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.06 MB 47.06 MB +0% (+386 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 86.54 MB 86.54 MB +0% (+480 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.23 MB 10.23 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 107.16 MB 107.16 MB +0% (+528 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.98 MB 11.98 MB 0% (0 B) 👌

@r1viollet
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 6, 2026

View all feedbacks in Devflow UI.

2026-03-06 10:12:39 UTC ℹ️ Start processing command /merge


2026-03-06 10:12:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 48m (p90).


2026-03-06 10:48:45 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit b70ded5 into main Mar 6, 2026
90 of 92 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the r1viollet/add-tracepoint-sample-type branch March 6, 2026 10:48
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Mar 11, 2026
# What does this PR do?

Bump to 29.0.0

[feat(profiling)!: add Tracepoint sample type](#1676)
[feat(obfuscation/redis): Reach feature parity on redis obfuscation [APMSP-2668]](#1632)
[fix(sidecar): Handle backpressure more gracefully](#1682)
[feat(trace-protobuf)!: Add two fields to ClientGroupedStats [SVLS-8627]](#1630)
[chore: exclude libdatadog from ADMS auto generated PRs for dependency updates](#1688)
[chore(ci): run crashtracking ffi example tests in CI](#1687)
[fix(crashtracking): use libunwind to unwind frames](#1663)
[feat: publish tracer metadata as OTel process ctx](#1658)
[ci: run thread count test in own process](#1693)
[feat(obfuscation/json): Init json obfuscation [APMSP-2665]](#1635)
[chore(ci): add final_status property on junit XML [APMSP-2610]](#1681)
[refactor(data-pipeline-ffi): move macro definitions for better reuse](#1699)
[fix(obfuscation/memcached): fuzzing fix](#1695)
[ci: replace use of cargo cross for centos7 tests](#1675)
#1702 (comment)
[feat(stats_exporter)!: add process tags to CSS payloads](#1709)

# Motivation

I mainly am creating this to use the new unwinding from ucontext for crashtracking

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?

Describe here in detail how the change can be validated.


[APMSP-2668]: https://datadoghq.atlassian.net/browse/APMSP-2668?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[SVLS-8627]: https://datadoghq.atlassian.net/browse/SVLS-8627?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-2665]: https://datadoghq.atlassian.net/browse/APMSP-2665?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: gyuheon.oh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants