Skip to content

fix(sidecar): Cleanup limiters on sidecar shutdown#1659

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
bob/cleanup-limiters
Mar 5, 2026
Merged

fix(sidecar): Cleanup limiters on sidecar shutdown#1659
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
bob/cleanup-limiters

Conversation

@bwoebi

@bwoebi bwoebi commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Not really a big problem, just not nice.

@bwoebi
bwoebi requested review from a team as code owners March 5, 2026 12:23
@bwoebi
bwoebi force-pushed the bob/cleanup-limiters branch from 6da75be to 46e22a6 Compare March 5, 2026 12:23
@bwoebi bwoebi changed the title Cleanup limiters on sidecar shutdown fix(sidecar): Cleanup limiters on sidecar shutdown Mar 5, 2026
@github-actions

github-actions Bot commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/bob/cleanup-limiters

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 4 4 No change (0%)
Total 4 4 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
datadog-sidecar/src/service/exception_hash_rate_limiter.rs 2 2 No change (0%)
datadog-sidecar/src/tracer.rs 2 2 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 27 27 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-crashtracker 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 219 219 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@bwoebi
bwoebi force-pushed the bob/cleanup-limiters branch from 46e22a6 to 888811e Compare March 5, 2026 12:27
@bwoebi

bwoebi commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-05 12:28:14 UTC ℹ️ Start processing command /merge

2026-03-05 12:28:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-03-05 13:24:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 48m (p90).

2026-03-05 14:08:12 UTC ℹ️ MergeQueue: This merge request was merged

@codecov-commenter

codecov-commenter commented Mar 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.21%. Comparing base (19ae2be) to head (888811e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1659      +/-   ##
==========================================
- Coverage   71.22%   71.21%   -0.02%     
==========================================
  Files         425      425              
  Lines       62695    62709      +14     
==========================================
  Hits        44657    44657              
- Misses      18038    18052      +14
Components Coverage Δ
libdd-crashtracker 62.89% <ø> (ø)
libdd-crashtracker-ffi 15.63% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 87.38% <ø> (ø)
libdd-data-pipeline-ffi 72.83% <ø> (ø)
libdd-common 79.73% <ø> (ø)
libdd-common-ffi 73.40% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.74% <ø> (ø)
libdd-profiling 81.60% <ø> (ø)
libdd-profiling-ffi 63.65% <ø> (ø)
datadog-sidecar 33.36% <0.00%> (-0.09%) ⬇️
datdog-sidecar-ffi 12.41% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 94.67% <ø> (ø)
libdd-trace-protobuf 68.00% <ø> (ø)
libdd-trace-utils 88.97% <ø> (ø)
datadog-tracer-flare 90.45% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-03-05 12:44:29

Comparing candidate commit 888811e in PR branch bob/cleanup-limiters with baseline commit 19ae2be in branch main.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-10.501µs; -10.337µs] or [-12.598%; -12.402%]
  • 🟩 throughput [+1701054.748op/s; +1726634.325op/s] or [+14.178%; +14.391%]

scenario:tags/replace_trace_tags

  • 🟩 execution_time [-189.546ns; -181.130ns] or [-7.350%; -7.023%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.778µs 25.525µs ± 9.765µs 18.023µs ± 0.183µs 34.541µs 42.728µs 48.560µs 55.670µs 208.89% 0.772 -0.814 38.16% 0.690µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.171µs; 26.878µs] or [-5.302%; +5.302%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.339µs 185.859µs ± 0.348µs 185.793µs ± 0.188µs 186.019µs 186.442µs 186.846µs 187.662µs 1.01% 1.757 5.863 0.19% 0.025µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5328720.083op/s 5380431.238op/s ± 10049.124op/s 5382340.984op/s ± 5465.951op/s 5387308.961op/s 5393136.530op/s 5394181.746op/s 5395526.488op/s 0.24% -1.731 5.701 0.19% 710.580op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.921µs 18.025µs ± 0.041µs 18.024µs ± 0.027µs 18.052µs 18.094µs 18.113µs 18.153µs 0.72% 0.006 -0.008 0.23% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55086038.374op/s 55478415.284op/s ± 127339.961op/s 55481903.464op/s ± 84768.023op/s 55563104.056op/s 55679357.663op/s 55781769.119op/s 55799541.787op/s 0.57% 0.007 -0.011 0.23% 9004.295op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.288µs 10.413µs ± 0.048µs 10.415µs ± 0.033µs 10.444µs 10.492µs 10.527µs 10.561µs 1.40% 0.180 -0.069 0.46% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 94687391.728op/s 96033020.062op/s ± 442431.353op/s 96016759.401op/s ± 302219.198op/s 96350312.227op/s 96733092.663op/s 96848705.491op/s 97199047.449op/s 1.23% -0.154 -0.095 0.46% 31284.621op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.811µs; 185.908µs] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5379038.526op/s; 5381823.950op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.019µs; 18.031µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55460767.190op/s; 55496063.378op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.407µs; 10.420µs] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/good throughput [95971703.332op/s; 96094336.793op/s] or [-0.064%; +0.064%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.929µs 5.007µs ± 0.049µs 5.004µs ± 0.038µs 5.041µs 5.093µs 5.097µs 5.101µs 1.93% 0.382 -1.038 0.97% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.000µs; 5.013µs] or [-0.135%; +0.135%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.100µs 535.213µs ± 0.845µs 535.022µs ± 0.342µs 535.392µs 536.919µs 537.635µs 541.408µs 1.19% 2.888 14.569 0.16% 0.060µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1847036.278op/s 1868420.894op/s ± 2935.420op/s 1869083.047op/s ± 1195.173op/s 1870192.317op/s 1871312.668op/s 1871917.841op/s 1872307.938op/s 0.17% -2.849 14.190 0.16% 207.566op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.228µs 381.055µs ± 0.441µs 380.947µs ± 0.229µs 381.319µs 381.904µs 382.176µs 382.520µs 0.41% 0.921 0.313 0.12% 0.031µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2614240.015op/s 2624298.081op/s ± 3031.526op/s 2625039.176op/s ± 1578.949op/s 2626473.102op/s 2627909.045op/s 2628577.799op/s 2630003.653op/s 0.19% -0.916 0.302 0.12% 214.361op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.654µs 190.169µs ± 0.581µs 190.118µs ± 0.137µs 190.252µs 190.443µs 190.687µs 195.766µs 2.97% 8.322 75.708 0.30% 0.041µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5108133.288op/s 5258524.752op/s ± 15673.525op/s 5259886.262op/s ± 3776.236op/s 5263818.714op/s 5268107.107op/s 5271146.225op/s 5272766.997op/s 0.24% -8.244 74.742 0.30% 1108.286op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.300µs 37.510µs ± 0.065µs 37.508µs ± 0.034µs 37.543µs 37.608µs 37.641µs 37.880µs 0.99% 0.691 5.098 0.17% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26398939.517op/s 26659537.177op/s ± 46274.039op/s 26661158.812op/s ± 24490.037op/s 26683821.611op/s 26727452.751op/s 26779609.513op/s 26809758.433op/s 0.56% -0.657 4.952 0.17% 3272.069op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.770µs 45.961µs ± 0.065µs 45.960µs ± 0.031µs 45.997µs 46.049µs 46.093µs 46.276µs 0.69% 0.275 3.537 0.14% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21609468.405op/s 21757806.591op/s ± 30816.152op/s 21757855.856op/s ± 14484.413op/s 21771465.531op/s 21812410.915op/s 21846357.689op/s 21848207.876op/s 0.42% -0.251 3.476 0.14% 2179.031op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [535.096µs; 535.330µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1868014.073op/s; 1868827.715op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.994µs; 381.116µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2623877.941op/s; 2624718.222op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.089µs; 190.250µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5256352.553op/s; 5260696.952op/s] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.501µs; 37.519µs] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26653124.041op/s; 26665950.314op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.952µs; 45.970µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21753535.768op/s; 21762077.413op/s] or [-0.020%; +0.020%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.507µs 34.067µs ± 0.954µs 33.618µs ± 0.040µs 33.742µs 36.007µs 36.068µs 38.659µs 14.99% 1.900 2.640 2.79% 0.067µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.935µs; 34.199µs] or [-0.388%; +0.388%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 239.978ns 251.255ns ± 13.762ns 244.469ns ± 3.095ns 258.096ns 285.044ns 288.999ns 290.356ns 18.77% 1.474 1.045 5.46% 0.973ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [249.348ns; 253.163ns] or [-0.759%; +0.759%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 723.702µs 725.611µs ± 0.703µs 725.551µs ± 0.432µs 726.013µs 726.954µs 727.540µs 727.960µs 0.33% 0.447 0.542 0.10% 0.050µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [725.514µs; 725.709µs] or [-0.013%; +0.013%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.891µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.921µs 3.926µs 0.37% -0.636 15.676 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254699058.171op/s 255629884.953op/s ± 189565.549op/s 255643362.214op/s ± 82285.698op/s 255720949.948op/s 255838221.718op/s 255898959.910op/s 256997425.804op/s 0.53% 0.674 15.868 0.07% 13404.309op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.113µs 79.669µs ± 0.363µs 79.626µs ± 0.254µs 79.884µs 80.279µs 80.742µs 80.783µs 1.45% 0.823 0.356 0.46% 0.026µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12378834.786op/s 12552120.360op/s ± 57055.926op/s 12558714.491op/s ± 40087.627op/s 12598118.472op/s 12625913.615op/s 12636217.561op/s 12640143.833op/s 0.65% -0.801 0.299 0.45% 4034.463op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 72.398µs 72.930µs ± 0.309µs 72.883µs ± 0.221µs 73.126µs 73.439µs 73.836µs 73.997µs 1.53% 0.836 0.743 0.42% 0.022µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13514003.151op/s 13712033.977op/s ± 57863.955op/s 13720682.144op/s ± 41469.588op/s 13753387.021op/s 13790677.503op/s 13798246.273op/s 13812586.028op/s 0.67% -0.810 0.673 0.42% 4091.599op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.913µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.917µs 3.921µs 3.928µs 0.40% 0.104 9.547 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254588950.899op/s 255577340.773op/s ± 203434.653op/s 255599808.301op/s ± 89466.880op/s 255674727.336op/s 255830462.345op/s 255907911.770op/s 256826423.219op/s 0.48% -0.076 9.627 0.08% 14385.002op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 69.176µs 69.627µs ± 0.279µs 69.534µs ± 0.160µs 69.807µs 70.181µs 70.406µs 70.499µs 1.39% 0.885 0.134 0.40% 0.020µs 1 200
credit_card/is_card_number/378282246310005 throughput 14184644.472op/s 14362413.957op/s ± 57362.206op/s 14381401.255op/s ± 33006.605op/s 14407624.155op/s 14432750.509op/s 14441786.334op/s 14455800.837op/s 0.52% -0.869 0.094 0.40% 4056.121op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.144µs 52.217µs ± 0.107µs 52.204µs ± 0.018µs 52.224µs 52.274µs 52.344µs 53.276µs 2.05% 8.711 80.434 0.21% 0.008µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18770240.331op/s 19150769.550op/s ± 38708.446op/s 19155564.837op/s ± 6644.996op/s 19161939.120op/s 19169330.413op/s 19174477.663op/s 19177625.464op/s 0.12% -8.671 79.906 0.20% 2737.100op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.038µs ± 0.013µs 6.035µs ± 0.002µs 6.038µs 6.069µs 6.109µs 6.147µs 1.86% 4.901 29.277 0.22% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 162678695.913op/s 165623850.219op/s ± 363398.719op/s 165707872.241op/s ± 66325.160op/s 165765975.655op/s 165844530.408op/s 165913097.398op/s 165917132.262op/s 0.13% -4.854 28.687 0.22% 25696.170op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.901µs 3.913µs ± 0.003µs 3.912µs ± 0.002µs 3.915µs 3.918µs 3.920µs 3.922µs 0.24% 0.237 1.184 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254991546.856op/s 255570094.537op/s ± 176567.279op/s 255600962.382op/s ± 118035.368op/s 255699304.833op/s 255791972.476op/s 255863222.672op/s 256313050.628op/s 0.28% -0.230 1.193 0.07% 12485.192op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.126µs 64.433µs ± 0.127µs 64.416µs ± 0.084µs 64.516µs 64.688µs 64.736µs 64.817µs 0.62% 0.414 -0.012 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15427946.003op/s 15519979.572op/s ± 30567.671op/s 15524180.678op/s ± 20323.433op/s 15540639.420op/s 15565244.678op/s 15582890.771op/s 15594183.370op/s 0.45% -0.403 -0.021 0.20% 2161.461op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.163µs 58.398µs ± 0.127µs 58.370µs ± 0.076µs 58.464µs 58.644µs 58.758µs 58.807µs 0.75% 0.957 0.624 0.22% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17004911.157op/s 17123971.990op/s ± 37187.562op/s 17132102.054op/s ± 22397.352op/s 17149782.009op/s 17170978.728op/s 17181227.346op/s 17193038.539op/s 0.36% -0.946 0.599 0.22% 2629.558op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.896µs 3.912µs ± 0.002µs 3.912µs ± 0.001µs 3.913µs 3.915µs 3.917µs 3.918µs 0.17% -1.296 11.316 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255207143.964op/s 255648988.459op/s ± 148839.435op/s 255651911.876op/s ± 84770.995op/s 255739850.662op/s 255838119.327op/s 255859361.545op/s 256700283.997op/s 0.41% 1.316 11.468 0.06% 10524.537op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.570µs 54.968µs ± 0.267µs 54.947µs ± 0.188µs 55.103µs 55.487µs 55.650µs 55.830µs 1.61% 0.752 0.022 0.48% 0.019µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17911499.478op/s 18192837.261op/s ± 88064.544op/s 18199239.348op/s ± 62148.751op/s 18271837.568op/s 18304885.633op/s 18312806.301op/s 18325221.738op/s 0.69% -0.730 -0.025 0.48% 6227.104op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.154µs 52.227µs ± 0.038µs 52.223µs ± 0.024µs 52.248µs 52.300µs 52.334µs 52.353µs 0.25% 0.756 0.875 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19100938.712op/s 19147204.606op/s ± 13863.884op/s 19148583.182op/s ± 8856.650op/s 19157304.594op/s 19167902.676op/s 19171615.369op/s 19173802.833op/s 0.13% -0.751 0.864 0.07% 980.325op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.039µs ± 0.013µs 6.035µs ± 0.003µs 6.039µs 6.071µs 6.083µs 6.115µs 1.32% 3.209 11.611 0.22% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163536044.292op/s 165584209.906op/s ± 356083.441op/s 165690069.125op/s ± 73342.006op/s 165746880.743op/s 165824628.533op/s 165855747.578op/s 165879174.651op/s 0.11% -3.187 11.424 0.21% 25178.902op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255603612.991op/s; 255656156.915op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.619µs; 79.720µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12544212.957op/s; 12560027.762op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [72.887µs; 72.973µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13704014.589op/s; 13720053.364op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255549146.686op/s; 255605534.859op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [69.589µs; 69.666µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/378282246310005 throughput [14354464.107op/s; 14370363.807op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.203µs; 52.232µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19145404.931op/s; 19156134.168op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.036µs; 6.040µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/x371413321323331 throughput [165573486.651op/s; 165674213.786op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255545624.011op/s; 255594565.064op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.416µs; 64.451µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15515743.187op/s; 15524215.958op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.380µs; 58.416µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17118818.151op/s; 17129125.828op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255628360.745op/s; 255669616.174op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.931µs; 55.005µs] or [-0.067%; +0.067%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18180632.363op/s; 18205042.160op/s] or [-0.067%; +0.067%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.222µs; 52.232µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19145283.205op/s; 19149126.007op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.037µs; 6.041µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165534860.166op/s; 165633559.646op/s] or [-0.030%; +0.030%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 188.326ns 191.860ns ± 1.952ns 191.626ns ± 1.392ns 192.896ns 195.484ns 197.223ns 199.241ns 3.97% 0.880 0.588 1.01% 0.138ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [191.590ns; 192.131ns] or [-0.141%; +0.141%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 162.227µs 163.525µs ± 0.274µs 163.514µs ± 0.131µs 163.656µs 163.984µs 164.284µs 164.764µs 0.76% 0.123 5.124 0.17% 0.019µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [163.487µs; 163.563µs] or [-0.023%; +0.023%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 47.542ms 48.098ms ± 1.374ms 47.954ms ± 0.134ms 48.064ms 48.302ms 50.590ms 63.745ms 32.93% 9.684 98.793 2.85% 0.097ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [47.908ms; 48.288ms] or [-0.396%; +0.396%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 3.274ms 3.298ms ± 0.013ms 3.296ms ± 0.007ms 3.304ms 3.326ms 3.347ms 3.351ms 1.66% 1.469 3.274 0.40% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [3.297ms; 3.300ms] or [-0.055%; +0.055%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.308µs 2.394µs ± 0.021µs 2.396µs ± 0.008µs 2.406µs 2.415µs 2.418µs 2.423µs 1.12% -2.354 5.973 0.88% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.391µs; 2.397µs] or [-0.123%; +0.123%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 90.471µs 90.692µs ± 0.172µs 90.671µs ± 0.056µs 90.735µs 90.844µs 91.419µs 92.351µs 1.85% 5.977 49.125 0.19% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [90.668µs; 90.715µs] or [-0.026%; +0.026%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 143.986µs 145.991µs ± 1.760µs 145.709µs ± 0.644µs 146.368µs 148.044µs 153.381µs 161.269µs 10.68% 4.894 33.652 1.20% 0.124µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [145.747µs; 146.235µs] or [-0.167%; +0.167%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.182µs 3.155µs ± 1.412µs 2.989µs ± 0.033µs 3.019µs 3.313µs 13.627µs 15.040µs 403.20% 7.529 57.266 44.66% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.959µs; 3.350µs] or [-6.205%; +6.205%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.136ms 4.142ms ± 0.008ms 4.141ms ± 0.002ms 4.142ms 4.147ms 4.171ms 4.228ms 2.12% 6.864 60.281 0.20% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.141ms; 4.143ms] or [-0.028%; +0.028%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.977ms 14.032ms ± 0.032ms 14.026ms ± 0.013ms 14.039ms 14.093ms 14.142ms 14.240ms 1.53% 2.626 10.291 0.23% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.028ms; 14.037ms] or [-0.032%; +0.032%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 888811e 1772713652 bob/cleanup-limiters
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.628ms 10.664ms ± 0.014ms 10.663ms ± 0.008ms 10.672ms 10.689ms 10.710ms 10.717ms 0.51% 0.929 1.457 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.662ms; 10.666ms] or [-0.019%; +0.019%] None None None

Baseline

Omitted due to size.

@dd-octo-sts

dd-octo-sts Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.51 MB 8.51 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 97.30 MB 97.30 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.12 MB 11.12 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 112.92 MB 112.92 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.16 MB 27.16 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 185.96 MB 185.98 MB +.01% (+24.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 916.65 MB 916.65 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.93 MB 9.93 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.76 MB 24.76 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.43 MB 51.43 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.97 MB 22.97 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.14 MB 190.16 MB +.01% (+24.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 900.31 MB 900.31 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.53 MB 7.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.52 MB 26.52 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.06 MB 47.06 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 85.27 MB 85.27 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.04 MB 10.04 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 105.90 MB 105.90 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.79 MB 11.79 MB 0% (0 B) 👌

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit d9048c6 into main Mar 5, 2026
105 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bob/cleanup-limiters branch March 5, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leiyks Leiyks Leiyks approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done sidecar

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bwoebi @codecov-commenter @Leiyks