feat: otel process ctxt FFI#1653
Closed
yannham wants to merge 4 commits intoyannham/process-context-protobuffrom
Closed
feat: otel process ctxt FFI#1653yannham wants to merge 4 commits intoyannham/process-context-protobuffrom
yannham wants to merge 4 commits intoyannham/process-context-protobuffrom
Conversation
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
a843b3c to
bd4ba00
Compare
4a2da93 to
4da1360
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## yannham/process-context-protobuf #1653 +/- ##
====================================================================
- Coverage 71.19% 71.00% -0.19%
====================================================================
Files 425 426 +1
Lines 62727 62893 +166
====================================================================
- Hits 44661 44660 -1
- Misses 18066 18233 +167
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-03-05 11:05:37 Comparing candidate commit fd75898 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Adds the process context protobuf definition, as well as a couple definitions taken from opentelemetry that the context depends on.
The previous interface for process context publication was rather low-level: the payload was taken as an arbitrary bag of bytes. However, the shape of the payload is known and constrained: it has a protobuf definition. This commit makes the interface higher-level by taking a structured process context instead, handling the protobuf encoding natively.
bd4ba00 to
b696b76
Compare
4da1360 to
adb1ef1
Compare
This adds an FFI for the creating, populating, publishing, unpublishing and freeing the OTel process context.
adb1ef1 to
fd75898
Compare
b696b76 to
157b0c5
Compare
Contributor
Author
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Depends #1653 # What does this PR do? This is the final follow-up of #1585 (and sequels) for OTel process context publication. This hooks the OTel process context sharing in the existing `store_tracer_metadata`, which now publishes using both "protocols". # Motivation This makes the OTel process context publication happen automatically for existing users of libdatadog that would publish tracer metadata already, in a transparent way. # Additional Notes N/A # How to test the change? Expected to be tested thereafter for Ruby. Co-authored-by: yann.hamdaoui <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends #1651
What does this PR do?
This adds an FFI for the creating, populating, publishing, unpublishing and freeing the OTel process context.
Motivation
The OTel process context publication facilities are supposed to be used from language runtimes, so a FFI is needed for it to be used at all.
Additional Notes
N/A
How to test the change?
Bind to libdd and use the newly added FFI functions.