Skip to content

Libdatadog obfuscation parity internship (IP)#1631

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
oscarld/obfuscation-ip-fix
Feb 26, 2026
Merged

Libdatadog obfuscation parity internship (IP)#1631
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
oscarld/obfuscation-ip-fix

Conversation

@Eldolfin
Copy link
Copy Markdown
Contributor

@Eldolfin Eldolfin commented Feb 26, 2026

What does this PR do?

Add the ECS task metadata IP to the whitelisted IP addresses which are not obfuscated.

Motivation

Making libdatadog’s obfuscation feature equivalent to the Agent’s implementation.

Additional Notes

How to test the change?

@Eldolfin Eldolfin requested review from a team as code owners February 26, 2026 13:02
@github-actions
Copy link
Copy Markdown

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/oscarld/obfuscation-ip-fix

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 3 3 No change (0%)
Total 3 3 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
libdd-trace-obfuscation/src/ip_address.rs 3 3 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 27 27 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-crashtracker 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 219 219 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@Eldolfin Eldolfin force-pushed the oscarld/obfuscation-ip-fix branch 2 times, most recently from 9ede69a to ea7358f Compare February 26, 2026 13:10
@Eldolfin Eldolfin force-pushed the oscarld/obfuscation-ip-fix branch from ea7358f to a952c87 Compare February 26, 2026 13:14
@Eldolfin Eldolfin changed the title feat: add ecs task metadata to unobfuscated ip addresses fix add ecs task metadata to unobfuscated ip addresses Feb 26, 2026
@Eldolfin Eldolfin changed the title fix add ecs task metadata to unobfuscated ip addresses fix: add ecs task metadata to unobfuscated ip addresses Feb 26, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.18%. Comparing base (40898a4) to head (a952c87).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1631      +/-   ##
==========================================
- Coverage   71.19%   71.18%   -0.02%     
==========================================
  Files         423      423              
  Lines       62453    62454       +1     
==========================================
- Hits        44466    44459       -7     
- Misses      17987    17995       +8     
Components Coverage Δ
libdd-crashtracker 63.23% <ø> (-0.04%) ⬇️
libdd-crashtracker-ffi 17.64% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 87.70% <ø> (ø)
libdd-data-pipeline-ffi 73.91% <ø> (ø)
libdd-common 79.73% <ø> (ø)
libdd-common-ffi 73.40% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.74% <ø> (-0.12%) ⬇️
libdd-profiling 81.55% <ø> (-0.02%) ⬇️
libdd-profiling-ffi 63.65% <ø> (ø)
datadog-sidecar 33.46% <ø> (ø)
datdog-sidecar-ffi 12.49% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 94.21% <100.00%> (+<0.01%) ⬆️
libdd-trace-protobuf 68.00% <ø> (ø)
libdd-trace-utils 89.18% <ø> (ø)
datadog-tracer-flare 88.95% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Feb 26, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.51 MB 8.51 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 97.27 MB 97.27 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.12 MB 11.12 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 112.87 MB 112.87 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.15 MB 27.15 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 185.89 MB 185.89 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 914.84 MB 914.84 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.93 MB 9.93 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.76 MB 24.76 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.40 MB 51.40 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.96 MB 22.96 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.10 MB 190.11 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 898.43 MB 898.43 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.53 MB 7.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.51 MB 26.51 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.03 MB 47.03 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 85.23 MB 85.23 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.04 MB 10.04 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 105.85 MB 105.85 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.78 MB 11.78 MB 0% (0 B) 👌

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit c20432c into main Feb 26, 2026
141 of 145 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the oscarld/obfuscation-ip-fix branch February 26, 2026 16:55
@Eldolfin Eldolfin changed the title fix: add ecs task metadata to unobfuscated ip addresses [APMSP-2651] Libdatadog obfuscation parity internship Feb 27, 2026
@Eldolfin Eldolfin changed the title [APMSP-2651] Libdatadog obfuscation parity internship [APMSP-2651] Libdatadog obfuscation parity internship (IP) Feb 27, 2026
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Feb 27, 2026
# What does this PR do?

Bump version to 28.0.2

This includes:
- [chore: update bytes to 1.11.1 to address RUSTSEC-2026-0007](https://github.com/DataDog/libdatadog/pull/1628)[chore: update bytes to 1.11.1 to address RUSTSEC-2026-0007](#1628)
- [chore(release): merge release branch to main](https://github.com/DataDog/libdatadog/pull/1629)[chore(release): merge release branch to main](#1629)
- [fix: add ecs task metadata to unobfuscated ip addresses](https://github.com/DataDog/libdatadog/pull/1631)[fix: add ecs task metadata to unobfuscated ip addresses](#1631)
- [fix: credit card luhn validation for obfuscation](https://github.com/DataDog/libdatadog/pull/1633)[fix: credit card luhn validation for obfuscation](#1633)   
- [perf(profiling): cache TLS in ProfileExporter::new](https://github.com/DataDog/libdatadog/pull/1619)[perf(profiling): cache TLS in ProfileExporter::new](#1619)

# Motivation
[perf(profiling): cache TLS in ProfileExporter::new](https://github.com/DataDog/libdatadog/pull/1619)[perf(profiling): cache TLS in ProfileExporter::new](#1619) fixes slow TLS issue

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?

Describe here in detail how the change can be validated.


Co-authored-by: gyuheon.oh <[email protected]>
@Eldolfin Eldolfin changed the title [APMSP-2651] Libdatadog obfuscation parity internship (IP) Libdatadog obfuscation parity internship (IP) Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants