ci: enahnce the junit file attribute script to handle nextest setup scripts#1574
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom Feb 17, 2026
Conversation
ekump
changed the title
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
==========================================
+ Coverage 70.83% 70.85% +0.01%
==========================================
Files 423 423
Lines 61862 61960 +98
==========================================
+ Hits 43823 43902 +79
- Misses 18039 18058 +19
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-02-17 16:47:09 Comparing candidate commit b5372ef in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics. scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて
scenario:single_flag_killswitch/rules-based
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
VianneyRuhlmann
approved these changes
Feb 17, 2026
Contributor
VianneyRuhlmann
left a comment
VianneyRuhlmann
left a comment
There was a problem hiding this comment.
I'm not very familiar with junit syntax but ltgm
Comment on lines
+65
to
+76
| let package_name = Self::normalize(package_name); | ||
| let target_name = Self::normalize(target_name); | ||
| self.targets.insert((package_name, target_name), src_path); | ||
| } |
Contributor
There was a problem hiding this comment.
nit: Can these function be merged since they look the same ?
Contributor
Author
There was a problem hiding this comment.
yeah, good idea. Fixed.
hoolioh
approved these changes
Feb 17, 2026
| fn insert_setup_script(&mut self, script_name: &str, src_path: PathBuf) { | ||
| // Don't normalize - script names can have hyphens and we want exact match | ||
| self.targets.insert( | ||
| ("@setup-script".to_string(), script_name.to_string()), |
Contributor
There was a problem hiding this comment.
nit: might be good to define @setup-scriptt as a constant definition.
Contributor
Author
There was a problem hiding this comment.
good idea, I'm mad I didn't think of it first.
ekump
force-pushed
the
ekump/handle-nextest-scripts-in-junit-file-attributes
branch
from
596404a to
b5372ef
Compare
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
ekump/handle-nextest-scripts-in-junit-file-attributes
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The script that runs after tests on CI to associate file names to tests in the junit.xml file was not handling the newly added nextest setup scripts, resulting in
prebuild-bin-testsintroduced in #1521 not having a file name, meaning test optimization couldn't associate a codeowner. This PR should fix that.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.