test(crashtracker): pre-build artifacts for bin_tests to improve test execution time on CI#1521
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 30532bd | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksComparisonBenchmark execution time: 2026-02-06 17:39:49 Comparing candidate commit 30532bd in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics. scenario:profile_add_sample2_frames_x1000
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
01261a7 to
8a81768
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
==========================================
- Coverage 71.20% 71.14% -0.06%
==========================================
Files 424 426 +2
Lines 69802 69897 +95
==========================================
+ Hits 49700 49730 +30
- Misses 20102 20167 +65
🚀 New features to boost your workflow:
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
[email protected] unqueued this merge request |
|
/remove |
|
View all feedbacks in Devflow UI.
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
[email protected] unqueued this merge request |
|
/merge --priority incident |
|
View all feedbacks in Devflow UI.
PR already in the queue with status queued |
|
/remove |
|
View all feedbacks in Devflow UI.
|
|
/merge --priority incident |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
…cripts (#1574) # What does this PR do? The script that runs after tests on CI to associate file names to tests in the junit.xml file was not handling the newly added nextest setup scripts, resulting in `prebuild-bin-tests` introduced in #1521 not having a file name, meaning test optimization couldn't associate a codeowner. This PR should fix that. # Motivation What inspired you to submit this pull request? # Additional Notes Anything else we should know when reviewing? # How to test the change? Describe here in detail how the change can be validated. Co-authored-by: edmund.kump <[email protected]>
What does this PR do?
Pre-build the binary artifacts used in crashtracker bin_tests.
bin_tests generates binaries that are used to test crashtracker against. This PR introduces a script that builds all of the necessary binaries prior to the tests executing. Setup-scripts have been enabled for nextest. When nextest runs, if it encounters a test in the bin_tests package it will kickoff the prebuild script prior to executing any of the tests in that package.
The previous implementation would kick off multiple cargo builds as nextest runs tests in parallel, leading to file lock contention within cargo, resulting in job timeouts on CI.
Artifacts are now defined in a separate file.
Motivation
incident 49170
Additional Notes
On Gitlab total execution time of build jobs like
build_rust_on_alpine_armwent from ~65 minutes to ~15 minutesHow to test the change?
cargo nextest run -p bin_tests