fix(profiling-ffi): Windows extern statics need __declspec(dllimport)#1468
Conversation
BenchmarksComparisonBenchmark execution time: 2026-03-12 15:30:59 Comparing candidate commit 922f694 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 2 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | 3.416ms | 3.442ms ± 0.023ms | 3.436ms ± 0.009ms | 3.445ms | 3.501ms | 3.519ms | 3.523ms | 2.54% | 1.904 | 3.102 | 0.68% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | [3.438ms; 3.445ms] or [-0.094%; +0.094%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | 493.320µs | 494.093µs ± 0.447µs | 494.066µs ± 0.281µs | 494.337µs | 494.832µs | 495.307µs | 496.949µs | 0.58% | 1.649 | 7.257 | 0.09% | 0.032µs | 1 | 200 |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | 2012278.476op/s | 2023913.862op/s ± 1829.133op/s | 2024020.172op/s ± 1150.847op/s | 2025222.914op/s | 2026287.854op/s | 2026610.999op/s | 2027083.183op/s | 0.15% | -1.632 | 7.122 | 0.09% | 129.339op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | 369.849µs | 370.572µs ± 0.240µs | 370.568µs ± 0.173µs | 370.742µs | 370.965µs | 371.099µs | 371.139µs | 0.15% | 0.036 | -0.389 | 0.06% | 0.017µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | 2694410.504op/s | 2698529.340op/s ± 1745.902op/s | 2698560.524op/s ± 1256.182op/s | 2699794.317op/s | 2701258.910op/s | 2702001.773op/s | 2703805.512op/s | 0.19% | -0.033 | -0.388 | 0.06% | 123.454op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | 167.340µs | 167.618µs ± 0.159µs | 167.587µs ± 0.079µs | 167.682µs | 167.963µs | 168.164µs | 168.190µs | 0.36% | 1.347 | 2.323 | 0.09% | 0.011µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | 5945672.318op/s | 5965968.363op/s ± 5654.435op/s | 5967039.186op/s ± 2830.154op/s | 5969524.330op/s | 5972805.193op/s | 5975583.903op/s | 5975842.587op/s | 0.15% | -1.340 | 2.301 | 0.09% | 399.829op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | 37.054µs | 37.267µs ± 0.051µs | 37.267µs ± 0.029µs | 37.301µs | 37.343µs | 37.363µs | 37.369µs | 0.28% | -1.219 | 3.739 | 0.14% | 0.004µs | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | throughput | 26760085.601op/s | 26833169.123op/s ± 37081.023op/s | 26833700.669op/s ± 20547.663op/s | 26850824.362op/s | 26890825.469op/s | 26979587.452op/s | 26987378.321op/s | 0.57% | 1.236 | 3.806 | 0.14% | 2622.024op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | 45.377µs | 45.580µs ± 0.075µs | 45.586µs ± 0.050µs | 45.634µs | 45.700µs | 45.720µs | 45.777µs | 0.42% | -0.269 | -0.240 | 0.16% | 0.005µs | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | 21844798.050op/s | 21939523.993op/s ± 36281.758op/s | 21936548.782op/s ± 24246.326op/s | 21962102.806op/s | 22003972.964op/s | 22026833.738op/s | 22037579.951op/s | 0.46% | 0.278 | -0.236 | 0.16% | 2565.508op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | [494.031µs; 494.155µs] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | [2023660.362op/s; 2024167.362op/s] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | [370.539µs; 370.606µs] or [-0.009%; +0.009%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | [2698287.375op/s; 2698771.305op/s] or [-0.009%; +0.009%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | [167.595µs; 167.640µs] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | [5965184.713op/s; 5966752.013op/s] or [-0.013%; +0.013%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | [37.260µs; 37.275µs] or [-0.019%; +0.019%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | throughput | [26828030.050op/s; 26838308.197op/s] or [-0.019%; +0.019%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | [45.570µs; 45.590µs] or [-0.023%; +0.023%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | [21934495.690op/s; 21944552.296op/s] or [-0.023%; +0.023%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 147.957µs | 150.081µs ± 1.549µs | 149.853µs ± 0.514µs | 150.443µs | 151.755µs | 156.387µs | 163.623µs | 9.19% | 4.790 | 33.361 | 1.03% | 0.110µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [149.866µs; 150.296µs] or [-0.143%; +0.143%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 13.020ms | 13.050ms ± 0.015ms | 13.047ms ± 0.010ms | 13.060ms | 13.079ms | 13.090ms | 13.102ms | 0.42% | 0.645 | 0.385 | 0.12% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [13.048ms; 13.052ms] or [-0.016%; +0.016%] | None | None | None |
Group 5
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | 3.894µs | 3.915µs ± 0.003µs | 3.915µs ± 0.001µs | 3.917µs | 3.919µs | 3.921µs | 3.923µs | 0.20% | -1.953 | 17.148 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/ | throughput | 254933955.236op/s | 255425992.995op/s ± 180259.233op/s | 255440155.228op/s ± 93902.414op/s | 255525763.393op/s | 255636260.310op/s | 255707438.357op/s | 256833774.546op/s | 0.55% | 1.986 | 17.433 | 0.07% | 12746.253op/s | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | 79.507µs | 80.025µs ± 0.125µs | 80.011µs ± 0.049µs | 80.077µs | 80.153µs | 80.197µs | 81.297µs | 1.61% | 4.848 | 53.298 | 0.16% | 0.009µs | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | 12300553.899op/s | 12496145.050op/s ± 19382.786op/s | 12498222.753op/s ± 7650.013op/s | 12504455.964op/s | 12515913.925op/s | 12523296.148op/s | 12577470.932op/s | 0.63% | -4.701 | 51.661 | 0.15% | 1370.570op/s | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | execution_time | 67.825µs | 67.934µs ± 0.068µs | 67.932µs ± 0.033µs | 67.959µs | 68.019µs | 68.075µs | 68.598µs | 0.98% | 4.763 | 43.036 | 0.10% | 0.005µs | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | throughput | 14577670.122op/s | 14720089.543op/s ± 14719.103op/s | 14720619.062op/s ± 7220.416op/s | 14728728.786op/s | 14735517.305op/s | 14741739.261op/s | 14743789.303op/s | 0.16% | -4.696 | 42.176 | 0.10% | 1040.798op/s | 1 | 200 |
| credit_card/is_card_number/37828224631 | execution_time | 3.897µs | 3.914µs ± 0.003µs | 3.914µs ± 0.002µs | 3.916µs | 3.918µs | 3.921µs | 3.923µs | 0.22% | -0.679 | 6.815 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/37828224631 | throughput | 254919756.670op/s | 255486675.389op/s ± 176410.496op/s | 255482099.190op/s ± 115336.862op/s | 255611556.905op/s | 255706788.055op/s | 255780311.640op/s | 256582047.836op/s | 0.43% | 0.696 | 6.910 | 0.07% | 12474.106op/s | 1 | 200 |
| credit_card/is_card_number/378282246310005 | execution_time | 64.586µs | 64.693µs ± 0.054µs | 64.688µs ± 0.034µs | 64.722µs | 64.785µs | 64.864µs | 64.984µs | 0.46% | 1.447 | 4.567 | 0.08% | 0.004µs | 1 | 200 |
| credit_card/is_card_number/378282246310005 | throughput | 15388326.912op/s | 15457639.043op/s ± 12962.409op/s | 15458814.627op/s ± 8118.571op/s | 15466724.120op/s | 15473480.312op/s | 15478598.393op/s | 15483293.526op/s | 0.16% | -1.436 | 4.506 | 0.08% | 916.581op/s | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | execution_time | 45.456µs | 45.719µs ± 0.107µs | 45.724µs ± 0.073µs | 45.794µs | 45.887µs | 45.942µs | 46.009µs | 0.62% | -0.053 | -0.322 | 0.23% | 0.008µs | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | throughput | 21735108.771op/s | 21872824.602op/s ± 51179.050op/s | 21870436.641op/s ± 34777.348op/s | 21908282.437op/s | 21955211.209op/s | 21994648.405op/s | 21999324.751op/s | 0.59% | 0.064 | -0.321 | 0.23% | 3618.905op/s | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | execution_time | 6.555µs | 6.626µs ± 0.016µs | 6.630µs ± 0.010µs | 6.639µs | 6.643µs | 6.645µs | 6.649µs | 0.28% | -1.123 | 1.232 | 0.24% | 0.001µs | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | throughput | 150405637.335op/s | 150930464.993op/s ± 370992.252op/s | 150829397.179op/s ± 226880.663op/s | 151141272.933op/s | 151577080.656op/s | 151865284.558op/s | 152548709.328op/s | 1.14% | 1.137 | 1.296 | 0.25% | 26233.114op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | execution_time | 3.899µs | 3.916µs ± 0.004µs | 3.916µs ± 0.002µs | 3.918µs | 3.922µs | 3.924µs | 3.944µs | 0.72% | 2.401 | 16.644 | 0.11% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | throughput | 253545569.333op/s | 255346544.700op/s ± 269551.026op/s | 255373487.981op/s ± 141252.119op/s | 255514040.497op/s | 255624165.633op/s | 255696291.714op/s | 256507175.424op/s | 0.44% | -2.361 | 16.411 | 0.11% | 19060.136op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | 65.617µs | 65.734µs ± 0.045µs | 65.734µs ± 0.029µs | 65.762µs | 65.807µs | 65.830µs | 65.860µs | 0.19% | 0.070 | -0.299 | 0.07% | 0.003µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | 15183673.324op/s | 15212891.790op/s ± 10326.489op/s | 15212782.078op/s ± 6771.169op/s | 15219737.575op/s | 15229841.984op/s | 15233381.408op/s | 15240007.710op/s | 0.18% | -0.067 | -0.300 | 0.07% | 730.193op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | 53.358µs | 53.450µs ± 0.043µs | 53.443µs ± 0.031µs | 53.483µs | 53.520µs | 53.559µs | 53.563µs | 0.22% | 0.396 | -0.613 | 0.08% | 0.003µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | 18669678.178op/s | 18708912.154op/s ± 15065.495op/s | 18711386.618op/s ± 10694.888op/s | 18721186.146op/s | 18729642.940op/s | 18735263.933op/s | 18741425.549op/s | 0.16% | -0.394 | -0.616 | 0.08% | 1065.291op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | 3.896µs | 3.915µs ± 0.003µs | 3.915µs ± 0.001µs | 3.916µs | 3.920µs | 3.922µs | 3.928µs | 0.34% | -0.611 | 10.974 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | 254566726.733op/s | 255428700.866op/s ± 186740.343op/s | 255435658.819op/s ± 96030.531op/s | 255540726.279op/s | 255656464.356op/s | 255729251.503op/s | 256679728.120op/s | 0.49% | 0.639 | 11.106 | 0.07% | 13204.536op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | 50.154µs | 50.231µs ± 0.044µs | 50.223µs ± 0.026µs | 50.257µs | 50.310µs | 50.332µs | 50.409µs | 0.37% | 0.832 | 0.582 | 0.09% | 0.003µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | 19837654.586op/s | 19907948.241op/s ± 17293.046op/s | 19911243.641op/s ± 10423.883op/s | 19920455.629op/s | 19930788.345op/s | 19937707.484op/s | 19938448.017op/s | 0.14% | -0.827 | 0.567 | 0.09% | 1222.803op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | 45.383µs | 45.631µs ± 0.085µs | 45.637µs ± 0.059µs | 45.696µs | 45.763µs | 45.800µs | 45.817µs | 0.40% | -0.290 | -0.277 | 0.19% | 0.006µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | 21825750.978op/s | 21915167.508op/s ± 41051.017op/s | 21912002.300op/s ± 28499.178op/s | 21942601.013op/s | 21987575.862op/s | 22009963.423op/s | 22034478.627op/s | 0.56% | 0.299 | -0.271 | 0.19% | 2902.745op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | 6.574µs | 6.630µs ± 0.013µs | 6.634µs ± 0.005µs | 6.638µs | 6.644µs | 6.647µs | 6.651µs | 0.25% | -1.558 | 2.883 | 0.19% | 0.001µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | 150363803.780op/s | 150829783.103op/s ± 295414.398op/s | 150733927.593op/s ± 119530.999op/s | 150982743.045op/s | 151417084.040op/s | 151879073.797op/s | 152103456.926op/s | 0.91% | 1.572 | 2.948 | 0.20% | 20888.952op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | [3.915µs; 3.915µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/ | throughput | [255401010.799op/s; 255450975.191op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | [80.008µs; 80.042µs] or [-0.022%; +0.022%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | [12493458.782op/s; 12498831.318op/s] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | execution_time | [67.925µs; 67.944µs] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | throughput | [14718049.617op/s; 14722129.469op/s] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/37828224631 | execution_time | [3.914µs; 3.914µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/37828224631 | throughput | [255462226.590op/s; 255511124.187op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/378282246310005 | execution_time | [64.685µs; 64.701µs] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number/378282246310005 | throughput | [15455842.578op/s; 15459435.508op/s] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | execution_time | [45.704µs; 45.734µs] or [-0.032%; +0.032%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | throughput | [21865731.678op/s; 21879917.526op/s] or [-0.032%; +0.032%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | execution_time | [6.623µs; 6.628µs] or [-0.034%; +0.034%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | throughput | [150879049.035op/s; 150981880.951op/s] or [-0.034%; +0.034%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | execution_time | [3.916µs; 3.917µs] or [-0.015%; +0.015%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | throughput | [255309187.521op/s; 255383901.880op/s] or [-0.015%; +0.015%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | [65.728µs; 65.740µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | [15211460.638op/s; 15214322.942op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | [53.445µs; 53.456µs] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | [18706824.221op/s; 18711000.087op/s] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | [3.915µs; 3.915µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | [255402820.450op/s; 255454581.281op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | [50.225µs; 50.237µs] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | [19905551.591op/s; 19910344.891op/s] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | [45.619µs; 45.642µs] or [-0.026%; +0.026%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | [21909478.231op/s; 21920856.784op/s] or [-0.026%; +0.026%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | [6.628µs; 6.632µs] or [-0.027%; +0.027%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | [150788841.509op/s; 150870724.697op/s] or [-0.027%; +0.027%] | None | None | None |
Group 6
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | 205.591µs | 206.497µs ± 0.736µs | 206.321µs ± 0.423µs | 206.821µs | 207.769µs | 209.585µs | 209.799µs | 1.69% | 1.641 | 3.861 | 0.36% | 0.052µs | 1 | 200 |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | 4766473.092op/s | 4842735.481op/s ± 17171.465op/s | 4846808.439op/s ± 9953.842op/s | 4856081.654op/s | 4861050.804op/s | 4862526.189op/s | 4864028.067op/s | 0.36% | -1.607 | 3.689 | 0.35% | 1214.206op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | execution_time | 18.612µs | 18.719µs ± 0.104µs | 18.680µs ± 0.022µs | 18.710µs | 18.902µs | 19.037µs | 19.401µs | 3.86% | 2.567 | 9.625 | 0.55% | 0.007µs | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | throughput | 51544545.408op/s | 53423472.769op/s ± 292693.170op/s | 53532522.725op/s ± 62645.053op/s | 53585597.376op/s | 53671755.292op/s | 53724594.321op/s | 53729731.256op/s | 0.37% | -2.487 | 8.890 | 0.55% | 20696.533op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/good | execution_time | 10.722µs | 10.813µs ± 0.048µs | 10.808µs ± 0.035µs | 10.847µs | 10.900µs | 10.921µs | 10.932µs | 1.15% | 0.371 | -0.506 | 0.44% | 0.003µs | 1 | 200 |
| normalization/normalize_name/normalize_name/good | throughput | 91470673.874op/s | 92486730.311op/s ± 410360.119op/s | 92525003.869op/s ± 299781.933op/s | 92788870.576op/s | 93107540.234op/s | 93222184.330op/s | 93269369.058op/s | 0.80% | -0.353 | -0.521 | 0.44% | 29016.842op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | [206.395µs; 206.600µs] or [-0.049%; +0.049%] | None | None | None |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | [4840355.681op/s; 4845115.281op/s] or [-0.049%; +0.049%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | execution_time | [18.705µs; 18.733µs] or [-0.077%; +0.077%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | throughput | [53382908.310op/s; 53464037.227op/s] or [-0.076%; +0.076%] | None | None | None |
| normalization/normalize_name/normalize_name/good | execution_time | [10.806µs; 10.819µs] or [-0.062%; +0.062%] | None | None | None |
| normalization/normalize_name/normalize_name/good | throughput | [92429858.345op/s; 92543602.277op/s] or [-0.061%; +0.061%] | None | None | None |
Group 7
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | 740.021µs | 741.753µs ± 0.633µs | 741.671µs ± 0.392µs | 742.112µs | 742.881µs | 743.470µs | 744.022µs | 0.32% | 0.616 | 0.912 | 0.09% | 0.045µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | [741.666µs; 741.841µs] or [-0.012%; +0.012%] | None | None | None |
Group 8
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | 4.964µs | 5.025µs ± 0.039µs | 5.026µs ± 0.036µs | 5.058µs | 5.086µs | 5.089µs | 5.103µs | 1.54% | 0.246 | -1.370 | 0.78% | 0.003µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | [5.020µs; 5.031µs] or [-0.108%; +0.108%] | None | None | None |
Group 9
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | 49.737ms | 49.968ms ± 0.780ms | 49.859ms ± 0.045ms | 49.897ms | 50.007ms | 55.770ms | 56.757ms | 13.83% | 7.704 | 58.968 | 1.56% | 0.055ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | [49.859ms; 50.076ms] or [-0.216%; +0.216%] | None | None | None |
Group 10
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | 88.159µs | 88.440µs ± 0.182µs | 88.415µs ± 0.060µs | 88.476µs | 88.644µs | 89.194µs | 90.009µs | 1.80% | 4.505 | 31.275 | 0.21% | 0.013µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | [88.415µs; 88.466µs] or [-0.029%; +0.029%] | None | None | None |
Group 11
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | 245.346ns | 255.213ns ± 11.458ns | 248.967ns ± 2.309ns | 259.815ns | 282.343ns | 287.334ns | 292.065ns | 17.31% | 1.585 | 1.467 | 4.48% | 0.810ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | [253.625ns; 256.801ns] or [-0.622%; +0.622%] | None | None | None |
Group 12
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | 2.398µs | 2.436µs ± 0.014µs | 2.432µs ± 0.007µs | 2.443µs | 2.466µs | 2.477µs | 2.482µs | 2.06% | 1.075 | 1.431 | 0.56% | 0.001µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | [2.434µs; 2.437µs] or [-0.078%; +0.078%] | None | None | None |
Group 13
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | 4.080ms | 4.085ms ± 0.006ms | 4.084ms ± 0.001ms | 4.085ms | 4.088ms | 4.092ms | 4.165ms | 2.00% | 11.537 | 148.618 | 0.15% | 0.000ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | [4.084ms; 4.086ms] or [-0.021%; +0.021%] | None | None | None |
Group 14
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | 13.888ms | 13.967ms ± 0.030ms | 13.963ms ± 0.015ms | 13.979ms | 14.009ms | 14.068ms | 14.149ms | 1.34% | 1.858 | 7.745 | 0.21% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | [13.963ms; 13.971ms] or [-0.030%; +0.030%] | None | None | None |
Group 15
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 18.301µs | 26.311µs ± 9.491µs | 18.625µs ± 0.213µs | 34.775µs | 42.592µs | 45.798µs | 66.136µs | 255.10% | 0.854 | 0.250 | 35.98% | 0.671µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [24.996µs; 27.627µs] or [-4.999%; +4.999%] | None | None | None |
Group 16
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 189.665ns | 192.356ns ± 1.959ns | 192.166ns ± 1.225ns | 193.146ns | 196.073ns | 198.332ns | 200.445ns | 4.31% | 1.237 | 1.855 | 1.02% | 0.139ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [192.085ns; 192.628ns] or [-0.141%; +0.141%] | None | None | None |
Group 17
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | 32.587µs | 33.294µs ± 0.892µs | 32.780µs ± 0.122µs | 34.498µs | 34.607µs | 34.688µs | 37.669µs | 14.91% | 1.268 | 1.326 | 2.67% | 0.063µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | [33.170µs; 33.418µs] or [-0.371%; +0.371%] | None | None | None |
Group 18
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 1.278µs | 3.251µs ± 1.435µs | 3.029µs ± 0.032µs | 3.058µs | 3.707µs | 14.028µs | 14.858µs | 390.53% | 7.295 | 54.607 | 44.04% | 0.101µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [3.052µs; 3.450µs] or [-6.119%; +6.119%] | None | None | None |
Group 19
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 922f694 | 1773328434 | levi/fix-windows-declspec-vars |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | 162.918µs | 164.317µs ± 0.364µs | 164.276µs ± 0.144µs | 164.430µs | 164.782µs | 165.030µs | 167.750µs | 2.11% | 4.078 | 38.829 | 0.22% | 0.026µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | [164.267µs; 164.368µs] or [-0.031%; +0.031%] | None | None | None |
Baseline
Omitted due to size.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 71.35% 71.34% -0.01%
==========================================
Files 429 429
Lines 63777 63804 +27
==========================================
+ Hits 45505 45519 +14
- Misses 18272 18285 +13
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
If they don't have this, they crash when dereferencing the pointer.
0802540 to
d844b01
Compare
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
…-unprocessed * 'main' of github.com:DataDog/libdatadog: feat(sidecar): add thread mode as fallback connection for restricted environments (#1447) feat(profiling-ffi): ProfilesDictionary_insert_strs (#1764) chore(release): merge release branch to main (#1760) fix(libdd-crashtracker-ffi)!: add missing fields for endpoint configuration (#1758) ci: prevent running macos tests on release branches (#1765) chore(datadog-tracer-flare): remove unnecessary features/deps (#1761) fix(profiling-ffi): Windows extern statics need __declspec(dllimport) (#1468) feat(profiling): thread id/name as well-known strs (#1757) ci: switch to ephemeral branches (#1731) chore(crashtracker): use weaker mem ordering for OP_COUNTERS (#1744) refactor(trace-utils)!: change header name type to accept dynamic values (#1722)
What does this PR do?
On the FFI headers on windows, this attends to replace
"extern "with"extern __declspec(dllimport) ".Motivation
These static variables result in a crash if you use them when they don't have
__declspec(dllimport).Additional Notes
This went unfound because none of the examples run on Windows in CI. I am planning to look into running these as part of CI (this is in draft still).
How to test the change?
Build and note you don't get a crash anymore when using these static vars on Windows 😆