fix(common): don't use reqwest http proxies

morrisonlevi · morrisonlevi · commit 2629741b0395 · 2026-03-26T14:37:44.000-06:00
diff --git a/libdd-common/src/lib.rs b/libdd-common/src/lib.rs
@@ -348,9 +348,14 @@ impl Endpoint {
     pub fn to_reqwest_client_builder(&self) -> anyhow::Result<(reqwest::ClientBuilder, String)> {
         use anyhow::Context;
 
+        // Don't use proxies, as this calls `getenv` which is unsafe and not
+        // just in theory. It can cause crashes with PHP where php-fpm's env
+        // configuration will mutate the system environment (it doesn't pass
+        // it as part of the SAPI env, it changes the actual system env).
         let mut builder = reqwest::Client::builder()
             .timeout(std::time::Duration::from_millis(self.timeout_ms))
-            .hickory_dns(!self.use_system_resolver);
+            .hickory_dns(!self.use_system_resolver)
+            .no_proxy();
 
         let request_url = match self.url.scheme_str() {
             // HTTP/HTTPS endpoints
