Skip to content
This repository was archived by the owner on Jan 23, 2020. It is now read-only.

Set tagNode to false by default#84

Merged
sjenriquez merged 1 commit into
masterfrom
scott/set-global-config
May 25, 2017
Merged

Set tagNode to false by default#84
sjenriquez merged 1 commit into
masterfrom
scott/set-global-config

Conversation

@sjenriquez

@sjenriquez sjenriquez commented Apr 11, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes NullPointerException if the plugin is installed but not configured. We expect SEVERE logging because no API key is set, but we should avoid the NPE.

Apr 11, 2017 9:24:18 PM org.datadog.jenkins.plugins.datadog.DatadogHttpRequests post
SEVERE: Hmmm, your API key may be invalid. We received a 403 error.
Apr 11, 2017 9:24:18 PM hudson.model.Run execute
INFO: dummy job #41 main build action completed: SUCCESS
Apr 11, 2017 9:24:18 PM hudson.model.listeners.RunListener report
WARNING: RunListener failed
java.lang.NullPointerException
	at org.datadog.jenkins.plugins.datadog.DatadogUtilities.assembleTags(DatadogUtilities.java:383)
	at org.datadog.jenkins.plugins.datadog.DatadogBuildListener.onCompleted(DatadogBuildListener.java:154)
	at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
	at hudson.model.Run.execute(Run.java:1773)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:404)

@sjenriquez
sjenriquez force-pushed the scott/set-global-config branch from 3ba2c89 to 8fbb080 Compare April 11, 2017 21:40
@sjenriquez
sjenriquez requested a review from truthbk April 11, 2017 21:47
@sjenriquez sjenriquez mentioned this pull request Apr 11, 2017
Merged
@truthbk truthbk self-assigned this Apr 12, 2017
truthbk
truthbk approved these changes May 24, 2017
View reviewed changes

@truthbk truthbk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make sure there are no unwatend side-effects, but this looks good to go 👍

@sjenriquez
sjenriquez force-pushed the scott/set-global-config branch from 8fbb080 to c0633d2 Compare May 25, 2017 17:35
@sjenriquez
sjenriquez force-pushed the scott/set-global-config branch from c0633d2 to 00cbd80 Compare May 25, 2017 17:39
@sjenriquez sjenriquez changed the title set tagNode to false by default Set tagNode to false by default May 25, 2017
@sjenriquez
sjenriquez merged commit 68a6e58 into master May 25, 2017
@sjenriquez
sjenriquez deleted the scott/set-global-config branch May 25, 2017 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@truthbk truthbk truthbk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@truthbk truthbk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjenriquez @truthbk