This repository was archived by the owner on Jan 23, 2020. It is now read-only.
Fix to StatsDClient reporting, logging#76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made to properly stop the StatsDClient after usage, in #73, appears to close the StatsDClient before it has a chance to actually report. I would have thought that it would report before closing, but it doesn't appear to do any sort of blocking on this at all, which also makes sense. Hence, I've added a short 100ms sleep, which again allows this metric to be reported.
I retested this confirming that the UDP sockets are released, and the metric is properly reported.
This also adds the
resulttag to thejenkins.job.completedmetric.