This repository was archived by the owner on Jan 23, 2020. It is now read-only.
Fix duration of pipeline jobs#70
Merged
Merged
Conversation
|
Thanks @ulich . We appreciate your contribution here. We will be reviewing this PR shortly and get back to you with feedback. |
|
Any chance you'll be reviewing this soon? |
This was referenced Feb 16, 2017
Contributor
|
@ulich Sorry for the long delay here! I am preparing a new release the should go out next week. The test is failing on a |
This was referenced Apr 6, 2017
Closed
Contributor
Author
|
Sorry, tests are fixed now. When I merged the master I pulled some changes in that caused the tests to fail, but I did not re-run them... Maybe you could set up automated test runs for PRs |
Contributor
|
Thanks @ulich! This will go out shortly with our next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51.
I took over the work from #53 and added the proposed fallback
Btw: The code is really hard to test. I did not want to do a full refactoring to make it testable, that's why I used powermock...