This repository was archived by the owner on Jan 23, 2020. It is now read-only.
Replacing PrintStream with java.util.Logging to make it less verbose#23
Closed
dmabamboo wants to merge 2 commits into
Closed
Replacing PrintStream with java.util.Logging to make it less verbose#23dmabamboo wants to merge 2 commits into
dmabamboo wants to merge 2 commits into
Conversation
added 2 commits
November 3, 2015 17:00
…bit less repetitive
…when doing String manipulations
Contributor
|
Hey @dmabamboo ! Thanks for the PR :) I'll take a look |
Contributor
There was a problem hiding this comment.
Since we'll probably add more things to this version bump, let's say this instead, 0.3.1 / Unreleased
Contributor
|
I'll run a test with it now, but after reading through things it looks good! :) Would you mind fixing those comments and updating the PR, @dmabamboo ? |
Contributor
|
Oh, and would you squash your commits? :) |
This was referenced Dec 3, 2015
Contributor
|
Cherry-picked @dmabamboo s blacklist changes to here: #28 |
Contributor
|
Cherry-picked @dmabamboo s blacklist changes to here: #29 |
Contributor
|
Thanks for your contributions @dmabamboo :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow for more granular control over which messages are logged and where I'd like to propose that we replace PrintStream with jul which gives granular control from a Jenkins admin standpoint.
Please merge it if you are happy with that, otherwise please contact me so we can enhance it further.
Regards,
Daniel Alheiros