Skip to content
This repository was archived by the owner on Jan 23, 2020. It is now read-only.

configure plugin using env vars#184

Merged
gzussa merged 4 commits into
masterfrom
gzu/env_var_config
Dec 18, 2019
Merged

configure plugin using env vars#184
gzussa merged 4 commits into
masterfrom
gzu/env_var_config

Conversation

@gzussa

@gzussa gzussa commented Dec 17, 2019

Copy link
Copy Markdown
Contributor

@gzussa
gzussa requested a review from a team as a code owner December 17, 2019 11:58
Comment thread README.md Outdated

You have the option of configuring your Datadog plugin using environment variables.
You will have to specify three variables:
- `DATADOG_JENKINS_PLUGIN_REPORT_WITH` specify which authentication mechanism you want to use. When set to `DSD` it will use a DogStatsD Server to report to Datadog. Otherwise set it to the default `HTTP` value.

@zippolyte zippolyte Dec 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `DATADOG_JENKINS_PLUGIN_REPORT_WITH` specify which authentication mechanism you want to use. When set to `DSD` it will use a DogStatsD Server to report to Datadog. Otherwise set it to the default `HTTP` value.
- `DATADOG_JENKINS_PLUGIN_REPORT_WITH` specify which report mechanism you want to use. When set to `DSD` it uses a DogStatsD Server to report to Datadog. Otherwise set it to the default `HTTP` value.

Comment thread README.md Outdated

### Configure with the plugin user interface

To configure your newly installed Datadog Plugin, simply navigate to the `Manage Jenkins -> Configure System` page on your Jenkins installation.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To configure your newly installed Datadog Plugin, simply navigate to the `Manage Jenkins -> Configure System` page on your Jenkins installation.
To configure your newly installed Datadog Plugin, navigate to the `Manage Jenkins -> Configure System` page on your Jenkins installation.

Comment thread README.md Outdated
@@ -179,7 +190,9 @@ You can use two ways to configure your plugin to submit data to Datadog.

Once your configuration changes are finished, simply save them, and you're good to go!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid words like "simply" "quickly" "east"

Suggested change
Once your configuration changes are finished, simply save them, and you're good to go!
Once your configuration changes are finished, save them, and you're good to go!

Comment thread README.md Outdated
Alternatively, you have the option of configuring your Datadog plugin using a Groovy script like this one:
### Configure with a Groovy script

You have the option of configuring your Datadog plugin using a Groovy script like this one:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You have the option of configuring your Datadog plugin using a Groovy script like this one:
Configure your Datadog plugin using a Groovy script like this one

Comment thread README.md Outdated

### Configure with an environment variables

You have the option of configuring your Datadog plugin using environment variables.

@l0k0ms l0k0ms Dec 17, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You have the option of configuring your Datadog plugin using environment variables.
Configure your Datadog plugin using environment variables by specifying the three variables below:

Comment thread README.md Outdated
### Configure with an environment variables

You have the option of configuring your Datadog plugin using environment variables.
You will have to specify three variables:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You will have to specify three variables:

Comment thread README.md Outdated
You will have to specify three variables:
- `DATADOG_JENKINS_PLUGIN_REPORT_WITH` specify which authentication mechanism you want to use. When set to `DSD` it will use a DogStatsD Server to report to Datadog. Otherwise set it to the default `HTTP` value.

If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `DSD` value, you will have to specify the following environment variables:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `DSD` value, you will have to specify the following environment variables:
If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `DSD` value, you must specify the following environment variables:

Comment thread README.md Outdated
- `DATADOG_JENKINS_PLUGIN_REPORT_WITH` specify which authentication mechanism you want to use. When set to `DSD` it will use a DogStatsD Server to report to Datadog. Otherwise set it to the default `HTTP` value.

If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `DSD` value, you will have to specify the following environment variables:
- `DATADOG_JENKINS_PLUGIN_TARGET_HOST` which specify the DogStatsD Server host to report to. Default value is `localhost`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `DATADOG_JENKINS_PLUGIN_TARGET_HOST` which specify the DogStatsD Server host to report to. Default value is `localhost`.
- `DATADOG_JENKINS_PLUGIN_TARGET_HOST` which specifies the DogStatsD Server host to report to. Default value is `localhost`.

Comment thread README.md Outdated

If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `DSD` value, you will have to specify the following environment variables:
- `DATADOG_JENKINS_PLUGIN_TARGET_HOST` which specify the DogStatsD Server host to report to. Default value is `localhost`.
- `DATADOG_JENKINS_PLUGIN_TARGET_PORT` which specify the DogStatsD Server port to report to. Default value is `8125`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `DATADOG_JENKINS_PLUGIN_TARGET_PORT` which specify the DogStatsD Server port to report to. Default value is `8125`.
- `DATADOG_JENKINS_PLUGIN_TARGET_PORT` which specifies the DogStatsD Server port to report to. Default value is `8125`.

Comment thread README.md Outdated
- `DATADOG_JENKINS_PLUGIN_TARGET_HOST` which specify the DogStatsD Server host to report to. Default value is `localhost`.
- `DATADOG_JENKINS_PLUGIN_TARGET_PORT` which specify the DogStatsD Server port to report to. Default value is `8125`.

If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `HTTP` value or don't specify it, you will have to specify the following environment variables:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `HTTP` value or don't specify it, you will have to specify the following environment variables:
If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `HTTP` value or don't specify it, you must specify the following environment variables:

Comment thread README.md Outdated
- `DATADOG_JENKINS_PLUGIN_TARGET_PORT` which specify the DogStatsD Server port to report to. Default value is `8125`.

If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `HTTP` value or don't specify it, you will have to specify the following environment variables:
- `DATADOG_JENKINS_PLUGIN_TARGET_API_URL` which specify the Datadog API Endpoint to report to. Default value is `https://api.datadoghq.com/api/`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we inline here the instructions for EU ?

Suggested change
- `DATADOG_JENKINS_PLUGIN_TARGET_API_URL` which specify the Datadog API Endpoint to report to. Default value is `https://api.datadoghq.com/api/`.
- `DATADOG_JENKINS_PLUGIN_TARGET_API_URL` which specifies the Datadog API Endpoint to report to. Default value is `https://api.datadoghq.com/api/`.

Comment thread README.md Outdated

If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `HTTP` value or don't specify it, you will have to specify the following environment variables:
- `DATADOG_JENKINS_PLUGIN_TARGET_API_URL` which specify the Datadog API Endpoint to report to. Default value is `https://api.datadoghq.com/api/`.
- `DATADOG_JENKINS_PLUGIN_TARGET_API_KEY` which specify your Datadog API key in order to report to your Datadog account.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `DATADOG_JENKINS_PLUGIN_TARGET_API_KEY` which specify your Datadog API key in order to report to your Datadog account.
- `DATADOG_JENKINS_PLUGIN_TARGET_API_KEY` which specifies your Datadog API key in order to report to your Datadog account.

Comment thread README.md Outdated
If you set `DATADOG_JENKINS_PLUGIN_REPORT_WITH` with the `HTTP` value or don't specify it, you will have to specify the following environment variables:
- `DATADOG_JENKINS_PLUGIN_TARGET_API_URL` which specify the Datadog API Endpoint to report to. Default value is `https://api.datadoghq.com/api/`.
- `DATADOG_JENKINS_PLUGIN_TARGET_API_KEY` which specify your Datadog API key in order to report to your Datadog account.
- Find your API Key from the [API Keys](https://app.datadoghq.com/account/settings#api) page on your Datadog account.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Find your API Key from the [API Keys](https://app.datadoghq.com/account/settings#api) page on your Datadog account.
- Get your API Key from the [Datadog API Keys page](https://app.datadoghq.com/account/settings#api).

Comment thread README.md
* Global Tags
* A comma-separated list of tags to apply to all metrics, events, service checks.
* Blacklisted Jobs
* A comma-separated list of regex to match job names that should not be monitored. (eg: susans-job,johns-.*,prod_folder/prod_release).

@l0k0ms l0k0ms Dec 18, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* A comma-separated list of regex to match job names that should not be monitored. (eg: susans-job,johns-.*,prod_folder/prod_release).
* A comma-separated list of regex to match job names that should not be monitored. (eg: `susans-job,johns-.*,prod_folder/prod_release`).

Comment thread README.md Outdated
### Configure with an environment variables

Configure your Datadog plugin using environment variables by specifying the three variables below:.
- `DATADOG_JENKINS_PLUGIN_REPORT_WITH` specify which report mechanism you want to use. When set to `DSD` it will use a DogStatsD Server to report to Datadog. Otherwise set it to the default `HTTP` value.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `DATADOG_JENKINS_PLUGIN_REPORT_WITH` specify which report mechanism you want to use. When set to `DSD` it will use a DogStatsD Server to report to Datadog. Otherwise set it to the default `HTTP` value.
- `DATADOG_JENKINS_PLUGIN_REPORT_WITH` which specifies which report mechanism you want to use. When set to `DSD` it will use a DogStatsD Server to report to Datadog. Otherwise set it to the default `HTTP` value.

@gzussa
gzussa merged commit a5cf677 into master Dec 18, 2019
@gzussa
gzussa deleted the gzu/env_var_config branch December 18, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set dogstatsd endpoint in a dockerized environment

3 participants