This repository was archived by the owner on Jan 23, 2020. It is now read-only.
single tag global conf#182
Merged
Merged
Conversation
gzussa
commented
Dec 12, 2019
gzussa
commented
Contributor
- Support tags with no values
- Fixes Append the default parameter "Add tags from file in workspace" in general plugin configuration #110
zippolyte
suggested changes
Dec 12, 2019
nmuesch
reviewed
Dec 12, 2019
nmuesch
left a comment
nmuesch
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. Left a minor doc comment.
added 2 commits
December 13, 2019 21:20
nmuesch
approved these changes
Dec 13, 2019
nmuesch
left a comment
nmuesch
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM, assuming manual testing and things went well :)
zippolyte
approved these changes
Dec 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.