This repository was archived by the owner on Jan 23, 2020. It is now read-only.
add more metrics#180
Merged
Merged
Conversation
zippolyte
suggested changes
Dec 4, 2019
| @Override | ||
| protected void doRun() throws Exception { | ||
| try { | ||
| logger.fine("doRun called: Computing Node metrics"); |
Contributor
There was a problem hiding this comment.
These are not the node metrics
| nodeName = computer.getName(); | ||
| } | ||
| JSONArray tags = new JSONArray(); | ||
| tags.add("node-name:" + nodeName); |
Contributor
There was a problem hiding this comment.
Suggested change
| tags.add("node-name:" + nodeName); | |
| tags.add("node_name:" + nodeName); |
| } | ||
| if(labels != null){ | ||
| for (LabelAtom label: labels){ | ||
| tags.add("node-label:" + label.getName()); |
Contributor
There was a problem hiding this comment.
Suggested change
| tags.add("node-label:" + label.getName()); | |
| tags.add("node_label:" + label.getName()); |
| JSONArray tags = new JSONArray(); | ||
| tags.add("node-name:" + nodeName); | ||
| if(nodeHostname != null){ | ||
| tags.add("node-hostname:" + nodeHostname); |
Contributor
There was a problem hiding this comment.
Suggested change
| tags.add("node-hostname:" + nodeHostname); | |
| tags.add("node_hostname:" + nodeHostname); |
| } | ||
| } | ||
| client.gauge("jenkins.executor.count", executorCount, hostname, tags); | ||
| client.gauge("jenkins.executor.in-use", inUse, hostname, tags); |
Contributor
There was a problem hiding this comment.
Suggested change
| client.gauge("jenkins.executor.in-use", inUse, hostname, tags); | |
| client.gauge("jenkins.executor.in_use", inUse, hostname, tags); |
| |--------------------------|---------------------------------------------------------------| | ||
| | jenkins.executor.count | Executor count | | ||
| | jenkins.executor.free | Number of unused executor | | ||
| | jenkins.executor.in-use | Number of idle executor | |
Contributor
There was a problem hiding this comment.
Suggested change
| | jenkins.executor.in-use | Number of idle executor | | |
| | jenkins.executor.in_use | Number of idle executor | |
| * `node` | ||
|
|
||
| `jenkins.executor.*` metrics have the following additional tags: | ||
| * `node-hostname` |
Contributor
There was a problem hiding this comment.
Suggested change
| * `node-hostname` | |
| * `node_hostname` |
|
|
||
| `jenkins.executor.*` metrics have the following additional tags: | ||
| * `node-hostname` | ||
| * `node-name` |
Contributor
There was a problem hiding this comment.
Suggested change
| * `node-name` | |
| * `node_name` |
| `jenkins.executor.*` metrics have the following additional tags: | ||
| * `node-hostname` | ||
| * `node-name` | ||
| * `node-label` |
Contributor
There was a problem hiding this comment.
Suggested change
| * `node-label` | |
| * `node_label` |
zippolyte
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following metrics:
jenkins.project.countjenkins.plugin.countjenkins.executor.countjenkins.executor.in-usejenkins.executor.freejenkins.node.countjenkins.node.offlinejenkins.node.onlinejenkins.queue.buildablejenkins.queue.pendingjenkins.queue.stuckjenkins.queue.blocked