This repository was archived by the owner on Jan 23, 2020. It is now read-only.
[tags] Add node, remove build_number, and change job_name to job#17
Merged
Conversation
JohnLZeller
force-pushed
the
zeller/tags
branch
from
September 22, 2015 22:03
da5e655 to
463caea
Compare
JohnLZeller
changed the title
Contributor
Author
|
Tested, and works well. Node does not show up in tags for started build events, which I suspect is because the function is called before a node is provisioned. |
JohnLZeller
added a commit
that referenced
this pull request
Sep 22, 2015
[tags] Add node, remove build_number, and change job_name to job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having build_number added as a tag for every metric and event is causing too many contexts to be generated. Additionally, it's not even of much use.