This repository was archived by the owner on Jan 23, 2020. It is now read-only.
Send all metrics w/o DogstatsD#169
Merged
Merged
Conversation
added 8 commits
November 12, 2019 18:51
gzussa
suggested changes
Nov 14, 2019
gzussa
left a comment
gzussa
left a comment
Contributor
There was a problem hiding this comment.
Didn't check tests at this point. Just the core implementation. Good clean up 👍
dabcoder
marked this pull request as ready for review
November 18, 2019 12:06
dabcoder
commented
Nov 18, 2019
dabcoder
commented
Nov 18, 2019
gzussa
suggested changes
Nov 18, 2019
gzussa
left a comment
gzussa
left a comment
Contributor
There was a problem hiding this comment.
Great. Made comment to push this further.
- Let's manually test this to make sure it work. I have a doubt that resetting the cache before submitting metrics may be a problem.
- Also we should go deeper testing
mttr,cycleTime,leadTimemetrics. Each deserve their own tests.
zippolyte
reviewed
Nov 25, 2019
zippolyte
reviewed
Nov 25, 2019
This was referenced Nov 27, 2019
Closed
zippolyte
reviewed
Nov 27, 2019
zippolyte
suggested changes
Nov 27, 2019
zippolyte
approved these changes
Nov 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jenkins.job.startedandjenkins.scm.checkoutmetrics.try catchstatements so build don't fail because of the plugin - see issue discussed in Provide option to post to local dogstatsd rather than going directly to the API #34 (however, in this PR we are removing DogStatsD dependency)