This repository was archived by the owner on Jan 23, 2020. It is now read-only.
code formatting and linting#160
Merged
Merged
Conversation
nmuesch
suggested changes
Aug 14, 2019
nmuesch
left a comment
nmuesch
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, nice cleanup! Left a few comments/questions
| import hudson.model.Run; | ||
| import hudson.model.TaskListener; | ||
| import hudson.model.*; | ||
| import hudson.model.listeners.RunListener; |
Contributor
There was a problem hiding this comment.
Do we need this sub import if we're doing hudson.model.* right above?
| import java.util.Arrays; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.logging.Level; |
| * | ||
| * @return - A boolean that checks if the targetMetricURL is valid | ||
| */ | ||
| public static boolean isValidMetricURL(final String targetMetricURL) { |
Contributor
Author
There was a problem hiding this comment.
It's not being used AFAICT
zippolyte
approved these changes
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.