This repository was archived by the owner on Jan 23, 2020. It is now read-only.
Send Delivery KPIs#156
Merged
Merged
Conversation
gzussa
suggested changes
Jun 3, 2019
gzussa
left a comment
gzussa
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this 👍 Clean and simple. Made some comments.
| } | ||
|
|
||
|
|
||
| private long getMeanTimeBetweenFailure(final Run run) { |
Contributor
There was a problem hiding this comment.
final doesn't seem to be needed here (same comment below)
| if (buildFailed(run.getPreviousBuiltBuild())) { | ||
| Run<?, ?> firstFailedRun = run.getPreviousBuiltBuild(); | ||
|
|
||
| while (buildFailed(firstFailedRun.getPreviousBuiltBuild())) { |
Contributor
There was a problem hiding this comment.
Could this lead to an infinite loop? Should we have a max just in case?
Contributor
Author
There was a problem hiding this comment.
I took a look at the Java docs (as I had a similar thought) and my read was that we'd stop at the root if there were no failed runs (which seems a bit unlikely to me though)
Contributor
There was a problem hiding this comment.
What about performance, could it be that it loops for so long that it makes the all thing slow. Maybe too far fetched. You tell me.
gzussa
approved these changes
Jun 3, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the work of #132 and adds on top of it.
Since 132 was a fork I couldn't add commits directly to it, I've made this new PR but was able to keep original commit authorship here.