Add a timeout to HTTP request connection and reads#150
Conversation
This prevents job hangs when the connection to datadog is flaky. Currently set to 3 minutes
|
nice work here! I really need this timeout functionality! Thanks @Mischa-Alff |
|
Hey @Mischa-Alff Thanks for the contribution 🙇 Do you think this would be helpful to be made configurable? |
|
Hey! What would the use case for being able to configure this be? |
|
Three minutes, while reasonable, seems a little arbitrary is all 😄 Just was wondering if you had thought it was worth it being user defined with a three minute default. I don't have a strong opinion on either option. |
|
I agree that it's arbitrary, I'm not sure the user cares about such an implementation detail though. |
|
@Mischa-Alff sorry for the delay on this one. Could you merge or rebase your branch against the master one? There has been some changes and the |
|
Closing this pull request since I am porting this change in #174. Thanks @Mischa-Alff |
5 participants
This prevents job hangs when the connection to datadog is flaky. Currently set to 3 minutes