This repository was archived by the owner on Jan 23, 2020. It is now read-only.
Improve reliability of determining hostname#15
Merged
Conversation
JohnLZeller
force-pushed
the
zeller/hostname
branch
from
September 22, 2015 21:54
2ea716f to
4cd2391
Compare
Contributor
Author
|
Tested, and everything looks good |
JohnLZeller
added a commit
that referenced
this pull request
Sep 22, 2015
Improve reliability of determining hostname
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #7, the hostname is not being pulled from the Jenkins host in a reliable fashion, and will often present as
null. This update provides the ability to set a hostname from the configuration panel, and if that is unavailable, the plugin will search for it in the Jenkins hostname environment variable, then the Unix hostname via/bin/hostname -f, and finally the localhost hostname, before instead returning null. This also ensures that logging of success/failure in finding a hostname is done.