Skip to content
This repository was archived by the owner on Jan 23, 2020. It is now read-only.

Run if apiKey is configured#145

Merged
sjenriquez merged 2 commits into
masterfrom
scott/null-api-key
Mar 1, 2019
Merged

Run if apiKey is configured#145
sjenriquez merged 2 commits into
masterfrom
scott/null-api-key

Conversation

@sjenriquez

@sjenriquez sjenriquez commented Mar 1, 2019

Copy link
Copy Markdown
Contributor
  • Only run if the Datadog API key is configured
  • Use Secret.toString() to avoid NPE's when plugin is installed but no API key is configured.

@sjenriquez sjenriquez changed the title Avoid NPE's when API key is not configured Run if apiKey is configured Mar 1, 2019
@sjenriquez
sjenriquez requested a review from nmuesch March 1, 2019 17:41

@nmuesch nmuesch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙇

@sjenriquez
sjenriquez merged commit 46b025d into master Mar 1, 2019
@sjenriquez
sjenriquez deleted the scott/null-api-key branch March 1, 2019 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants