Skip to content
This repository was archived by the owner on Jan 23, 2020. It is now read-only.

Don't sanitize whitelist and blacklist#109

Merged
sjenriquez merged 1 commit into
masterfrom
scott/no-sanitizing-whitelist-blacklist
Jan 10, 2018
Merged

Don't sanitize whitelist and blacklist#109
sjenriquez merged 1 commit into
masterfrom
scott/no-sanitizing-whitelist-blacklist

Conversation

@sjenriquez

@sjenriquez sjenriquez commented Jan 8, 2018

Copy link
Copy Markdown
Contributor

We shouldn't do any formatting to the whitelist and blacklist string entered in the config form. They are lowered and trimmed when we check jobs against the lists.

@truthbk truthbk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's not be too smart - we already sanitize the comma separated string here: #106

@sjenriquez
sjenriquez merged commit 1c37443 into master Jan 10, 2018
@sjenriquez
sjenriquez deleted the scott/no-sanitizing-whitelist-blacklist branch January 10, 2018 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants