drop bad queue time events#89
Merged
richardstartin merged 1 commit intomainfrom Apr 30, 2024
Merged
Conversation
Contributor
|
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
jbachorik
approved these changes
Apr 30, 2024
Collaborator
jbachorik
left a comment
jbachorik
left a comment
There was a problem hiding this comment.
Do we want to track the number of dropped events as a counter or we mostly don't care?
Contributor
Author
|
Dropping an event isn't too significant except at the trace level - it doesn't change sampling statistics, the events are latency thresholded and tend to occur in batches, so if we drop some during clearing the class map, we'll usually get some just before or after. We can revisit this if we want to change the way buffering works during dumping the recording. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Queue time events which are committed during a profiler dump may end up with null scheduler and task attributes, if they are committed just as the class map is being cleared, because the lock can't be acquired when looking up the class name. These events aren't very useful so we'll drop them for now.
Motivation:
Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!