fix async-sample mutex#107
Merged
Merged
Conversation
Contributor
|
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
MattAlp
approved these changes
Jun 12, 2024
r1viollet
reviewed
Jun 12, 2024
| _acquired = try_acquire(); | ||
| } | ||
|
|
||
| AsyncSampleMutex(AsyncSampleMutex& other) = delete; |
Contributor
There was a problem hiding this comment.
NIT: if we delete this one, we can adjust the other constructors (rule of 5) to ensure we can not copy/move or use = operators.
r1viollet
reviewed
Jun 12, 2024
| { | ||
| // Async events | ||
| AsyncSampleMutex mutex; | ||
| AsyncSampleMutex mutex(ProfiledThread::current()); |
Contributor
There was a problem hiding this comment.
Injecting the dependency is a good idea!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Fixes a bug ensuring we don't re-enter AsyncGetCallTrace
Motivation:
Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!