direct: fix sampling and visibility issues with new direct client #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iksaif
commented
May 30, 2024
iksaif
commented
- sampling should always be disabled for distribution values with the direct client this is the whole point of being able to send multiple distribution values at once
- don't make the direct client final, users might need to have to extend it (same for the noop client)
- sampling should always be disabled for distribution values with the direct client this is the whole point of being able to send multiple distribution values at once - don't make the direct client final, users might need to have to extend it (same for the noop client)
blemale
approved these changes
May 30, 2024
vickenty
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.