snowflake disable generic tags#9854
Merged
Merged
Conversation
Closed
ghost
added
djmitche
previously approved these changes
Aug 20, 2021
djmitche
left a comment
djmitche
left a comment
Contributor
There was a problem hiding this comment.
Changes to the base checks look good.
| - template: instances/global | ||
| - name: disable_generic_tags | ||
| description: | | ||
| Generic tags such as cluster will be replaced by <integration_name>_cluster to avoid |
Contributor
There was a problem hiding this comment.
Suggested change
| Generic tags such as cluster will be replaced by <integration_name>_cluster to avoid | |
| Generic tags such as `cluster` will be replaced by <integration_name>_cluster to avoid |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
coignetp
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #10027
Includes disable generic tag feature enabled by default for new installations and starts emitting a non generic tag for all installations