Skip to content

Add runtime configuration validation#8960

Merged
ofek merged 2 commits into
masterfrom
ofek/sync_config_models_network
Jun 11, 2021
Merged

Add runtime configuration validation#8960
ofek merged 2 commits into
masterfrom
ofek/sync_config_models_network

Conversation

@ofek

@ofek ofek commented Mar 22, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds config models from #8675

@ofek
ofek requested review from a team as code owners March 22, 2021 17:39
@ofek
ofek force-pushed the ofek/sync_config_models_network branch from 4a2b645 to 32a0391 Compare March 23, 2021 14:36
@ofek ofek changed the title Sync config models Add runtime configuration validation Mar 23, 2021
blacklist_conntrack_metrics: Optional[Sequence[str]]
collect_aws_ena_metrics: Optional[bool]
collect_connection_queues: Optional[bool]
collect_connection_state: bool

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look to be actually required

self._collect_cx_state = instance.get('collect_connection_state', False)

@codecov

codecov Bot commented May 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #8960 (414f2c0) into master (9c4771d) will increase coverage by 0.06%.
The diff coverage is n/a.

Flag Coverage Δ
network 77.76% <ø> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek
ofek force-pushed the ofek/sync_config_models_network branch from 32a0391 to 70e4f24 Compare June 11, 2021 13:27
@ghost ghost added the documentation label Jun 11, 2021
@ofek
ofek merged commit 231435d into master Jun 11, 2021
@ofek
ofek deleted the ofek/sync_config_models_network branch June 11, 2021 13:44
github-actions Bot pushed a commit that referenced this pull request Jun 11, 2021
alexandre-normand pushed a commit that referenced this pull request Jun 24, 2021
* Sync config models

* address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants