Add runtime configuration validation#8960
Merged
Merged
Conversation
ofek
force-pushed
the
ofek/sync_config_models_network
branch
from
March 23, 2021 14:36
4a2b645 to
32a0391
Compare
coignetp
reviewed
May 28, 2021
| blacklist_conntrack_metrics: Optional[Sequence[str]] | ||
| collect_aws_ena_metrics: Optional[bool] | ||
| collect_connection_queues: Optional[bool] | ||
| collect_connection_state: bool |
Contributor
There was a problem hiding this comment.
It doesn't look to be actually required
ofek
force-pushed
the
ofek/sync_config_models_network
branch
from
June 11, 2021 13:27
32a0391 to
70e4f24
Compare
coignetp
approved these changes
Jun 11, 2021
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Sync config models * address 231435d
alexandre-normand
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Sync config models * address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds config models from #8675