Skip to content

Rename config spec example consumer option default to display_default#8593

Merged
ofek merged 1 commit into
masterfrom
ofek/cs-default
Feb 11, 2021
Merged

Rename config spec example consumer option default to display_default#8593
ofek merged 1 commit into
masterfrom
ofek/cs-default

Conversation

@ofek

@ofek ofek commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

Motivation

The upcoming data model consumer will use the option default as the default value at runtime, which despite the name, currently does not mean that (see for example the vsphere change)

@ofek
ofek requested review from a team as code owners February 11, 2021 01:25
@ofek
ofek merged commit e6bce64 into master Feb 11, 2021
@ofek
ofek deleted the ofek/cs-default branch February 11, 2021 14:28
github-actions Bot pushed a commit that referenced this pull request Feb 11, 2021
@ofek
Rename config spec example consumer option default to `display_defa…
b1bfd1b 
…ult` (#8593) e6bce64
@AlexandreYang

AlexandreYang commented Feb 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

changelog/Changed should only apply to ddev change, but integration should use a changelog/Fixed label.

The plan is to:

Step 1: release ddev with changelog/Changed to have a major version bump #8613
Step 2: change label to changelog/Fixed, so other integration with have patch version bump

cc @ofek @FlorianVeaux

@ChristineTChen ChristineTChen mentioned this pull request Mar 8, 2021
Merged
4 tasks
ian28223 added a commit that referenced this pull request Jul 21, 2021
@ian28223
use display_default instead of default
038efa5 
Ref: #8593
`display_default` should now be used to generate defaults file
@ian28223 ian28223 mentioned this pull request Jul 21, 2021
Merged
4 tasks
ian28223 added a commit that referenced this pull request Jul 23, 2021
@ian28223
keep default as initial fallback (+1 squashed commit)
457f83f 
Squashed commits:
[038efa5] use display_default instead of default
Ref: #8593
`display_default` should now be used to generate defaults file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment