Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config spec support for options with multiple types #8378

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Add config spec support for options with multiple types #8378

merged 1 commit into from
Jan 18, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 17, 2021

@ofek ofek requested review from a team as code owners January 17, 2021 01:54
@ofek ofek mentioned this pull request Jan 17, 2021
Closed
kayayarai
kayayarai approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for documentation

@ofek ofek merged commit cf41525 into master Jan 18, 2021
@ofek ofek deleted the ofek/cs branch January 18, 2021 15:46
github-actions bot pushed a commit that referenced this pull request Jan 18, 2021
@ofek
Add config spec support for options with multiple types (#8378) cf41525
6010af9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

@kayayarai kayayarai kayayarai approved these changes

Assignees
No one assigned
Labels
dev/tooling documentation integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @hithwen @kayayarai