Skip to content

Correct default template usage#8233

Merged
ChristineTChen merged 5 commits into
masterfrom
cc/add-default-template
Dec 22, 2020
Merged

Correct default template usage#8233
ChristineTChen merged 5 commits into
masterfrom
cc/add-default-template

Conversation

@ChristineTChen

@ChristineTChen ChristineTChen commented Dec 21, 2020

Copy link
Copy Markdown
Contributor

What does this PR do?

#8232: ensures the default templates are present and correctly validated

This PR fixes the default templates missing or incorrect in config specs.

Motivation

Consistency and accuracy in supporting global options like tags, service, and global options.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen
ChristineTChen requested review from a team as code owners December 21, 2020 21:51
@codecov

codecov Bot commented Dec 21, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8233 (a7d96f6) into master (ffbc737) will decrease coverage by 4.67%.
The diff coverage is n/a.

Impacted Files Coverage Δ
istio/datadog_checks/istio/metrics.py
gearmand/datadog_checks/gearmand/gearmand.py
airflow/tests/test_integration_e2e.py
tcp_check/tests/test_integration.py
consul/tests/common.py
cloud_foundry_api/tests/conftest.py
dns_check/tests/mocks.py
fluentd/tests/conftest.py
directory/tests/test_directory.py
tcp_check/tests/test_tcp_check.py
... and 779 more

FlorianVeaux
FlorianVeaux previously approved these changes Dec 22, 2020
View reviewed changes
@ChristineTChen

ChristineTChen commented Dec 22, 2020

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 22, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@ChristineTChen

ChristineTChen commented Dec 22, 2020

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 22, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

ruthnaebeck
ruthnaebeck approved these changes Dec 22, 2020
View reviewed changes

@ruthnaebeck ruthnaebeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@ChristineTChen
ChristineTChen merged commit 728fdc3 into master Dec 22, 2020
@ChristineTChen
ChristineTChen deleted the cc/add-default-template branch December 22, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux left review comments
+1 more reviewer
@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation integration/cacti integration/disk integration/ecs_fargate integration/exchange_server integration/kafka_consumer integration/network integration/oracle integration/sqlserver integration/vertica

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristineTChen @ruthnaebeck @FlorianVeaux