Skip to content

Ensure default templates are included in config spec#8232

Merged
ChristineTChen merged 4 commits into
masterfrom
cc/validate-default-template
Dec 22, 2020
Merged

Ensure default templates are included in config spec#8232
ChristineTChen merged 4 commits into
masterfrom
cc/validate-default-template

Conversation

@ChristineTChen

@ChristineTChen ChristineTChen commented Dec 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Some config specs are missing default template. These templates are used by the agent/global and should be present in all integrations.

CI failing because of pending fixes: https://github.com/DataDog/integrations-core/pull/8233/files

Motivation

caught this in some contributor PRs and will make our own code reviews easier.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen
ChristineTChen requested a review from a team as a code owner December 21, 2020 21:31
@ChristineTChen ChristineTChen mentioned this pull request Dec 21, 2020
Merged
4 tasks
yzhan289
yzhan289 reviewed Dec 21, 2020
View reviewed changes
Comment thread datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/config.py Outdated
FlorianVeaux
FlorianVeaux previously approved these changes Dec 22, 2020
View reviewed changes
@ChristineTChen

ChristineTChen commented Dec 22, 2020

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Dec 22, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@codecov

codecov Bot commented Dec 22, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8232 (498c7a2) into master (269642b) will decrease coverage by 7.30%.
The diff coverage is n/a.

Impacted Files Coverage Δ
mysql/datadog_checks/mysql/mysql.py
hazelcast/datadog_checks/hazelcast/utils.py
dns_check/tests/test_integration.py
azure_iot_edge/tests/common.py
airflow/datadog_checks/airflow/airflow.py
haproxy/tests/legacy/test_unit.py
cisco_aci/datadog_checks/cisco_aci/helpers.py
...xtras/datadog_checks/linux_proc_extras/__init__.py
amazon_msk/tests/common.py
mapr/tests/common.py
... and 748 more

@ChristineTChen
ChristineTChen merged commit 4b7f0fd into master Dec 22, 2020
@ChristineTChen
ChristineTChen deleted the cc/validate-default-template branch December 22, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux left review comments
+1 more reviewer
@yzhan289 yzhan289 yzhan289 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dev/tooling integration/datadog_checks_dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristineTChen @FlorianVeaux @yzhan289