Backport #7985 and #8059 to 7.24.x: [network] Set the collect_connection_queues parameter default value to false#8062
Merged
Merged
Conversation
ghost
added
olivielpeau
approved these changes
Nov 20, 2020
L3n41c
changed the title
mx-psi
approved these changes
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Add a parameter to explicitly enable receive and send queues collection implemented in #7861.
Additional Notes
Receive and send queues collection generate two data points per
ss(ornetstat) line.The data are then aggregated on agent side in an histogram.
As this aggregation process can consume a lot of CPU, this feature now requires a new
networkcheck parametercollect_connection_queuesto be explicitly set totrueto enable this feature.Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached