Skip to content

[network] Set the collect_connection_queues parameter default value to false#8059

Merged
L3n41c merged 1 commit into
masterfrom
lenaic/network_recvsend_q_switch_default_false
Nov 20, 2020
Merged

[network] Set the collect_connection_queues parameter default value to false#8059
L3n41c merged 1 commit into
masterfrom
lenaic/network_recvsend_q_switch_default_false

Conversation

@L3n41c

@L3n41c L3n41c commented Nov 20, 2020

Copy link
Copy Markdown
Member

What does this PR do?

Set the collect_connection_queues parameter default value to false.

Motivation

On hosts which have a huge number of connection, the extra CPU and memory consumed

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@L3n41c
L3n41c requested review from a team as code owners November 20, 2020 11:40
@ghost ghost added the documentation label Nov 20, 2020
olivielpeau
olivielpeau previously approved these changes Nov 20, 2020
View reviewed changes
@L3n41c
L3n41c force-pushed the lenaic/network_recvsend_q_switch_default_false branch 2 times, most recently from f57a4d3 to 9939b80 Compare November 20, 2020 11:51
mx-psi
mx-psi previously approved these changes Nov 20, 2020
View reviewed changes
@L3n41c
L3n41c force-pushed the lenaic/network_recvsend_q_switch_default_false branch from 9939b80 to e919c46 Compare November 20, 2020 11:58
@codecov

codecov Bot commented Nov 20, 2020

Copy link
Copy Markdown

Codecov Report

Merging #8059 (e919c46) into master (149517f) will decrease coverage by 14.05%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
network/tests/test_network.py 97.67% <ø> (+3.48%) ⬆️
network/datadog_checks/network/network.py 61.36% <100.00%> (-4.66%) ⬇️
...er/datadog_checks/openstack_controller/settings.py
kyototycoon/tests/test_kyototycoon.py
http_check/tests/test_http_integration.py
mysql/datadog_checks/mysql/__init__.py
azure_iot_edge/tests/e2e_utils.py
kube_scheduler/tests/test_kube_scheduler_1_14.py
http_check/datadog_checks/http_check/http_check.py
... and 863 more

@hithwen
hithwen requested a review from a team November 20, 2020 12:30
@L3n41c
L3n41c requested a review from mx-psi November 20, 2020 12:38
@L3n41c
L3n41c merged commit d3cb568 into master Nov 20, 2020
@L3n41c
L3n41c deleted the lenaic/network_recvsend_q_switch_default_false branch November 20, 2020 13:05
L3n41c added a commit that referenced this pull request Nov 20, 2020
@L3n41c
[network] Set the collect_connection_queues parameter default value t…
352633f 
…o false (#8059)
L3n41c added a commit that referenced this pull request Nov 20, 2020
@L3n41c
Backport #7985 and #8059 to 7.24.x: [network] Set the collect_connect…
2bb1f54 
…ion_queues parameter default value to false (#8062)

* [network] Add a parameter to disable receive and send queues collection (#7985)

* [network] Set the collect_connection_queues parameter default value to false (#8059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hithwen hithwen hithwen approved these changes
@mx-psi mx-psi mx-psi approved these changes
@olivielpeau olivielpeau olivielpeau left review comments

Assignees

No one assigned

Labels

documentation integration/network

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@L3n41c @hithwen @olivielpeau @mx-psi