Skip to content

[network] Add a parameter to disable receive and send queues collection#7985

Merged
L3n41c merged 1 commit into
masterfrom
lenaic/network_recvsend_q_switch
Nov 10, 2020
Merged

[network] Add a parameter to disable receive and send queues collection#7985
L3n41c merged 1 commit into
masterfrom
lenaic/network_recvsend_q_switch

Conversation

@L3n41c

@L3n41c L3n41c commented Nov 9, 2020

Copy link
Copy Markdown
Member

What does this PR do?

Add a parameter to disable receive and send queues collection implemented in #7861.

Motivation

Receive and send queues collection generate two data points per ss (or netstat) line.
The data are then aggregated on agent side in an histogram.
If this aggregation process consumes too much CPU, a new network check parameter collect_connection_queues can be used to disable this feature.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@L3n41c
L3n41c requested review from a team as code owners November 9, 2020 21:41
@ghost ghost added the documentation label Nov 9, 2020
@L3n41c
L3n41c force-pushed the lenaic/network_recvsend_q_switch branch from e3f06fc to 779743d Compare November 10, 2020 08:48
@codecov

codecov Bot commented Nov 10, 2020

Copy link
Copy Markdown

Codecov Report

Merging #7985 (779743d) into master (78877d5) will decrease coverage by 10.85%.
The diff coverage is 81.81%.

Impacted Files Coverage Δ
network/datadog_checks/network/network.py 66.30% <81.81%> (+<0.01%) ⬆️
istio/datadog_checks/istio/metrics.py
dotnetclr/datadog_checks/dotnetclr/__about__.py
hdfs_datanode/tests/test_integration.py
coredns/tests/conftest.py
...atadog_checks/base/utils/prometheus/metrics_pb2.py
solr/datadog_checks/solr/__init__.py
ibm_was/tests/conftest.py
pgbouncer/tests/test_pgbouncer_integration_e2e.py
aspdotnet/datadog_checks/aspdotnet/__init__.py
... and 891 more

@L3n41c
L3n41c merged commit e1078ad into master Nov 10, 2020
@L3n41c
L3n41c deleted the lenaic/network_recvsend_q_switch branch November 10, 2020 11:05
L3n41c added a commit that referenced this pull request Nov 20, 2020
@L3n41c
[network] Add a parameter to disable receive and send queues collecti…
bbdfda3 
…on (#7985)
L3n41c added a commit that referenced this pull request Nov 20, 2020
@L3n41c
Backport #7985 and #8059 to 7.24.x: [network] Set the collect_connect…
2bb1f54 
…ion_queues parameter default value to false (#8062)

* [network] Add a parameter to disable receive and send queues collection (#7985)

* [network] Set the collect_connection_queues parameter default value to false (#8059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes
@mx-psi mx-psi mx-psi approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog documentation integration/network

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@L3n41c @olivielpeau @mx-psi