Fix network metric collection failure on CentOS#7883
Merged
3 commits merged intoOct 29, 2020
Merged
Conversation
ghost
added
ghost
self-requested a review
October 28, 2020 18:04
ghost
self-requested a review
as a code owner
October 28, 2020 18:04
ghost
force-pushed
the
mike.zhu/ss_path
branch
from
October 28, 2020 20:03
a9fd49f to
00364e2
Compare
ghost
force-pushed
the
mike.zhu/ss_path
branch
2 times, most recently
from
October 28, 2020 20:17
231a478 to
ad9d10a
Compare
Codecov Report
|
albertvaka
reviewed
Oct 28, 2020
ghost
force-pushed
the
mike.zhu/ss_path
branch
from
October 28, 2020 22:11
ad9d10a to
8b47706
Compare
ghost
self-requested a review
as a code owner
October 28, 2020 22:11
ghost
requested a review
from albertvaka
October 28, 2020 22:12
Author
|
PR All (Ignite) just failed, I don't see any particular code change might result in that failure. Will commit a dummy change and rerun. |
ghost
force-pushed
the
mike.zhu/ss_path
branch
2 times, most recently
from
October 28, 2020 23:17
4bff84f to
0058ec1
Compare
Author
|
0058ec1 was a test commit which I commented out my changes. Still I see PR All (Ignite) failed. I will uncomment out my code now and commit again. PR All (Ignite) is broken. |
ghost
force-pushed
the
mike.zhu/ss_path
branch
from
October 28, 2020 23:27
0058ec1 to
6e8cc2a
Compare
albertvaka
previously approved these changes
Oct 29, 2020
albertvaka
left a comment
albertvaka
left a comment
Contributor
There was a problem hiding this comment.
The failing tests seem unrelated to the change
ofek
requested changes
Oct 29, 2020
Contributor
|
@mikezhu-dd I'm looking at the Ignite fix, it's an unrelated but recurrent flake, feel free to merge regardless of the status of this job. |
ghost
requested a review
from ofek
October 29, 2020 15:35
…t.py Co-authored-by: Florimond Manca <[email protected]>
albertvaka
previously approved these changes
Oct 29, 2020
ghost
requested a review
from florimondmanca
October 29, 2020 20:26
ofek
approved these changes
Oct 29, 2020
ghost
deleted the
mike.zhu/ss_path
branch
October 29, 2020 20:44
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set PATH env to ensure "sh" command receive the same PATH as the caller process.
Motivation
Customers find network metric collection failure in CentOS, it's a regression from 7.22.1.
Additional Notes
None
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached