Skip to content

[network] Collect receive and send queue metrics#7861

Merged
L3n41c merged 1 commit into
masterfrom
lenaic/network_recvsend_q
Oct 28, 2020
Merged

[network] Collect receive and send queue metrics#7861
L3n41c merged 1 commit into
masterfrom
lenaic/network_recvsend_q

Conversation

@L3n41c

@L3n41c L3n41c commented Oct 27, 2020

Copy link
Copy Markdown
Member

What does this PR do?

Collect the send and receive queues metrics in the output of ss or netstat.

Motivation

The TCP queues length metrics are already gathered by the eBPF-based tcp-queue-length core check, but being able to collect those data from the network python check has the advantage of simplicity. There’s no need for running system-probe, installing the kernel headers, etc.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@L3n41c
L3n41c requested review from a team as code owners October 27, 2020 06:21
@L3n41c
L3n41c force-pushed the lenaic/network_recvsend_q branch 2 times, most recently from 304e05e to 4eccd8c Compare October 27, 2020 15:15
@L3n41c
L3n41c force-pushed the lenaic/network_recvsend_q branch from 4eccd8c to 7fcc081 Compare October 27, 2020 15:22
@codecov

codecov Bot commented Oct 27, 2020

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants