Skip to content

Collect connection state metrics on BSD/OSX#7659

Merged
hithwen merged 2 commits into
masterfrom
ian.bucad/bsd_cx_state
Oct 6, 2020
Merged

Collect connection state metrics on BSD/OSX#7659
hithwen merged 2 commits into
masterfrom
ian.bucad/bsd_cx_state

Conversation

@ian28223

@ian28223 ian28223 commented Sep 25, 2020

Copy link
Copy Markdown
Contributor

What does this PR do?

Collect cx state metrics on BSD platform (OSX)

Motivation

AGENT-4978

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ian28223
ian28223 requested review from a team as code owners September 25, 2020 06:29
@codecov

codecov Bot commented Sep 25, 2020

Copy link
Copy Markdown

Codecov Report

Merging #7659 into master will decrease coverage by 10.95%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
network/datadog_checks/network/network.py 64.37% <0.00%> (-2.30%) ⬇️
...dog_checks_base/tests/test_utils_agent_packages.py
etcd/datadog_checks/etcd/metrics.py
iis/datadog_checks/iis/iis.py
datadog_checks_dev/tests/test__env.py
activemq_xml/tests/conftest.py
istio/datadog_checks/istio/constants.py
nginx/datadog_checks/nginx/__init__.py
mysql/tests/tags.py
...oxy/datadog_checks/haproxy/legacy/version_utils.py
... and 882 more

@hithwen

hithwen commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

Are there new metrics that need to be added to metadata.csv?

@ian28223

ian28223 commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

Are there new metrics that need to be added to metadata.csv?

Nothing new; same ones we collect from a linux.

@hithwen
hithwen merged commit 4dfff1d into master Oct 6, 2020
@hithwen
hithwen deleted the ian.bucad/bsd_cx_state branch October 6, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hithwen hithwen hithwen approved these changes
+1 more reviewer
@albertvaka albertvaka albertvaka approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integration/network

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ian28223 @hithwen @albertvaka