Fix procfs_path retrieval in network check#7652
Merged
Merged
Conversation
ghost
added
the
Codecov Report
|
L3n41c
approved these changes
Sep 24, 2020
L3n41c
left a comment
L3n41c
left a comment
Member
There was a problem hiding this comment.
👍🏻
Thank you @vboulineau for taking care of that !
florimondmanca
approved these changes
Sep 25, 2020
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Yup, datadog_agent.get_config() over agentConfig is the way to go. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Running the network check in a container (#7095) does not work as the
procfs_pathvalue is not retrieved correctly, always defaulting to/proc.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached