Skip to content

Add the new env parameter to get_subprocess_output#7479

Merged
AlexandreYang merged 1 commit into
masterfrom
lenaic/get_subprocess_output_env
Sep 4, 2020
Merged

Add the new env parameter to get_subprocess_output#7479
AlexandreYang merged 1 commit into
masterfrom
lenaic/get_subprocess_output_env

Conversation

@L3n41c

@L3n41c L3n41c commented Sep 2, 2020

Copy link
Copy Markdown
Member

What does this PR do?

Add a new env parameter to get_subprocess_output to be able to specify custom environment variables when spawning subprocesses.

Motivation

Thanks to DataDog/datadog-agent#5987, it is now possible to use the env parameter of get_subprocess_output to explicitly set custom environment variables when spawning subprocesses.
This change needs to be reflected in the python code.
This will be used by #7095.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@L3n41c
L3n41c requested review from a team as code owners September 2, 2020 09:47
@L3n41c L3n41c mentioned this pull request Sep 2, 2020
Merged
4 tasks
@codecov

codecov Bot commented Sep 2, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7479 into master will increase coverage by 6.03%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pgbouncer/tests/conftest.py
envoy/tests/test_parser.py
kubelet/datadog_checks/kubelet/cadvisor.py
redisdb/datadog_checks/redisdb/__init__.py
...nkdb/datadog_checks/rethinkdb/document_db/utils.py
ssh_check/tests/test_ssh.py
...cks_dev/datadog_checks/dev/tooling/dependencies.py
couch/datadog_checks/couch/__about__.py
nginx/datadog_checks/nginx/nginx.py
nfsstat/datadog_checks/nfsstat/__init__.py
... and 726 more

AlexandreYang
AlexandreYang reviewed Sep 2, 2020
View reviewed changes

@AlexandreYang AlexandreYang left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@L3n41c note, we should merge DataDog/datadog-agent#5987 before this PR and wait for new docker image of the agent to be available.

Otherwise, that might break integrations-core CI.

@L3n41c

L3n41c commented Sep 4, 2020

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Sep 4, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AlexandreYang
AlexandreYang merged commit a708cfb into master Sep 4, 2020
@AlexandreYang
AlexandreYang deleted the lenaic/get_subprocess_output_env branch September 4, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexandreYang AlexandreYang AlexandreYang approved these changes
@olivielpeau olivielpeau olivielpeau approved these changes

Assignees

No one assigned

Labels

integration/datadog_checks_base

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@L3n41c @olivielpeau @AlexandreYang